* [PATCH] selftests: net: veth: propagate channel-check failures to exit status
@ 2026-11-15 21:21 Omokefe Emmanuel Onanaroghene
2026-11-15 21:34 ` Tianyi Gao
0 siblings, 1 reply; 3+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-15 21:21 UTC (permalink / raw)
To: kuba, tianyi, netdev, linux-kselftest, linux-kernel, bpf
Cc: davem, edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan, Omokefe Emmanuel Onanaroghene
chk_channels() reports mismatches with a "fail" line but never sets
ret, so the script exits 0 even when channel counts are wrong. Every
other check helper in the file (__chk_flag, chk_xdp_feature, chk_gro)
sets ret=1 on failure, and all chk_channels() call sites expect the
check to pass. Set ret=1 on mismatch.
Fixes: c017800af5c71 ("selftests: net: veth: test peer ndo-xmit after GRO toggle while down")
Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
---
tools/testing/selftests/net/veth.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
index 64c2a5a59821d..5c1dbe1516bb4 100755
--- a/tools/testing/selftests/net/veth.sh
+++ b/tools/testing/selftests/net/veth.sh
@@ -130,6 +130,7 @@ chk_channels() {
echo " ok "
else
echo " fail rx:$rx:$cur_rx tx:$tx:$cur_tx combined:n/a:$cur_combined"
+ ret=1
fi
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] selftests: net: veth: propagate channel-check failures to exit status
2026-11-15 21:21 [PATCH] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
@ 2026-11-15 21:34 ` Tianyi Gao
2026-11-15 22:02 ` Omokefe Emmanuel Onanaroghene
0 siblings, 1 reply; 3+ messages in thread
From: Tianyi Gao @ 2026-11-15 21:34 UTC (permalink / raw)
To: Omokefe Emmanuel Onanaroghene
Cc: kuba, netdev, linux-kselftest, linux-kernel, bpf, davem,
edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan
On Sun, 15 Nov 2026 22:21:16 +0100 Omokefe Emmanuel Onanaroghene wrote:
> Fixes: c017800af5c71 ("selftests: net: veth: test peer ndo-xmit after GRO toggle while down")
The Fixes tag should point to the commit that added chk_channels():
Fixes: 1ec2230fc721 ("selftests: net: veth: add tests for set_channel")
c017800af5c7 did not change this helper. The bug is present since
v5.15.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests: net: veth: propagate channel-check failures to exit status
2026-11-15 21:34 ` Tianyi Gao
@ 2026-11-15 22:02 ` Omokefe Emmanuel Onanaroghene
0 siblings, 0 replies; 3+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-15 22:02 UTC (permalink / raw)
To: tianyi, netdev, linux-kselftest, linux-kernel, bpf, kuba
Cc: davem, edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan, Omokefe Emmanuel Onanaroghene
On Sun, 15 Nov 2026 21:34:29 +0000 Tianyi Gao wrote:
> The Fixes tag should point to the commit that added chk_channels():
>
> Fixes: 1ec2230fc721 ("selftests: net: veth: add tests for set_channel")
>
> c017800af5c7 did not change this helper. The bug is present since
> v5.15.
Thank you for confirming. v2 already carries the corrected tag:
https://lore.kernel.org/all/20261115214702.50817-1-emmaonana18@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-15 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15 21:21 [PATCH] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-15 21:34 ` Tianyi Gao
2026-11-15 22:02 ` Omokefe Emmanuel Onanaroghene
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®