* [PATCH 1/2] drm/panel-edp: Fix Innolux N125HCE-GN1 mode
2026-11-16 12:11 [PATCH 0/2] MNT Reform 2: Fix the internal panel on i.MX8MQ Christian Gmeiner
@ 2026-11-16 12:11 ` Christian Gmeiner
2026-11-16 12:11 ` [PATCH 2/2] arm64: dts: imx8mq-mnt-reform2: Drive the internal panel from DCSS Christian Gmeiner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2026-11-16 12:11 UTC (permalink / raw)
To: Douglas Anderson, Neil Armstrong, Jessica Zhang,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Sam Ravnborg, Lukas F. Hartmann,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: dri-devel, linux-kernel, devicetree, imx, linux-arm-kernel,
Christian Gmeiner
From: Christian Gmeiner <cgmeiner@igalia.com>
The mode has a pixel clock of 162 MHz, which is 70 Hz. The EDID of the
panel only has 60 Hz and 40 Hz. Output of edid-decode:
DTD 1: 1920x1080 60.001038 Hz 16:9 66.721 kHz 138.780000 MHz
Hfront 46 Hsync 30 Hback 84 Hpol P
Vfront 2 Vsync 4 Vback 26 Vpol N
DTD 2: 1920x1080 40.000692 Hz 16:9 44.481 kHz 92.520000 MHz
Hfront 46 Hsync 30 Hback 84 Hpol P
Vfront 2 Vsync 4 Vback 26 Vpol N
On the MNT Reform 2 with i.MX8MQ the picture flickers at 70 Hz. Use the
60 Hz timing from the EDID.
Fixes: a14c6b0eef77 ("panel-simple: add Innolux N125HCE-GN1")
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
---
drivers/gpu/drm/panel/panel-edp.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index f7add22ccf69..0ebd756d14d0 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1364,15 +1364,16 @@ static const struct panel_desc innolux_n116bge = {
};
static const struct drm_display_mode innolux_n125hce_gn1_mode = {
- .clock = 162000,
+ .clock = 138780,
.hdisplay = 1920,
- .hsync_start = 1920 + 40,
- .hsync_end = 1920 + 40 + 40,
- .htotal = 1920 + 40 + 40 + 80,
+ .hsync_start = 1920 + 46,
+ .hsync_end = 1920 + 46 + 30,
+ .htotal = 1920 + 46 + 30 + 84,
.vdisplay = 1080,
- .vsync_start = 1080 + 4,
- .vsync_end = 1080 + 4 + 4,
- .vtotal = 1080 + 4 + 4 + 24,
+ .vsync_start = 1080 + 2,
+ .vsync_end = 1080 + 2 + 4,
+ .vtotal = 1080 + 2 + 4 + 26,
+ .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC,
};
static const struct panel_desc innolux_n125hce_gn1 = {
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 2/2] arm64: dts: imx8mq-mnt-reform2: Drive the internal panel from DCSS
2026-11-16 12:11 [PATCH 0/2] MNT Reform 2: Fix the internal panel on i.MX8MQ Christian Gmeiner
2026-11-16 12:11 ` [PATCH 1/2] drm/panel-edp: Fix Innolux N125HCE-GN1 mode Christian Gmeiner
@ 2026-11-16 12:11 ` Christian Gmeiner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2026-11-16 12:11 UTC (permalink / raw)
To: Douglas Anderson, Neil Armstrong, Jessica Zhang,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Sam Ravnborg, Lukas F. Hartmann,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: dri-devel, linux-kernel, devicetree, imx, linux-arm-kernel,
Christian Gmeiner
From: Christian Gmeiner <cgmeiner@igalia.com>
The panel is driven by LCDIF through the NWL MIPI-DSI host and a
SN65DSI86 eDP bridge. LCDIF underflows at 1920x1080. The picture shows
horizontal streaks and the underflow flag in LCDIF_CTRL1 is set several
times per second, even when idle.
DCSS does not have this problem. Connect it to the MIPI-DSI host and
leave LCDIF disabled.
Use IMX8MQ_CLK_DC_PIXEL as pixel clock, with the video PLL at four
times the panel pixel clock. The DCSS binding only allows three
assigned-clocks, so the PLL setup is in the MIPI-DSI node.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
---
.../boot/dts/freescale/imx8mq-mnt-reform2.dts | 52 ++++++++++++++++++++--
1 file changed, 48 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
index 3ae3824be027..31c7428f0386 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
@@ -171,17 +171,61 @@ edp_bridge_out: endpoint {
};
};
-&lcdif {
- assigned-clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
- assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>;
- /delete-property/assigned-clock-rates;
+&dcss {
+ clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>,
+ <&clk IMX8MQ_CLK_DISP_AXI_ROOT>,
+ <&clk IMX8MQ_CLK_DISP_RTRM_ROOT>,
+ <&clk IMX8MQ_CLK_DC_PIXEL>,
+ <&clk IMX8MQ_CLK_DISP_DTRC>;
+ assigned-clocks = <&clk IMX8MQ_CLK_DISP_AXI>,
+ <&clk IMX8MQ_CLK_DISP_RTRM>,
+ <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>;
+ assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>,
+ <&clk IMX8MQ_SYS1_PLL_800M>,
+ <&clk IMX8MQ_CLK_25M>;
status = "okay";
+
+ port {
+ dcss_dsi_out: endpoint {
+ remote-endpoint = <&mipi_dsi_dcss_in>;
+ };
+ };
+};
+
+&lcdif {
+ /delete-node/ port;
};
&mipi_dsi {
+ /*
+ * DCSS takes the pixel clock from the video PLL. The PLL runs at four
+ * times the 138.78 MHz panel pixel clock.
+ */
+ assigned-clocks = <&clk IMX8MQ_CLK_DSI_AHB>,
+ <&clk IMX8MQ_CLK_DSI_CORE>,
+ <&clk IMX8MQ_CLK_DSI_IPG_DIV>,
+ <&clk IMX8MQ_VIDEO_PLL1_BYPASS>,
+ <&clk IMX8MQ_CLK_DC_PIXEL>,
+ <&clk IMX8MQ_VIDEO_PLL1>;
+ assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_80M>,
+ <&clk IMX8MQ_SYS1_PLL_266M>,
+ <0>,
+ <&clk IMX8MQ_VIDEO_PLL1>,
+ <&clk IMX8MQ_VIDEO_PLL1_OUT>;
+ assigned-clock-rates = <80000000>, <266000000>, <20000000>, <0>, <0>,
+ <555120000>;
status = "okay";
ports {
+ port@0 {
+ /delete-node/ endpoint@0;
+
+ mipi_dsi_dcss_in: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&dcss_dsi_out>;
+ };
+ };
+
port@1 {
reg = <1>;
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread