mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/2] riscv: signal: fix the FP state restore in rt_sigreturn()
@ 2026-11-16  2:35 Nickolai Zeldovich
  2026-11-16  2:35 ` [PATCH v3 1/2] riscv: signal: mark the FP state clean before restoring it from the frame Nickolai Zeldovich
  2026-11-16  2:35 ` [PATCH v3 2/2] selftests: riscv: test FP state restore when rt_sigreturn() faults Nickolai Zeldovich
  0 siblings, 2 replies; 3+ messages in thread
From: Nickolai Zeldovich @ 2026-11-16  2:35 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, Andy Chiu, Guobin Zhang, Deepak Gupta,
	Shuah Khan, linux-riscv, linux-kselftest, linux-kernel,
	Nickolai Zeldovich

If rt_sigreturn() is preempted or sleeps on a page fault while it copies
the FP registers from the signal frame, the interrupted code resumes
with the signal handler's FP registers. Patch 1 fixes this, patch 2 adds
a selftest that reproduces it with userfaultfd.

Tested under QEMU with riscv64 defconfig plus CONFIG_USERFAULTFD: the
new test, built with GCC 15 through the kselftest Makefile and with
clang 21, fails 10 of 10 runs without patch 1 and passes 10 of 10 with
it.

This series was prepared with the help of an AI tool.

Changes in v3:
- selftest: load the tgkill() arguments inside the asm statement. v2
  bound them to local register variables, which GCC does not keep
  across the sigaltstack() call before the asm, so the signal was never
  sent and the test failed with or without patch 1 (Andy Chiu).
- Rebased onto v7.4-rc3.

v2: https://lore.kernel.org/all/20261031161826.858908-1-nickolai@csail.mit.edu/
v1: https://lore.kernel.org/all/20261016160708.790397-1-nickolai@csail.mit.edu/

Nickolai Zeldovich (2):
  riscv: signal: mark the FP state clean before restoring it from the
    frame
  selftests: riscv: test FP state restore when rt_sigreturn() faults

 arch/riscv/kernel/signal.c                    |   7 +
 .../selftests/riscv/sigreturn/.gitignore      |   1 +
 .../selftests/riscv/sigreturn/Makefile        |   5 +-
 .../selftests/riscv/sigreturn/fp_restore.c    | 147 ++++++++++++++++++
 4 files changed, 159 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/riscv/sigreturn/fp_restore.c


base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-16  2:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16  2:35 [PATCH v3 0/2] riscv: signal: fix the FP state restore in rt_sigreturn() Nickolai Zeldovich
2026-11-16  2:35 ` [PATCH v3 1/2] riscv: signal: mark the FP state clean before restoring it from the frame Nickolai Zeldovich
2026-11-16  2:35 ` [PATCH v3 2/2] selftests: riscv: test FP state restore when rt_sigreturn() faults Nickolai Zeldovich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®