From: Andrew Morton <akpm@linux-foundation.org>
To: Yingjie Wang <x-professor@outlook.com>
Cc: "shakeel.butt@linux.dev" <shakeel.butt@linux.dev>,
"manfred@colorfullife.com" <manfred@colorfullife.com>,
"legion@kernel.org" <legion@kernel.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"vasily.averin@linux.dev" <vasily.averin@linux.dev>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"mkoutny@suse.com" <mkoutny@suse.com>,
"mhocko@suse.com" <mhocko@suse.com>,
"alx@kernel.org" <alx@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] ipc/sem: account dynamically allocated sops arrays to memcg
Date: Mon, 16 Nov 2026 08:00:13 -0800 [thread overview]
Message-ID: <20261116080013.6a0e1f1a4d0421f432b39ec1@linux-foundation.org> (raw)
In-Reply-To: <179481695440.274194.11951572532773505066.semopm-shakeel@outlook.com>
On Mon, 16 Nov 2026 08:20:52 +0000 Yingjie Wang <x-professor@outlook.com> wrote:
> > There is no kmem accounting in root cgroup, do you know why there is an increase
> > of 2.3% there?
>
> I think the 2.3% mainly reflects boot-to-boot variation. The unchanged
> 64-operation stack path also slowed down by 1.9%, even though it does
> not reach the changed allocation.
>
> For successful calls, the per-boot medians were:
>
> nops V4 boots (ns) V5 boots (ns)
> 64 230.5 229.4 230.0 231.2 235.0 235.4
> 65 546.0 551.2 548.2 551.2 562.6 566.3
>
> The first V5 boot was very close to the upper end of the V4 results at
> 65 operations, while the later two boots were slower at both sizes.
> That is why I interpret the increase mainly as boot-to-boot variation,
> rather than root-cgroup charging.
>
> __GFP_ACCOUNT does still change the allocation path, including selecting
> the kmalloc-cg cache, so a small contribution from that is also possible.
>
> Andrew, could we clarify the root-cgroup result in the [1/3] changelog?
> Please change
>
> and successful calls in the root cgroup by at most 2.3%.
>
> to
>
> and successful calls in the root cgroup by at most 2.3%, which
> appears to be mainly boot-to-boot variation.
Yes, I have made both requested edits.
next prev parent reply other threads:[~2026-11-16 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 5:03 [PATCH v5 0/3] ipc/sem: account dynamic sops arrays and validate SEMOPM Yingjie Wang
2026-10-29 5:03 ` [PATCH v5 1/3] ipc/sem: account dynamically allocated sops arrays to memcg Yingjie Wang
2026-11-16 4:19 ` Shakeel Butt
2026-11-16 8:20 ` Yingjie Wang
2026-11-16 16:00 ` Andrew Morton [this message]
2026-10-29 5:03 ` [PATCH v5 2/3] ipc/sem: reject negative SEMOPM values Yingjie Wang
2026-10-29 5:03 ` [PATCH v5 3/3] ipc/sem: remove obsolete SEMOPM fragmentation warning Yingjie Wang
2026-11-15 22:12 ` [PATCH v5 0/3] ipc/sem: account dynamic sops arrays and validate SEMOPM Andrew Morton
2026-11-16 4:13 ` Shakeel Butt
2026-11-16 8:20 ` Yingjie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116080013.6a0e1f1a4d0421f432b39ec1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alx@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=hannes@cmpxchg.org \
--cc=legion@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=vasily.averin@linux.dev \
--cc=x-professor@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®