mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board
@ 2026-11-09  3:31 Sandie Cao
  2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Sandie Cao @ 2026-11-09  3:31 UTC (permalink / raw)
  To: Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel,
	Sandie Cao

This series updates Deepcomputing FML13V05 Device Tree: Add P1 PMIC 
regulator tree, add USB controller and USB phy, Enable SD card.

This series is rebased on next-20261105.

---
Changes in v4:
- [patch1]
  - Remove unused reg_aux_vcc3v3.
  - Rename p1@41 to pmic@41.
  - Add regulator-always-on for dldo4.
- [patch3]
  - Correct Onboard SD Card comment.
- Link to v3: https://lore.kernel.org/all/20261102060012.100623-1-
sandie.cao@deepcomputing.io/

Changes in v3:
- Remove useless gpio header.
- Add Onboard SD Card comment.
- Link to v2: https://lore.kernel.org/all/20261020081633.3673704-1-
sandie.cao@deepcomputing.io/

Changes in v2:
- Remove usb3b, usb3c node define in k3.dtsi, it's already uploaded by 
other patch.
- Add phys and phys-name define for usb3b, usb3c, usb3d in 
k3-deepcomputing-fml13v05.
- Remove cd-gpios, use non-removable for sdhci0. 
- Remove vmmc-supply for sdhci0.
- Link to v1: https://lore.kernel.org/all/20260922110231.3426011-1-
sandie.cao@deepcomputing.io/

---

Sandie Cao (3):
  riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator
    tree
  riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller
    and USB phy support
  riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card
    support

 .../spacemit/k3-deepcomputing-fml13v05.dts    | 220 ++++++++++++++++++
 1 file changed, 220 insertions(+)


base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
-- 
2.43.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree
  2026-11-09  3:31 [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
@ 2026-11-09  3:32 ` Sandie Cao
  2026-11-09  6:38   ` Troy Mitchell
  2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
  2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
  2 siblings, 1 reply; 13+ messages in thread
From: Sandie Cao @ 2026-11-09  3:32 UTC (permalink / raw)
  To: Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel,
	Sandie Cao

Add the P1 PMIC's regulator topology tree for DeepComputing FML13V05 board

Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
---
 .../spacemit/k3-deepcomputing-fml13v05.dts    | 148 ++++++++++++++++++
 1 file changed, 148 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
index b5d5112de358..e061233c15a3 100644
--- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
@@ -22,6 +22,154 @@ memory@100000000 {
 		device_type = "memory";
 		reg = <0x1 0x00000000 0x4 0x00000000>;
 	};
+
+	reg_aux_vcc5v: regulator-aux-vcc5v {
+		compatible = "regulator-fixed";
+		regulator-name = "AUX_VCC5V";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+};
+
+&i2c8 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c8_cfg>;
+	status = "okay";
+
+	pmic@41 {
+		compatible = "spacemit,p1";
+		reg = <0x41>;
+		interrupts = <64 IRQ_TYPE_LEVEL_HIGH>;
+		vin1-supply = <&reg_aux_vcc5v>;
+		vin2-supply = <&reg_aux_vcc5v>;
+		vin3-supply = <&reg_aux_vcc5v>;
+		vin4-supply = <&reg_aux_vcc5v>;
+		vin5-supply = <&reg_aux_vcc5v>;
+		vin6-supply = <&reg_aux_vcc5v>;
+		aldoin-supply = <&reg_aux_vcc5v>;
+		dldoin1-supply = <&buck4>;
+		dldoin2-supply = <&buck4>;
+
+		regulators {
+			buck1: buck1 {
+				regulator-min-microvolt = <1050000>;
+				regulator-max-microvolt = <1050000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck2: buck2 {
+				regulator-min-microvolt = <1050000>;
+				regulator-max-microvolt = <1050000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck3: buck3 {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <800000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck4: buck4 {
+				regulator-min-microvolt = <2100000>;
+				regulator-max-microvolt = <2100000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck5: buck5 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			buck6: buck6 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <500000>;
+				regulator-ramp-delay = <5000>;
+				regulator-always-on;
+			};
+
+			aldo1: aldo1 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			aldo2: aldo2 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			aldo3: aldo3 {
+				regulator-min-microvolt = <500000>;
+				regulator-max-microvolt = <3400000>;
+			};
+
+			aldo4: aldo4 {
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo1: dldo1 {
+				regulator-min-microvolt = <1200000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo2: dldo2 {
+				regulator-min-microvolt = <900000>;
+				regulator-max-microvolt = <900000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo3: dldo3 {
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo4: dldo4 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo5: dldo5 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo6: dldo6 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			dldo7: dldo7 {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+		};
+	};
 };
 
 &uart0 {
-- 
2.43.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support
  2026-11-09  3:31 [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
  2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
@ 2026-11-09  3:33 ` Sandie Cao
  2026-11-09  6:20   ` Troy Mitchell
  2026-11-14  7:30   ` Yixun Lan
  2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
  2 siblings, 2 replies; 13+ messages in thread
From: Sandie Cao @ 2026-11-09  3:33 UTC (permalink / raw)
  To: Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel,
	Sandie Cao

Add USB device node (b, c, d) to DeepComputing FML13V05 board.
USB A works on otg mode, it isn't configured currently.
- 4 USB-C Ports
     - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
     - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
     - Port 3 & 4: USB 3.2 Gen 1

Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
---
 .../spacemit/k3-deepcomputing-fml13v05.dts    | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
index e061233c15a3..bcd533484a73 100644
--- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
@@ -172,8 +172,58 @@ dldo7: dldo7 {
 	};
 };
 
+&combophy {
+	spacemit,apmu = <&syscon_apmu 0x17>;
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_0_cfg>;
 	status = "okay";
 };
+
+&usb2_host {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	hub@1 {
+		compatible = "usb5e3,608";
+		reg = <1>;
+	};
+};
+
+&usb2_phy {
+	status = "okay";
+};
+
+&usb3b_u2phy {
+	status = "okay";
+};
+
+&usb3b {
+	phys = <&usb3b_u2phy>, <&combophy 2 PHY_TYPE_USB3>;
+	phy-names = "usb2-phy", "usb3-phy";
+	status = "okay";
+};
+
+&usb3c_u2phy {
+	status = "okay";
+};
+
+&usb3c {
+	phys = <&usb3c_u2phy>, <&combophy 3 PHY_TYPE_USB3>;
+	phy-names = "usb2-phy", "usb3-phy";
+	status = "okay";
+};
+
+&usb3d_u2phy {
+	status = "okay";
+};
+
+&usb3d {
+	phys = <&usb3d_u2phy>, <&combophy 4 PHY_TYPE_USB3>;
+	phy-names = "usb2-phy", "usb3-phy";
+	status = "okay";
+};
-- 
2.43.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
  2026-11-09  3:31 [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
  2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
  2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
@ 2026-11-09  3:33 ` Sandie Cao
  2026-11-09  6:20   ` Troy Mitchell
  2026-11-14  7:55   ` Yixun Lan
  2 siblings, 2 replies; 13+ messages in thread
From: Sandie Cao @ 2026-11-09  3:33 UTC (permalink / raw)
  To: Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel,
	Sandie Cao

Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.

Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
---
 .../spacemit/k3-deepcomputing-fml13v05.dts    | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
index bcd533484a73..051046fe90b2 100644
--- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
@@ -177,6 +177,28 @@ &combophy {
 	status = "okay";
 };
 
+/*
+ * Onboard SD card slot:
+ * Please insert or remove the SD card while the device is powered off.
+ * It works as a boot media. so set it to non-removable.
+ */
+&sdhci0 {
+	pinctrl-names = "default","uhs";
+	pinctrl-0 = <&mmc1_cfg>;
+	pinctrl-1 = <&mmc1_uhs_cfg>;
+	bus-width = <4>;
+	non-removable;
+	no-mmc;
+	no-sdio;
+	disable-wp;
+	cap-sd-highspeed;
+	vqmmc-supply = <&aldo1>;
+	sd-uhs-sdr25;
+	sd-uhs-sdr50;
+	sd-uhs-sdr104;
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_0_cfg>;
-- 
2.43.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support
  2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
@ 2026-11-09  6:20   ` Troy Mitchell
  2026-11-14  7:30   ` Yixun Lan
  1 sibling, 0 replies; 13+ messages in thread
From: Troy Mitchell @ 2026-11-09  6:20 UTC (permalink / raw)
  To: Sandie Cao
  Cc: Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Mon, 9 Nov 2026 11:33:10 +0800, Sandie Cao wrote:
> Add USB device node (b, c, d) to DeepComputing FML13V05 board.
> USB A works on otg mode, it isn't configured currently.
> - 4 USB-C Ports
>      - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
>      - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
>      - Port 3 & 4: USB 3.2 Gen 1

This patch also enables usb2_host with a GL850G hub, which the commit
message doesn't mention.

Otherwise, LGTM.
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>


-- 
Troy Mitchell

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
  2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
@ 2026-11-09  6:20   ` Troy Mitchell
  2026-11-14  7:55   ` Yixun Lan
  1 sibling, 0 replies; 13+ messages in thread
From: Troy Mitchell @ 2026-11-09  6:20 UTC (permalink / raw)
  To: Sandie Cao, Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

On Mon Nov 9, 2026 at 3:33 AM GMT, Sandie Cao wrote:
> Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.
>
> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>


-- 
Troy Mitchell


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree
  2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
@ 2026-11-09  6:38   ` Troy Mitchell
  0 siblings, 0 replies; 13+ messages in thread
From: Troy Mitchell @ 2026-11-09  6:38 UTC (permalink / raw)
  To: Sandie Cao, Yixun Lan, Troy Mitchell, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: Alexandre Ghiti, devicetree, linux-riscv, spacemit, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Mon Nov 9, 2026 at 3:32 AM GMT, Sandie Cao wrote:
> Add the P1 PMIC's regulator topology tree for DeepComputing FML13V05 board
>
> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>


-- 
Troy Mitchell


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support
  2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
  2026-11-09  6:20   ` Troy Mitchell
@ 2026-11-14  7:30   ` Yixun Lan
  2026-11-16  2:54     ` Sandie Cao
  1 sibling, 1 reply; 13+ messages in thread
From: Yixun Lan @ 2026-11-14  7:30 UTC (permalink / raw)
  To: Sandie Cao
  Cc: Troy Mitchell, Conor Dooley, Rob Herring, Krzysztof Kozlowski,
	Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	devicetree, linux-riscv, spacemit, linux-kernel

Hi Sandie,

On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> Add USB device node (b, c, d) to DeepComputing FML13V05 board.
..
> USB A works on otg mode, it isn't configured currently.
Drop it, not really useful to mention there, irrelevant to this patch.

Currently, No USB A port support is merged in mainline code.
FYI, Chunyan submitted a patch for adding peripheral support of USB A.
https://lore.kernel.org/all/20261105103125.2727341-1-chunyan.zhang@linux.spacemit.com/


> - 4 USB-C Ports
      ~~~~~ USB Type-C? less confusing
>      - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
>      - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
>      - Port 3 & 4: USB 3.2 Gen 1

For "Port X" here, is it a naming from FML13V05's schematic?
would be great to mention which specific USB 3.0 controller (Port B, C, D)
 of the SoC it connect to..

> 
> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> ---
>  .../spacemit/k3-deepcomputing-fml13v05.dts    | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> index e061233c15a3..bcd533484a73 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> @@ -172,8 +172,58 @@ dldo7: dldo7 {
>  	};
>  };
>  
> +&combophy {
> +	spacemit,apmu = <&syscon_apmu 0x17>;
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_0_cfg>;
>  	status = "okay";
>  };
> +
> +&usb2_host {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	hub@1 {
> +		compatible = "usb5e3,608";
> +		reg = <1>;
> +	};
> +};
> +
> +&usb2_phy {
> +	status = "okay";
> +};
> +
> +&usb3b_u2phy {
> +	status = "okay";
> +};
> +
> +&usb3b {
> +	phys = <&usb3b_u2phy>, <&combophy 2 PHY_TYPE_USB3>;
> +	phy-names = "usb2-phy", "usb3-phy";
> +	status = "okay";
> +};
> +
> +&usb3c_u2phy {
> +	status = "okay";
> +};
> +
> +&usb3c {
> +	phys = <&usb3c_u2phy>, <&combophy 3 PHY_TYPE_USB3>;
> +	phy-names = "usb2-phy", "usb3-phy";
> +	status = "okay";
> +};
> +
> +&usb3d_u2phy {
> +	status = "okay";
> +};
> +
> +&usb3d {
> +	phys = <&usb3d_u2phy>, <&combophy 4 PHY_TYPE_USB3>;
> +	phy-names = "usb2-phy", "usb3-phy";
> +	status = "okay";
> +};
> -- 
> 2.43.0

-- 
Yixun Lan (dlan)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
  2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
  2026-11-09  6:20   ` Troy Mitchell
@ 2026-11-14  7:55   ` Yixun Lan
  2026-11-16  6:49     ` Sandie Cao
  1 sibling, 1 reply; 13+ messages in thread
From: Yixun Lan @ 2026-11-14  7:55 UTC (permalink / raw)
  To: Sandie Cao
  Cc: Troy Mitchell, Conor Dooley, Rob Herring, Krzysztof Kozlowski,
	Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	devicetree, linux-riscv, spacemit, linux-kernel

Hi Sandie,

On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.
> 
> Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> ---
>  .../spacemit/k3-deepcomputing-fml13v05.dts    | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> index bcd533484a73..051046fe90b2 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> @@ -177,6 +177,28 @@ &combophy {
>  	status = "okay";
>  };
>  
..
> +/*
> + * Onboard SD card slot:
> + * Please insert or remove the SD card while the device is powered off.
> + * It works as a boot media. so set it to non-removable.
> + */
Is there any public schematic available for FML13V05? I guess there is
no CD pin (Card Detect pin)? as no "cd-gpios" property seen here

The above comment isn't really useful or even correct, I'd suggest
drop it.

> +&sdhci0 {
> +	pinctrl-names = "default","uhs";
> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;
> +	bus-width = <4>;
..
> +	non-removable;
"no-removable" property usually used for emmc chip soldered on board,
 so there is no way it can be physically removed.. check 
Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml

For cases that no CD pin (or no GPIO CD pin) designed for SD card from
hardware schematic perspective, using "broken-cd" is a more proper way,
it will fallback to use poll mechanism to detect the card, please check

> +	no-mmc;
> +	no-sdio;
> +	disable-wp;
> +	cap-sd-highspeed;
> +	vqmmc-supply = <&aldo1>;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr104;
> +	status = "okay";
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_0_cfg>;
> -- 
> 2.43.0

-- 
Yixun Lan (dlan)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support
  2026-11-14  7:30   ` Yixun Lan
@ 2026-11-16  2:54     ` Sandie Cao
  0 siblings, 0 replies; 13+ messages in thread
From: Sandie Cao @ 2026-11-16  2:54 UTC (permalink / raw)
  To: Yixun Lan
  Cc: Troy Mitchell, Conor Dooley, Rob Herring, Krzysztof Kozlowski,
	Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	devicetree, linux-riscv, spacemit, linux-kernel

Hi, Yixun:

> From: "Yixun Lan"<dlan@kernel.org>
> Date:  Sat, Nov 14, 2026, 15:30
> Hi Sandie,
> 
> On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> > Add USB device node (b, c, d) to DeepComputing FML13V05 board.
> ..
> > USB A works on otg mode, it isn't configured currently.
> Drop it, not really useful to mention there, irrelevant to this patch.
> 
> Currently, No USB A port support is merged in mainline code.
> FYI, Chunyan submitted a patch for adding peripheral support of USB A.
> https://lore.kernel.org/all/20261105103125.2727341-1-chunyan.zhang@linux.spacemit.com/
> 

Ok, I will drop USB A in next version.
I prefer to  submit a new patch for USB A separately.

> 
> > - 4 USB-C Ports
>       ~~~~~ USB Type-C? less confusing
> >      - Port 1: PD 3.0 (65W Max), USB 3.2 Gen 1
> >      - Port 2: PD 3.0 (65W Max), USB 3.2 Gen 1, DP 1.4 (4K@60Hz)
> >      - Port 3 & 4: USB 3.2 Gen 1
> 
> For "Port X" here, is it a naming from FML13V05's schematic?
> would be great to mention which specific USB 3.0 controller (Port B, C, D)
>  of the SoC it connect to..
> 
> > 

I will correct above to Port B, C, D.

Best regards
Sandie

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
  2026-11-14  7:55   ` Yixun Lan
@ 2026-11-16  6:49     ` Sandie Cao
  2026-11-16  8:23       ` Yixun Lan
  0 siblings, 1 reply; 13+ messages in thread
From: Sandie Cao @ 2026-11-16  6:49 UTC (permalink / raw)
  To: Yixun Lan
  Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Alexandre Ghiti, devicetree,
	linux-riscv, spacemit, linux-kernel

Hi, Yixun:

> From: "Yixun Lan"<dlan@kernel.org>
> Date:  Sat, Nov 14, 2026, 15:55

> Hi Sandie,
> 
> On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> > Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.
> > 
> > Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> > ---
> >  .../spacemit/k3-deepcomputing-fml13v05.dts    | 22 +++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > index bcd533484a73..051046fe90b2 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > @@ -177,6 +177,28 @@ &combophy {
> >          status = "okay";
> >  };
> >  
> ..
> > +/*
> > + * Onboard SD card slot:
> > + * Please insert or remove the SD card while the device is powered off.
> > + * It works as a boot media. so set it to non-removable.
> > + */
> Is there any public schematic available for FML13V05? I guess there is
> no CD pin (Card Detect pin)? as no "cd-gpios" property seen here
> 
> The above comment isn't really useful or even correct, I'd suggest
> drop it.

In version 1 [1],  the patch is cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;
but K3_GPIO(88) is fake cd-gpio, it's tied low on board.
So In version2 [2], the patch changes to non-removable.
And In version3 [3], add comment. 

The options: cd-gpio, non-removable, broken-cd  all work on this board.

We just need to detect the SD card when bootup, don't need the driver 
to detect hot-plug event , non-removable should be suitable and faster, 
we recomment to use non-removable.


[1]: https://lore.kernel.org/all/20260922110231.3426011-1-sandie.cao
@deepcomputing.io/
[2]: https://lore.kernel.org/all/20261020081633.3673704-1-sandie.cao
@deepcomputing.io/
[3]: https://lore.kernel.org/all/20261102060012.100623-1-sandie.cao
@deepcomputing.io/

Best regards
Sandie

> 
> > +&sdhci0 {
> > +        pinctrl-names = "default","uhs";
> > +        pinctrl-0 = <&mmc1_cfg>;
> > +        pinctrl-1 = <&mmc1_uhs_cfg>;
> > +        bus-width = <4>;
> ..
> > +        non-removable;
> "no-removable" property usually used for emmc chip soldered on board,
>  so there is no way it can be physically removed.. check 
> Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> 
> For cases that no CD pin (or no GPIO CD pin) designed for SD card from
> hardware schematic perspective, using "broken-cd" is a more proper way,
> it will fallback to use poll mechanism to detect the card, please check
> 
> > +        no-mmc;
> > +        no-sdio;
> > +        disable-wp;
> > +        cap-sd-highspeed;
> > +        vqmmc-supply = <&aldo1>;
> > +        sd-uhs-sdr25;
> > +        sd-uhs-sdr50;
> > +        sd-uhs-sdr104;
> > +        status = "okay";
> > +};
> > +
> >  &uart0 {
> >          pinctrl-names = "default";
> >          pinctrl-0 = <&uart0_0_cfg>;
> > -- 
> > 2.43.0
> 
> -- 
> Yixun Lan (dlan)
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
  2026-11-16  6:49     ` Sandie Cao
@ 2026-11-16  8:23       ` Yixun Lan
  2026-11-16  9:52         ` Sandie Cao
  0 siblings, 1 reply; 13+ messages in thread
From: Yixun Lan @ 2026-11-16  8:23 UTC (permalink / raw)
  To: Sandie Cao
  Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Alexandre Ghiti, devicetree,
	linux-riscv, spacemit, linux-kernel

Hi Sandie,

On 14:49 Mon 16 Nov     , Sandie Cao wrote:
> Hi, Yixun:
> 
> > From: "Yixun Lan"<dlan@kernel.org>
> > Date:  Sat, Nov 14, 2026, 15:55
> 
> > Hi Sandie,
> > 
> > On 11:33 Mon 09 Nov     , Sandie Cao wrote:
> > > Add the device tree node SDHCI-0 controller for onboard Micro SD card slot.
> > > 
> > > Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
> > > ---
> > >  .../spacemit/k3-deepcomputing-fml13v05.dts    | 22 +++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > > index bcd533484a73..051046fe90b2 100644
> > > --- a/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > > +++ b/arch/riscv/boot/dts/spacemit/k3-deepcomputing-fml13v05.dts
> > > @@ -177,6 +177,28 @@ &combophy {
> > >          status = "okay";
> > >  };
> > >  
> > ..
> > > +/*
> > > + * Onboard SD card slot:
> > > + * Please insert or remove the SD card while the device is powered off.
> > > + * It works as a boot media. so set it to non-removable.
> > > + */
> > Is there any public schematic available for FML13V05? I guess there is
> > no CD pin (Card Detect pin)? as no "cd-gpios" property seen here
> > 
> > The above comment isn't really useful or even correct, I'd suggest
> > drop it.
> 
> In version 1 [1],  the patch is cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;
> but K3_GPIO(88) is fake cd-gpio, it's tied low on board.
So, there is gpio cd pin, but didn't work? it's hard to say without
the schematic, but can you check with hardware people, if it
can be fixed with SoC's internal GPIO BIAS pullup or pulldown?
So, gpio pin is able to reflect card insert status


> So In version2 [2], the patch changes to non-removable.
> And In version3 [3], add comment. 
> 
> The options: cd-gpio, non-removable, broken-cd  all work on this board.
> 
it works, but does not reflect the hardware status

> We just need to detect the SD card when bootup, don't need the driver 
> to detect hot-plug event , non-removable should be suitable and faster, 
> we recomment to use non-removable.
> 
No, this isn't a valid reason, it's use case should have nothing to do
with the property.

My point is: if the gpio cd pin still doesn't work, and the SD card is
actually physical plugable, then should use "broken-cd".
 
> 
> [1]: https://lore.kernel.org/all/20260922110231.3426011-1-sandie.cao
> @deepcomputing.io/
> [2]: https://lore.kernel.org/all/20261020081633.3673704-1-sandie.cao
> @deepcomputing.io/
> [3]: https://lore.kernel.org/all/20261102060012.100623-1-sandie.cao
> @deepcomputing.io/
> 
> Best regards
> Sandie
> 
> > 
> > > +&sdhci0 {
> > > +        pinctrl-names = "default","uhs";
> > > +        pinctrl-0 = <&mmc1_cfg>;
> > > +        pinctrl-1 = <&mmc1_uhs_cfg>;
> > > +        bus-width = <4>;
> > ..
> > > +        non-removable;
> > "no-removable" property usually used for emmc chip soldered on board,
> >  so there is no way it can be physically removed.. check 
> > Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> > 
> > For cases that no CD pin (or no GPIO CD pin) designed for SD card from
> > hardware schematic perspective, using "broken-cd" is a more proper way,
> > it will fallback to use poll mechanism to detect the card, please check
> > 
> > > +        no-mmc;
> > > +        no-sdio;
> > > +        disable-wp;
> > > +        cap-sd-highspeed;
> > > +        vqmmc-supply = <&aldo1>;
> > > +        sd-uhs-sdr25;
> > > +        sd-uhs-sdr50;
> > > +        sd-uhs-sdr104;
> > > +        status = "okay";
> > > +};
> > > +
> > >  &uart0 {
> > >          pinctrl-names = "default";
> > >          pinctrl-0 = <&uart0_0_cfg>;
> > > -- 
> > > 2.43.0
> > 
> > -- 
> > Yixun Lan (dlan)
> > 

-- 
Yixun Lan (dlan)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
  2026-11-16  8:23       ` Yixun Lan
@ 2026-11-16  9:52         ` Sandie Cao
  0 siblings, 0 replies; 13+ messages in thread
From: Sandie Cao @ 2026-11-16  9:52 UTC (permalink / raw)
  To: Yixun Lan
  Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Alexandre Ghiti, devicetree,
	linux-riscv, spacemit, linux-kernel

Hi, Yixun:

> From: "Yixun Lan"<dlan@kernel.org>
> Date:  Mon, Nov 16, 2026, 16:24

> > 
> > In version 1 [1],  the patch is cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;
> > but K3_GPIO(88) is fake cd-gpio, it's tied low on board.
> So, there is gpio cd pin, but didn't work? it's hard to say without
> the schematic, but can you check with hardware people, if it
> can be fixed with SoC's internal GPIO BIAS pullup or pulldown?
> So, gpio pin is able to reflect card insert status
> 
> 

I did check with our hardware team, and the answer is: 
there is a CD net on the slot, routed to K3_GPIO(88), but it is hard-tied
 to GND on the board. (v1 of this series used 
cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>, which of course
always reports "card present".) It is a direct connection to GND, not a
strap resistor, so the SoC's internal bias cannot pull it up.

> > So In version2 [2], the patch changes to non-removable.
> > And In version3 [3], add comment. 
> > 
> > The options: cd-gpio, non-removable, broken-cd  all work on this board.
> > 
> it works, but does not reflect the hardware status
> 
> > We just need to detect the SD card when bootup, don't need the driver 
> > to detect hot-plug event , non-removable should be suitable and faster, 
> > we recomment to use non-removable.
> > 
> No, this isn't a valid reason, it's use case should have nothing to do
> with the property.
> 
> My point is: if the gpio cd pin still doesn't work, and the SD card is
> actually physical plugable, then should use "broken-cd".

The SD card slot is onboard [1],  put the board into casing, there is no
way to plugin/ plugout the card. So there is no card-detect event that can
ever happen at runtime.

If you still prefer broken-cd,  I will follow in next version. 

[1]: https://deepcomputing.io/dc-roma-risc-v-mainboard-iii-unveiled-at-fosdem-powered-by-spacemit-k3-for-framework-laptop-13/

Best regards
Sandie

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-11-16  9:52 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-09  3:31 [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
2026-11-09  6:38   ` Troy Mitchell
2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
2026-11-09  6:20   ` Troy Mitchell
2026-11-14  7:30   ` Yixun Lan
2026-11-16  2:54     ` Sandie Cao
2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
2026-11-09  6:20   ` Troy Mitchell
2026-11-14  7:55   ` Yixun Lan
2026-11-16  6:49     ` Sandie Cao
2026-11-16  8:23       ` Yixun Lan
2026-11-16  9:52         ` Sandie Cao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®