* [PATCH 6.6] fs/stat.c: avoid harmless garbage value problem in vfs_statx()
@ 2026-11-16 10:21 Petr Vaganov
0 siblings, 0 replies; only message in thread
From: Petr Vaganov @ 2026-11-16 10:21 UTC (permalink / raw)
To: stable, Greg Kroah-Hartman
Cc: Petr Vaganov, Alexander Viro, Christian Brauner, Jan Kara,
Su Hui, linux-fsdevel, linux-kernel, lvc-project
From: Su Hui <suhui@nfschina.com>
commit 0fac3ed473dd2955053be6671cdd747807f5e488 upstream.
Clang static checker(scan-build) warning:
fs/stat.c:287:21: warning: The left expression of the compound assignment is
an uninitialized value. The computed value will also be garbage.
287 | stat->result_mask |= STATX_MNT_ID_UNIQUE;
| ~~~~~~~~~~~~~~~~~ ^
fs/stat.c:290:21: warning: The left expression of the compound assignment is
an uninitialized value. The computed value will also be garbage.
290 | stat->result_mask |= STATX_MNT_ID;
When vfs_getattr() failed because of security_inode_getattr(), 'stat' is
uninitialized. In this case, there is a harmless garbage problem in
vfs_statx_path(). It's better to return error directly when
vfs_getattr() failed, avoiding garbage value and more clearly.
Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20250119025946.1168957-1-suhui@nfschina.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
[ Petr: There is no vfs_statx_path() in this tree. The fix is applied
directly in vfs_statx() by jumping to path_put() via a new out_path
label, preserving the reference drop and the ESTALE retry. ]
Fixes: fa2fcf4f1df1 ("statx: add mount ID")
Signed-off-by: Petr Vaganov <petrvaganoff@gmail.com>
---
fs/stat.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/stat.c b/fs/stat.c
index 5375be5f97cc..9d3f1b276c86 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -246,6 +246,8 @@ static int vfs_statx(int dfd, struct filename *filename, int flags,
goto out;
error = vfs_getattr(&path, stat, request_mask, flags);
+ if (error)
+ goto out_path;
stat->mnt_id = real_mount(path.mnt)->mnt_id;
stat->result_mask |= STATX_MNT_ID;
@@ -262,6 +264,7 @@ static int vfs_statx(int dfd, struct filename *filename, int flags,
bdev_statx_dioalign(inode, stat);
}
+out_path:
path_put(&path);
if (retry_estale(error, lookup_flags)) {
lookup_flags |= LOOKUP_REVAL;
--
2.55.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-16 10:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 10:21 [PATCH 6.6] fs/stat.c: avoid harmless garbage value problem in vfs_statx() Petr Vaganov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®