mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4 0/1]  acpi: battery: Read Battery charge time for Steamdeck devices
@ 2026-11-16 10:27 Umang Jain
  2026-11-16 10:27 ` [PATCH v4 1/1] acpi: battery: Read Battery charge time("_BCT") " Umang Jain
  0 siblings, 1 reply; 2+ messages in thread
From: Umang Jain @ 2026-11-16 10:27 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown
  Cc: linux-acpi, linux-kernel, kernel-dev, Umang Jain

Patch to query Battery charge time ("_BCT") from ACPI tables
for steamdeck devices to determine when low power PSU is connected,
which is discharging the device.

changes in v4:
- Merge both 1/2 and 2/2 into single patch
- Set quirk and _BCT reading at same place
- Edit comments for the same.
- Log failed message as acpi_handle_debug()
- Split case when _BCT value > ACPI_UINT32_MAX

Changes in v3:
- Only query BCT method for the steamdeck quirk
- Drop charge_time member from battery object
- check for returned value from acpi_evaluate_integer for max
  ACPI_UINT32_MAX bounds as per the spec
Link: https://lore.kernel.org/all/20261014204558.466130-1-uajain@igalia.com/

Changes in v2:
- comment improvements
- split off BCT method handling into separate patch
- https://lore.kernel.org/all/20260923082932.1049270-1-uajain@igalia.com/

v1:
https://lore.kernel.org/all/20260918135628.2322188-1-uajain@igalia.com/

Umang Jain (1):
  acpi: battery: Read Battery charge time("_BCT") for Steamdeck devices

 drivers/acpi/battery.c | 49 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v4 1/1] acpi: battery: Read Battery charge time("_BCT") for Steamdeck devices
  2026-11-16 10:27 [PATCH v4 0/1] acpi: battery: Read Battery charge time for Steamdeck devices Umang Jain
@ 2026-11-16 10:27 ` Umang Jain
  0 siblings, 0 replies; 2+ messages in thread
From: Umang Jain @ 2026-11-16 10:27 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown
  Cc: linux-acpi, linux-kernel, kernel-dev, Umang Jain

Valve steamdeck devices can report battery status as
charging, even when low-powered power supply is connected
to the device. The battery status is reported as charging
through sysfs, even though in reality, it is discharging.

To address this, introduce a battery quirk for Valve Steamdeck devices
ACPI_BATTERY_QUIRK_VALVE_STEAMDECK. This is required to detect
if a low-power supply unit is connected to the device.
To handle this case, read out Battery charge time ("_BCT")
as it is reported accurately on these devices and use that
information for report charging vs discharging status.
Battery charge time ("_BCT") with an eligible power supply unit
will have valid values whereas with a low-powered supply unit,
it shall report ACPI_BATTERY_VALUE_UNKNOWN. Use this as a
differentiator to determine, whether the battery of steamdeck
devices is really charging or not.

Signed-off-by: Umang Jain <uajain@igalia.com>
---
 drivers/acpi/battery.c | 49 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 48 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 6edea559a5bc..458c2b23a05a 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -94,6 +94,15 @@ enum {
 	 * on a full charge, but showing degradation in full charge cap.
 	 */
 	ACPI_BATTERY_QUIRK_DEGRADED_FULL_CHARGE,
+	/*
+	 * Valve steamdeck devices can get discharged even when battery status
+	 * is charging. This happens typically when low power supply unit is
+	 * connected. To accurately determine this scenario, we shall read
+	 * battery charge time ("_BCT") and set this quirk. This is the key
+	 * differentiator to determine whether the steamdeck is actually
+	 * charging or not.
+	 */
+	ACPI_BATTERY_QUIRK_VALVE_STEAMDECK,
 };
 
 struct acpi_battery {
@@ -234,7 +243,7 @@ static int acpi_battery_get_property(struct power_supply *psy,
 					: POWER_SUPPLY_STATUS_DISCHARGING;
 				return 0;
 			}
-		else if (battery->state & ACPI_BATTERY_STATE_CHARGING)
+		else if (battery->state & ACPI_BATTERY_STATE_CHARGING) {
 			/* Check the rate and capacity to validate the status. */
 			if (!acpi_battery_is_full(battery) ||
 			    (battery->rate_now != ACPI_BATTERY_VALUE_UNKNOWN &&
@@ -244,6 +253,27 @@ static int acpi_battery_get_property(struct power_supply *psy,
 				/* Full and zero rate. */
 				val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
 			}
+
+			if (test_bit(ACPI_BATTERY_QUIRK_VALVE_STEAMDECK, &battery->flags)) {
+				unsigned long long bct;
+				acpi_status status;
+				union acpi_object arg0 = { ACPI_TYPE_INTEGER };
+				struct acpi_object_list args = { 1, &arg0 };
+
+				arg0.integer.value = 100;
+				status = acpi_evaluate_integer(battery->device->handle, "_BCT",
+							       &args, &bct);
+				if (ACPI_FAILURE(status))
+					acpi_handle_debug(battery->device->handle,
+							  "_BCT evaluation failed: %s",
+							  acpi_format_exception(status));
+				else if (bct > ACPI_UINT32_MAX)
+					acpi_handle_debug(battery->device->handle,
+							  "_BCT value is invalid");
+				else if (bct == ACPI_BATTERY_VALUE_UNKNOWN)
+					val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
+			}
+		}
 		else if (battery->state & ACPI_BATTERY_STATE_CHARGE_LIMITING)
 			val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
 		else if (acpi_battery_is_charged(battery))
@@ -1150,6 +1180,23 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
 		set_bit(ACPI_BATTERY_QUIRK_DEGRADED_FULL_CHARGE, &battery->flags);
 		battery->capacity_now = battery->full_charge_capacity;
 	}
+
+	if (test_bit(ACPI_BATTERY_QUIRK_VALVE_STEAMDECK, &battery->flags))
+		return;
+
+	/*
+	 * For Valve Steamdeck devices, determine _BCT presence as well before
+	 * setting its battery quirk.
+	 */
+	if (dmi_name_in_vendors("Valve") &&
+	    acpi_has_method(battery->device->handle, "_BCT")) {
+		const char *name;
+
+		name = dmi_get_system_info(DMI_PRODUCT_NAME);
+		if ((name && (!strncmp("Jupiter", name, 7))) ||
+		    (name && (!strncmp("Galileo", name, 7))))
+			set_bit(ACPI_BATTERY_QUIRK_VALVE_STEAMDECK, &battery->flags);
+	}
 }
 
 static int acpi_battery_update(struct acpi_battery *battery, bool resume)
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-16 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 10:27 [PATCH v4 0/1] acpi: battery: Read Battery charge time for Steamdeck devices Umang Jain
2026-11-16 10:27 ` [PATCH v4 1/1] acpi: battery: Read Battery charge time("_BCT") " Umang Jain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®