mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [tip: x86/urgent] x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing
@ 2026-11-16  6:05 tip-bot2 for Nathan Chancellor
  2026-11-16  9:40 ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: tip-bot2 for Nathan Chancellor @ 2026-11-16  6:05 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Nathan Chancellor, Borislav Petkov (AMD), stable, x86, linux-kernel

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     2946884aff3d0e67227df3b4d3bcd9c3357a3b78
Gitweb:        https://git.kernel.org/tip/2946884aff3d0e67227df3b4d3bcd9c3357a3b78
Author:        Nathan Chancellor <nathan@kernel.org>
AuthorDate:    Sun, 15 Nov 2026 21:30:43 -07:00
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Sun, 15 Nov 2026 20:43:50 -08:00

x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing

When cross compiling x86_64 from an aarch64 machine using clang with
CONFIG_X86_NATIVE_CPU enabled (such as when using allmodconfig), there may be
a slew of warnings from each .c file, which makes it nearly impossible to find
real issues.

  '+crc' is not a recognized feature for this target (ignoring feature)
  '+fp-armv8' is not a recognized feature for this target (ignoring feature)
  '+lse' is not a recognized feature for this target (ignoring feature)
  '+neon' is not a recognized feature for this target (ignoring feature)
  '+sha2' is not a recognized feature for this target (ignoring feature)
  '+sha3' is not a recognized feature for this target (ignoring feature)
  '-rand' is not a recognized feature for this target (ignoring feature)
  '-sme' is not a recognized feature for this target (ignoring feature)
  '-sme2' is not a recognized feature for this target (ignoring feature)
  '-sve' is not a recognized feature for this target (ignoring feature)

Internally, clang expands '-march=native' into a list of target features to
enable based on the detected CPU. The x86 part of the clang driver notes

  // FIXME: Reject attempts to use -march=native unless the target matches
  // the host.

which was first added by the initial '-march=native' support in clang in 2009¹
(other architecture drivers appear to have a similar problem).  Due to the lack
of validation that the host CPU is an x86_64 CPU, '-march=native' is expanded
using the aarch64 host CPU's target features, which are unrecognized by the x86
backend.

While this should obviously be fixed in the compiler, this does not help
currently released toolchains that have this issue. As a simple workaround that
makes sense regardless of the toolchain issue, only allow CONFIG_X86_NATIVE_CPU
to be enabled when CONFIG_COMPILE_TEST is not set (i.e., the user intends to run
the kernel, not just build it), which will exclude it from allmodconfig.

  ¹https://github.com/llvm/llvm-project/commit/e13ada6a3b236f505b24501d456dec2518e4944c

Fixes: ea1dcca1de12 ("x86/kbuild/64: Add the CONFIG_X86_NATIVE_CPU option to locally optimize the kernel with '-march=native'")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20261113-x86-no-march-native-on-non-x86_64-v1-1-cbc8b096d1c4@kernel.org
---
 arch/x86/Kconfig.cpu | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
index 6e7a366..32d22cb 100644
--- a/arch/x86/Kconfig.cpu
+++ b/arch/x86/Kconfig.cpu
@@ -217,6 +217,7 @@ config RUSTC_HAS_APXF
 config X86_NATIVE_CPU
 	bool "Build and optimize for local/native CPU"
 	depends on X86_64
+	depends on !COMPILE_TEST
 	depends on CC_HAS_MARCH_NATIVE
 	depends on !RUST || RUSTC_HAS_APXF
 	help

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [tip: x86/urgent] x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing
  2026-11-16  6:05 [tip: x86/urgent] x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing tip-bot2 for Nathan Chancellor
@ 2026-11-16  9:40 ` Ingo Molnar
  2026-11-16 13:01   ` Nathan Chancellor
  0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2026-11-16  9:40 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-tip-commits, Nathan Chancellor, Borislav Petkov (AMD),
	stable, x86, Linus Torvalds


* tip-bot2 for Nathan Chancellor <tip-bot2@linutronix.de> wrote:

> which was first added by the initial '-march=native' support in clang in 2009¹
> (other architecture drivers appear to have a similar problem).  Due to the lack
> of validation that the host CPU is an x86_64 CPU, '-march=native' is expanded
> using the aarch64 host CPU's target features, which are unrecognized by the x86
> backend.
> 
> While this should obviously be fixed in the compiler, this does not help
> currently released toolchains that have this issue. As a simple workaround that
> makes sense regardless of the toolchain issue, only allow CONFIG_X86_NATIVE_CPU
> to be enabled when CONFIG_COMPILE_TEST is not set (i.e., the user intends to run
> the kernel, not just build it), which will exclude it from allmodconfig.
> 
>   ¹https://github.com/llvm/llvm-project/commit/e13ada6a3b236f505b24501d456dec2518e4944c
> 
> Fixes: ea1dcca1de12 ("x86/kbuild/64: Add the CONFIG_X86_NATIVE_CPU option to locally optimize the kernel with '-march=native'")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20261113-x86-no-march-native-on-non-x86_64-v1-1-cbc8b096d1c4@kernel.org
> ---
>  arch/x86/Kconfig.cpu | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
> index 6e7a366..32d22cb 100644
> --- a/arch/x86/Kconfig.cpu
> +++ b/arch/x86/Kconfig.cpu
> @@ -217,6 +217,7 @@ config RUSTC_HAS_APXF
>  config X86_NATIVE_CPU
>  	bool "Build and optimize for local/native CPU"
>  	depends on X86_64
> +	depends on !COMPILE_TEST

I really don't like this patch. People *do* use this feature,
and it's good to have it enabled in allmodconfig.

Another problem is that this turns off most automated x86-on-x86
build testing of CONFIG_X86_NATIVE_CPU in essence, at least for the
typical configs that CI farms test, just to make much more rare
types of cross-builds a bit more convenient...

Can we just limit the feature to when host == target, ie. to not
work it around in such a crude fashion?

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [tip: x86/urgent] x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing
  2026-11-16  9:40 ` Ingo Molnar
@ 2026-11-16 13:01   ` Nathan Chancellor
  0 siblings, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2026-11-16 13:01 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: linux-kernel, linux-tip-commits, Borislav Petkov (AMD),
	stable, x86, Linus Torvalds

On Mon, Nov 16, 2026 at 10:40:01AM +0100, Ingo Molnar wrote:
> Can we just limit the feature to when host == target, ie. to not
> work it around in such a crude fashion?

That was my v1 but Boris didn't like it:

  https://lore.kernel.org/20261113-x86-no-march-native-on-non-x86_64-v1-1-cbc8b096d1c4@kernel.org

-- 
Cheers,
Nathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-16 13:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16  6:05 [tip: x86/urgent] x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing tip-bot2 for Nathan Chancellor
2026-11-16  9:40 ` Ingo Molnar
2026-11-16 13:01   ` Nathan Chancellor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®