mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Andre Eikmeyer <dev@deq.rocks>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org,
	Yossef Osman <Yossef.Osman@proton.me>,
	Aditya Garg <aditya.garg@linux.dev>,
	Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364
Date: Mon, 16 Nov 2026 21:37:17 +0100	[thread overview]
Message-ID: <20261116203719.281605-1-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20261104151620.70671-1-dev@deq.rocks>

On Wed, 4 Nov 2026 16:16:20 +0100, Andre Eikmeyer <dev@deq.rocks> wrote:
> brcmfmac enables the firmware's ARP and IPv6 ND offload (ndoe) whenever
> the interface is up and not promiscuous. On the Apple firmware for the
> BCM4364, ndoe makes IPv6 downloads collapse.

[...]

> ---
>  .../net/wireless/broadcom/brcm80211/brcmfmac/core.c    | 10 ++++++++++
>  1 file changed, 10 insertions(+)

> @@ -103,6 +104,15 @@ void brcmf_configure_arp_nd_offload(struct brcmf_if *ifp, bool enable)
>  		return;
>  	}
>
> +	/* With ND offload on while awake, the Apple firmware for the BCM4364
> +	 * makes IPv6 downloads drop to low rates. macOS runs ARP and ND
> +	 * offload only in sleep, keep both off on this chip.
> +	 */
> +	if (enable && ifp->drvr->bus_if->chip == BRCM_CC_4364_CHIP_ID) {
> +		brcmf_dbg(TRACE, "Skip ARP/ND offload enable on BCM4364\n");
> +		enable = false;
> +	}
> +
>  	if (enable)
>  		mode = BRCMF_ARP_OL_AGENT | BRCMF_ARP_OL_PEER_AUTO_REPLY;
>  	else

A few comments:

1) The measurements only implicate ndoe. Do you have data showing arpoe
also needs to be off? Otherwise please limit this to ND offload.

2) The commit message says this is an issue of the Apple firmware, but the
check is on the chip ID only. The same chip IDs are also used with other
firmware builds and boards (WCC/non-Apple), which would lose the feature
needlessly. Please restrict the quirk to the affected platform, e.g. with
the Apple board type (settings->board_type) or a per-firmware quirk, or
move it to the vendor feat_attach callback instead of a chip check in
this helper. The same applies to the other chip ID quirks of this batch
(txbf and FWAUTH).

3) This looks like a bug fix. Please add a Fixes: tag and Cc: stable (as
Aditya suggested), and mark the target tree in the subject.

[...]

Regards,
Arend

  parent reply	other threads:[~2026-11-16 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:16 Andre Eikmeyer
2026-11-06 12:06 ` Aditya Garg
2026-11-16 20:37 ` Arend van Spriel [this message]
2026-11-18  7:08   ` Aditya Garg
2026-11-18  9:42   ` André Eikmeyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116203719.281605-1-arend.vanspriel@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=Yossef.Osman@proton.me \
    --cc=aditya.garg@linux.dev \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=dev@deq.rocks \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®