mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Eikmeyer" <dev@deq.rocks>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org,
	Yossef Osman <Yossef.Osman@proton.me>,
	Aditya Garg <aditya.garg@linux.dev>
Subject: Re: [PATCH] wifi: brcmfmac: keep ARP and ND offload off on the BCM4364
Date: Wed, 18 Nov 2026 10:42:04 +0100	[thread overview]
Message-ID: <20261118104049.39e4d3a2@kait2en-mbp15-1> (raw)
In-Reply-To: <20261116203719.281605-1-arend.vanspriel@broadcom.com>

On Mon, 16 Nov 2026 21:37:17 +0100
Arend van Spriel <arend.vanspriel@broadcom.com> wrote:

> 1) The measurements only implicate ndoe. Do you have data showing
> arpoe also needs to be off? Otherwise please limit this to ND offload.

Well, scratching my head here as well. The throughput drop is ND alone,
with only ND offload off the MacBookPro 15,1 reaches the full 120 Mbit/s
as well. I keep ARP offload off anyway because that is how macOS runs
this firmware. The macOS trace shows arpoe, nd_hostip_clear and ndoe
set to 0 together on wake, and both offloads are only enabled on entry
to associated sleep. Apple checks emails, Siri and whatnots on sleep.I
can't look into the firmware, and with ARP offload on while awake we
would run it in a configuration Apple does not use. With both off it
has run on the community machines for weeks without problems.We can
enable it but may require another few weeks until we can confirm it's
stable.

> 2) [...] Please restrict the quirk to the affected platform, e.g. with
> the Apple board type (settings->board_type) [...] The same applies to
> the other chip ID quirks of this batch (txbf and FWAUTH).

Will do!

> 3) This looks like a bug fix. Please add a Fixes: tag and Cc: stable
> (as Aditya suggested), and mark the target tree in the subject.

Yes, v2 goes to wireless with both.

Andre

      parent reply	other threads:[~2026-11-18  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 15:16 Andre Eikmeyer
2026-11-06 12:06 ` Aditya Garg
2026-11-16 20:37 ` Arend van Spriel
2026-11-18  7:08   ` Aditya Garg
2026-11-18  9:42   ` André Eikmeyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118104049.39e4d3a2@kait2en-mbp15-1 \
    --to=dev@deq.rocks \
    --cc=Yossef.Osman@proton.me \
    --cc=aditya.garg@linux.dev \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®