* [PATCH] wifi: brcmfmac: leave the AP 4-way handshake to the host on Apple chips
@ 2026-11-04 15:16 Andre Eikmeyer
2026-11-16 20:37 ` Arend van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Andre Eikmeyer @ 2026-11-04 15:16 UTC (permalink / raw)
To: arend.vanspriel
Cc: linux-wireless, brcm80211, brcm80211-dev-list.pdl, linux-kernel,
Andre Eikmeyer, Yossef Osman, Aditya Garg
The Apple firmware for the BCM4364 and BCM4377 lists "idauth" in its
capabilities, so brcmfmac enables BRCMF_FEAT_FWAUTH and advertises
NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK. hostapd and wpa_supplicant
then pass the PSK to the driver and leave the AP side of the 4-way
handshake to the firmware. On the BCM4364 that handshake never
completes. The client associates, no EAPOL-Key frame is sent, and the
firmware removes the station after about 8 s.
Measured on a MacBookPro15,1 (BCM4364/3, firmware 9.30.514.0.32.5.94,
FWID 01-47278712) with a WPA2-PSK access point and a Samsung Galaxy
S22 Ultra as client:
offload advertised: NEW_STATION, DEL_STATION 7.8 s later, no EAPOL
offload not advertised: 4-way handshake by wpa_supplicant completes,
AP-STA-CONNECTED, DHCP lease, traffic flows
Clear BRCMF_FEAT_FWAUTH on the chips in Apple's T2 Macs, so the host
runs the handshake.
Tested-by: Yossef Osman <Yossef.Osman@proton.me>
Tested-by: Aditya Garg <aditya.garg@linux.dev>
Signed-off-by: Andre Eikmeyer <dev@deq.rocks>
---
The KaiT2en community runs this patch with its kernels, no regression
was reported.
.../wireless/broadcom/brcm80211/brcmfmac/feature.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index 488364e..05e9750 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -318,6 +318,20 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
BIT(BRCMF_FEAT_WOWL_GTK);
}
}
+ /* The Apple firmware for these chips lists "idauth", but in AP mode
+ * its authenticator never completes the 4-way handshake and the
+ * station is dropped after about 8 s. Leave the handshake to the host.
+ */
+ switch (drvr->bus_if->chip) {
+ case BRCM_CC_4355_CHIP_ID:
+ case BRCM_CC_4364_CHIP_ID:
+ case BRCM_CC_4377_CHIP_ID:
+ ifp->drvr->feat_flags &= ~BIT(BRCMF_FEAT_FWAUTH);
+ break;
+ default:
+ break;
+ }
+
/* MBSS does not work for all chips */
switch (drvr->bus_if->chip) {
case BRCM_CC_4330_CHIP_ID:
--
2.56.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: brcmfmac: leave the AP 4-way handshake to the host on Apple chips
2026-11-04 15:16 [PATCH] wifi: brcmfmac: leave the AP 4-way handshake to the host on Apple chips Andre Eikmeyer
@ 2026-11-16 20:37 ` Arend van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend van Spriel @ 2026-11-16 20:37 UTC (permalink / raw)
To: Andre Eikmeyer
Cc: arend.vanspriel, linux-wireless, brcm80211,
brcm80211-dev-list.pdl, linux-kernel, Yossef Osman, Aditya Garg
On Wed, 4 Nov 2026 16:16:29 +0100, Andre Eikmeyer <dev@deq.rocks> wrote:
> The Apple firmware for the BCM4364 and BCM4377 lists "idauth" in its
> capabilities, so brcmfmac enables BRCMF_FEAT_FWAUTH and advertises
> NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK. hostapd and wpa_supplicant
> then pass the PSK to the driver and leave the AP side of the 4-way
> handshake to the firmware. On the BCM4364 that handshake never
> completes.
>
> [...]
>
> Clear BRCMF_FEAT_FWAUTH on the chips in Apple's T2 Macs, so the host
> runs the handshake.
[...]
> ---
> .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> @@ -318,6 +318,20 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
> BIT(BRCMF_FEAT_WOWL_GTK);
> }
> }
> + /* The Apple firmware for these chips lists "idauth", but in AP mode
> + * its authenticator never completes the 4-way handshake and the
> + * station is dropped after about 8 s. Leave the handshake to the host.
> + */
> + switch (drvr->bus_if->chip) {
> + case BRCM_CC_4355_CHIP_ID:
> + case BRCM_CC_4364_CHIP_ID:
> + case BRCM_CC_4377_CHIP_ID:
> + ifp->drvr->feat_flags &= ~BIT(BRCMF_FEAT_FWAUTH);
> + break;
> + default:
> + break;
> + }
> +
> /* MBSS does not work for all chips */
> switch (drvr->bus_if->chip) {
The commit message and the test report only cover BCM4364 and BCM4377,
but the code also clears FWAUTH for BCM4355. Where does that come from?
Was it tested, and is BCM4355 found in T2 Macs? If not, please drop it
or justify it.
The chip ID check has the same problem as in the ARP/ND offload patch [1]:
the issue is described as specific to the Apple firmware, but the quirk
applies to every BCM4355, BCM4364 and BCM4377, and those users would lose
offloaded AP PSK. Please restrict it as suggested there.
Note that BRCMF_FEAT_FWAUTH is required for NL80211_EXT_FEATURE_SAE_OFFLOAD_AP
in brcmf_setup_wiphy(). Please mention in the commit message whether
that is affected on these chips (i.e. whether the firmware offers "sae"
at all) or confirm it is intentionally dropped too.
Have you looked at the actual root cause (e.g. missing/incorrect
"idauth" related iovars such as setting the PMK or wsec_info for AP on
this firmware)? If the offload is never usable on these firmwares, say
so in the commit message with reference to the firmware version(s)
checked.
[...]
Minor: please add the target tree to the subject (wifibot series_format
warning).
[1] https://lore.kernel.org/all/20261104151620.70671-1-dev@deq.rocks/
Regards,
Arend
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-16 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-04 15:16 [PATCH] wifi: brcmfmac: leave the AP 4-way handshake to the host on Apple chips Andre Eikmeyer
2026-11-16 20:37 ` Arend van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®