* [PATCH] PCI: fu740: Check return value of clk_prepare_enable()
@ 2026-11-16 20:49 Jayaraj Devaraj
0 siblings, 0 replies; only message in thread
From: Jayaraj Devaraj @ 2026-11-16 20:49 UTC (permalink / raw)
To: Manivannan Sadhasivam, Krzysztof Wilczyński,
Lorenzo Pieralisi, Bjorn Helgaas
Cc: Paul Walmsley, Greentime Hu, Samuel Holland, Rob Herring,
Philipp Zabel, linux-pci, linux-riscv, linux-kernel,
Jayaraj Devaraj
fu740_pcie_host_init() ignores the return value of the second
clk_prepare_enable() call on pcie_aux, so a failure to enable the
clock is silently ignored and the controller is programmed anyway.
Check the return value and propagate the error.
Signed-off-by: Jayaraj Devaraj <jayarajdmit@gmail.com>
---
drivers/pci/controller/dwc/pcie-fu740.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
index 00ec69a09164..b2eded23b52c 100644
--- a/drivers/pci/controller/dwc/pcie-fu740.c
+++ b/drivers/pci/controller/dwc/pcie-fu740.c
@@ -270,7 +270,11 @@ static int fu740_pcie_host_init(struct dw_pcie_rp *pp)
/* Clear hold_phy_rst */
writel_relaxed(0x0, afp->mgmt_base + PCIEX8MGMT_APP_HOLD_PHY_RST);
/* Enable pcieauxclk */
- clk_prepare_enable(afp->pcie_aux);
+ ret = clk_prepare_enable(afp->pcie_aux);
+ if (ret) {
+ dev_err(dev, "unable to re-enable pcie_aux clock\n");
+ return ret;
+ }
/* Set RC mode */
writel_relaxed(0x4, afp->mgmt_base + PCIEX8MGMT_DEVICE_TYPE);
--
2.34.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-16 20:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 20:49 [PATCH] PCI: fu740: Check return value of clk_prepare_enable() Jayaraj Devaraj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®