mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
Cc: Oliver Neukum <oneukum@suse.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net,
	linux-kernel@vger.kernel.org,
	smartmontools-support@listi.jpberlin.de,
	Christian Franke <Christian.Franke@t-online.de>
Subject: Re: [PATCH] usb: uas: expose US_FL_NO_ATA_1X in sysfs as deny_ata_passthrough
Date: Mon, 16 Nov 2026 10:36:23 +0100	[thread overview]
Message-ID: <2026111639-paprika-smock-4b01@gregkh> (raw)
In-Reply-To: <20261115124046.5286-1-mat.jonczyk@o2.pl>

On Sun, Nov 15, 2026 at 01:40:46PM +0100, Mateusz Jończyk wrote:
> The uas driver blocks access to ATA passthrough commands for some
> devices it considers buggy (via the US_FL_NO_ATA_1X flag in
> unusual_uas.h and uas_detect.h). However, it does not expose any
> meaningful information whether the command was blocked by the driver or
> is genuinly not supported by the hardware. This creates a problem for
> the smartmontools program and makes it difficult for it to provide a
> useful error message (with instructions to disable UAS on the drive to
> get SMART readings).
> 
> So, expose the information in sysfs as deny_ata_passthrough. Other
> quirks may be added in the future if there is any demand.
> 
> Link: https://www.smartmontools.org/wiki/SAT-with-UAS-Linux
> Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
> ---
>  drivers/usb/storage/uas.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
> index 8655edbd66b1..aaea74297026 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -910,6 +910,25 @@ static int uas_sdev_configure(struct scsi_device *sdev,
>  	return 0;
>  }
>  
> +/* Sysfs interface */
> +static ssize_t deny_ata_passthrough_show(struct device *dev, struct device_attribute *attr,
> +					 char *buf)
> +{
> +	struct scsi_device *sdev = to_scsi_device(dev);
> +	struct uas_dev_info *devinfo = sdev->hostdata;
> +
> +	return sprintf(buf, "%d\n", !!(devinfo->flags & US_FL_NO_ATA_1X));
> +}
> +
> +static DEVICE_ATTR_RO(deny_ata_passthrough);
> +
> +static struct attribute *uas_sdev_attrs[] = {
> +	&dev_attr_deny_ata_passthrough.attr,
> +	NULL,
> +};
> +
> +ATTRIBUTE_GROUPS(uas_sdev);

Sorry, but random sysfs atttributes that are not documented are not a
good idea.  Especially ones that don't even use sysfs_emit().

thanks,

greg k-0h

      parent reply	other threads:[~2026-11-16  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 12:40 Mateusz Jończyk
2026-11-15 15:52 ` Alan Stern
2026-11-15 18:26   ` Mateusz Jończyk
2026-11-16  9:36 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026111639-paprika-smock-4b01@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Christian.Franke@t-online.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mat.jonczyk@o2.pl \
    --cc=oneukum@suse.com \
    --cc=smartmontools-support@listi.jpberlin.de \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®