* [PATCH v2] alpha: Use symbol assignment in SYM_END
@ 2026-11-17 0:07 Linus Walleij
0 siblings, 0 replies; only message in thread
From: Linus Walleij @ 2026-11-17 0:07 UTC (permalink / raw)
To: Richard Henderson, Matt Turner, Magnus Lindholm
Cc: linux-alpha, linux-kernel, kernel test robot, Linus Walleij
Alpha uses the .set directive to select assembler options, so the
symbol assignment emitted by the generic SYM_END macro fails to assemble.
This breaks COMPILE_TEST builds left and right, e.g.:
Error: junk at end of line, first unrecognized character is `,'
Error: .size expression for bcm6846_runner_start does not evaluate to a constant
Override SYM_END to use an ordinary symbol assignment for the calculated
size. Preserve the symbol type, size and local size symbol while leaving
other architectures unchanged.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202611031620.n4ptlpo7-lkp@intel.com/
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
The generic SYM_END uses .set for symbol assignment, but Alpha interprets
.set as an assembler mode directive. Provide an Alpha override using
ordinary assignment.
Tested the unchanged Runner wrapper with an Alpha-targeted GNU assembler
2.46.1: the original header reproduces the reported errors, while the
fixed header assembles without warnings. Symbol sizes and the embedded
Runner bytes were checked. A full Alpha allyesconfig build was not run.
This patch was prepared with LLM assistance.
---
Changes in v2:
- Use __ASSEMBLER__ instead of __ASSEMBLY__, as requested by Thomas Huth.
- Link to v1: https://patch.msgid.link/20261103-alpha-compile-v1-1-9e93e2260a9f@kernel.org
---
arch/alpha/include/asm/linkage.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/alpha/include/asm/linkage.h b/arch/alpha/include/asm/linkage.h
index aa8661fa60dc..275de8ac693b 100644
--- a/arch/alpha/include/asm/linkage.h
+++ b/arch/alpha/include/asm/linkage.h
@@ -6,4 +6,12 @@
#define SYSCALL_ALIAS(alias, name) \
asm ( #alias " = " #name "\n\t.globl " #alias)
+#ifdef __ASSEMBLER__
+/* Alpha uses .set for assembler options, not symbol assignments. */
+#define SYM_END(name, sym_type) \
+ .type name sym_type ASM_NL \
+ .L__sym_size_##name = . - name ASM_NL \
+ .size name, .L__sym_size_##name
+#endif
+
#endif
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261103-alpha-compile-efdde587115c
Best regards,
--
Linus Walleij <linusw@kernel.org>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-17 0:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 0:07 [PATCH v2] alpha: Use symbol assignment in SYM_END Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®