* [PATCH] s390/kdump: write protect the crash kernel memory by its virtual address
@ 2026-11-17 14:01 Mike Rapoport (Microsoft)
2026-11-17 15:31 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Mike Rapoport (Microsoft) @ 2026-11-17 14:01 UTC (permalink / raw)
To: Alexander Gordeev, Heiko Carstens, Vasily Gorbik
Cc: Christian Borntraeger, Mike Rapoport, Sven Schnelle,
linux-kernel, linux-s390
crash_protect_pages() passes crashk_res.start to set_memory_ro() and
set_memory_rw(). That is a physical address. Since the identity mapping
may start above zero, it is not the address of the crash kernel memory
in the kernel page tables.
With CONFIG_RANDOMIZE_IDENTITY_BASE the page table walk finds no mapping
at that address and fails. The error is ignored, and the crash kernel
memory stays writable after "kexec -p" loads it.
Use the identity mapping address of the crash kernel memory.
Fixes: c98d2ecae08f ("s390/mm: Uncouple physical vs virtual address spaces")
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
---
I found this while working on a generic implementation of the set_memory
APIs. Only build tested.
---
arch/s390/kernel/machine_kexec.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/s390/kernel/machine_kexec.c b/arch/s390/kernel/machine_kexec.c
index baeb3dcfc1c8..20ea3018462f 100644
--- a/arch/s390/kernel/machine_kexec.c
+++ b/arch/s390/kernel/machine_kexec.c
@@ -151,15 +151,16 @@ void crash_free_reserved_phys_range(unsigned long begin, unsigned long end)
static void crash_protect_pages(int protect)
{
- unsigned long size;
+ unsigned long addr, size;
if (!crashk_res.end)
return;
+ addr = (unsigned long)__va(crashk_res.start);
size = resource_size(&crashk_res);
if (protect)
- set_memory_ro(crashk_res.start, size >> PAGE_SHIFT);
+ set_memory_ro(addr, size >> PAGE_SHIFT);
else
- set_memory_rw(crashk_res.start, size >> PAGE_SHIFT);
+ set_memory_rw(addr, size >> PAGE_SHIFT);
}
void arch_kexec_protect_crashkres(void)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261117-fixes-s390-82943938787a
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/kdump: write protect the crash kernel memory by its virtual address
2026-11-17 14:01 [PATCH] s390/kdump: write protect the crash kernel memory by its virtual address Mike Rapoport (Microsoft)
@ 2026-11-17 15:31 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2026-11-17 15:31 UTC (permalink / raw)
To: Mike Rapoport (Microsoft)
Cc: Alexander Gordeev, Vasily Gorbik, Christian Borntraeger,
Sven Schnelle, linux-kernel, linux-s390
On Tue, Nov 17, 2026 at 04:01:04PM +0200, Mike Rapoport (Microsoft) wrote:
> crash_protect_pages() passes crashk_res.start to set_memory_ro() and
> set_memory_rw(). That is a physical address. Since the identity mapping
> may start above zero, it is not the address of the crash kernel memory
> in the kernel page tables.
>
> With CONFIG_RANDOMIZE_IDENTITY_BASE the page table walk finds no mapping
> at that address and fails. The error is ignored, and the crash kernel
> memory stays writable after "kexec -p" loads it.
>
> Use the identity mapping address of the crash kernel memory.
>
> Fixes: c98d2ecae08f ("s390/mm: Uncouple physical vs virtual address spaces")
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> I found this while working on a generic implementation of the set_memory
> APIs. Only build tested.
> ---
> arch/s390/kernel/machine_kexec.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 14:01 [PATCH] s390/kdump: write protect the crash kernel memory by its virtual address Mike Rapoport (Microsoft)
2026-11-17 15:31 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®