* [PATCH] rpmsg: glink: hold idr_lock while completing open_ack
@ 2026-11-17 3:05 Changyul Lee
0 siblings, 0 replies; only message in thread
From: Changyul Lee @ 2026-11-17 3:05 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier
Cc: linux-remoteproc, linux-arm-msm, linux-kernel, Changyul Lee
qcom_glink_rx_open_ack() looks up the channel in lcids under idr_lock,
drops the lock and then completes channel->open_ack.
qcom_glink_create_local() waits for that completion for five seconds.
If the wait times out at the same moment, it removes the lcid under
idr_lock and drops the last two references, which frees the channel.
The OPEN_ACK handler then reads channel->name for the trace event and
calls complete_all() on freed memory.
Keep idr_lock held until complete_all() returns. The timeout path
removes the lcid under the same lock before dropping its references,
so the channel cannot be freed while the lock is held. Taking a
channel reference instead would not work here, because the handler
runs in interrupt context and the final put may call
cancel_work_sync() from qcom_glink_channel_release().
Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Signed-off-by: Changyul Lee <lcy8047@gmail.com>
---
Found with a static analysis tool we are developing.
Compile-tested only, with x86_64_defconfig plus MAILBOX, RPMSG_QCOM_GLINK_RPM
and W=1.
drivers/rpmsg/qcom_glink_native.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index f848ab46161d..862565bf965d 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1101,16 +1101,17 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid)
spin_lock(&glink->idr_lock);
channel = idr_find(&glink->lcids, lcid);
- spin_unlock(&glink->idr_lock);
trace_qcom_glink_cmd_open_ack_rx(glink->label, channel ? channel->name : NULL,
lcid, channel ? channel->rcid : 0);
if (!channel) {
+ spin_unlock(&glink->idr_lock);
dev_err(glink->dev, "Invalid open ack packet\n");
return -EINVAL;
}
complete_all(&channel->open_ack);
+ spin_unlock(&glink->idr_lock);
return 0;
}
base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-17 3:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 3:05 [PATCH] rpmsg: glink: hold idr_lock while completing open_ack Changyul Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®