mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v5 0/2] usb: gadget: u_ether: fix out-of-bounds read in get_ether_addr
@ 2026-11-17  9:00 Liu Chao
  2026-11-17  9:00 ` [PATCH v5 1/2] lib/net_utils: allow mac_pton() to take a custom delimiter Liu Chao
  2026-11-17  9:00 ` [PATCH v5 2/2] usb: gadget: u_ether: fix out-of-bounds read in get_ether_addr Liu Chao
  0 siblings, 2 replies; 3+ messages in thread
From: Liu Chao @ 2026-11-17  9:00 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Andrew Morton
  Cc: Andy Shevchenko, David S . Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Simon Horman, khtsai, fangxy, Randy Dunlap,
	dbrownell, linux-usb, linux-kernel, netdev

Rework of

  [PATCH v4] usb: gadget: u_ether: fix out-of-bounds read in get_ether_addr
  https://lore.kernel.org/all/20261106030605.576584-1-liuc63@xiaopeng.com/

following Andy's review of v4: 1/2 prepares a parse_mac_pton() helper in
lib/net_utils.c, 2/2 uses it in get_ether_addr().

The two patches belong to different trees: 1/2 touches lib/ and should go
via netdev or -mm, 2/2 is for the USB tree.  2/2 depends on 1/2, so it
can only be applied once 1/2 has reached Linus' tree.

Changes since v4:
  - no driver code change; the C diff of both patches is byte identical
    to v4, only documentation and the commit messages changed
  - 1/2: reword the parse_mac_pton() kernel-doc: @s must be at least
    MAC_ADDR_STR_LEN characters long, and only the first
    MAC_ADDR_STR_LEN characters are checked, the rest ignored
  - 2/2: describe the configfs behaviour change accurately: a rejected
    address makes the store fail with -EINVAL and keep its previous
    value, while only the legacy module parameters fall back to a random
    address
  - 2/2: name all five functions that reach the parser (ECM, EEM, NCM,
    RNDIS, subset) and document the accepted formats in their configfs
    ABI files
  - 2/2: restore a Fixes: tag pointing at 1da177e4c3f4
    ("Linux-2.6.12-rc2"), the start of the official git era, keeping the
    commit that really introduced the loop named in prose
  - 2/2: say "checks the minimum length" where v4 said "checks the
    length"

Changes since v3:
  - no code change at all, only the log of 2/2 changed
  - 1/2: unchanged
  - 2/2: pick up Andy's Reviewed-by
  - 2/2: name 331a2d82bcaf ("[PATCH] USB: ethernet/rndis gadget address
    params") from v2.6.7 as the commit that introduced the loop

Changes since v2:
  - 1/2: pick up Andy's Reviewed-by, no code change
  - 2/2: keep the separator-less notation "aabbccddeeff" working by
    falling back to hex2bin() when parse_mac_pton() does not match
  - 2/2: spell out in the log which notations stop being accepted

Changes since v1:
  - rework the fix on top of parse_mac_pton() as suggested by Andy
    instead of open coding the bounds checks in get_ether_addr()
  - add the KASAN report and the malformed address example
  - select GENERIC_NET_UTILS for USB_U_ETHER

One user visible effect remains: the Cisco notation "aabb.ccdd.eeff" and
irregular groupings such as "123456:789abc" are no longer parsed.  The
legacy module parameters then fall back to a random address and log a
warning, while a configfs store fails with -EINVAL and keeps the previous
value.  Details are in the log of 2/2.

Liu Chao (2):
  lib/net_utils: allow mac_pton() to take a custom delimiter
  usb: gadget: u_ether: fix out-of-bounds read in get_ether_addr

 .../ABI/testing/configfs-usb-gadget-ecm       |  7 ++++++-
 .../ABI/testing/configfs-usb-gadget-eem       |  7 +++++++
 .../ABI/testing/configfs-usb-gadget-ncm       |  6 ++++++
 .../ABI/testing/configfs-usb-gadget-rndis     |  7 +++++++
 .../ABI/testing/configfs-usb-gadget-subset    |  7 +++++++
 drivers/usb/gadget/Kconfig                    |  1 +
 drivers/usb/gadget/function/u_ether.c         | 18 ++++++++----------
 include/linux/hex.h                           |  7 ++++++-
 lib/net_utils.c                               | 19 ++++++++++++++++---
 9 files changed, 64 insertions(+), 15 deletions(-)


base-commit: a5ebb76233b79db01e82e061173cb73c6d2b5c6b
-- 
2.50.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17  9:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17  9:00 [PATCH v5 0/2] usb: gadget: u_ether: fix out-of-bounds read in get_ether_addr Liu Chao
2026-11-17  9:00 ` [PATCH v5 1/2] lib/net_utils: allow mac_pton() to take a custom delimiter Liu Chao
2026-11-17  9:00 ` [PATCH v5 2/2] usb: gadget: u_ether: fix out-of-bounds read in get_ether_addr Liu Chao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®