mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enver Ikromov <owner@ph4ntom-rev.uz>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Enver Ikromov <owner@ph4ntom-rev.uz>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rtw-next v5 05/10] wifi: rtw89: use AP self role for monitor interfaces
Date: Tue, 17 Nov 2026 14:40:59 +0500	[thread overview]
Message-ID: <20261117094059.1744-3-owner@ph4ntom-rev.uz> (raw)
In-Reply-To: <ffc63e08f954499799f67fffc068c0de@realtek.com>

On Tue, Nov 17, 2026 at 00:41:28 +0000, Ping-Ke Shih wrote:
> But I can use your python script to inject packets without any change on
> kernel 7.1.5. Can you describe the "raw frames" more specific?

You are right. I ran a clean A/B test on RTL8852AE (stock 7.1.5 and
rtw-next) comparing the default monitor role (SELF_ROLE_CLIENT with
NET_TYPE_NO_LINK) against SELF_ROLE_AP across Probe Request, NullFunc,
16-byte RTS, Data, and QoS Data on 2.4 GHz and 5 GHz, both right after
interface up and 12 seconds later.

Without this patch, R_AX_MACID_SLEEP_0 (0xC2C0) and
R_AX_SS_MACID_PAUSE_0 (0x9EB0) remain 0, TX status reports zero
macid_drop, and live over-the-air ProbeResp, CTS, and ACK counts from
the AP are identical to SELF_ROLE_AP.

My earlier test was misled by two separate effects:
1. After monitor down/up on the same channel without the channel
   restore fix, PHY0 stayed unconfigured so nothing went out on the
   target channel.
2. On 7.1.5 (before commit a371139d8be9 set B_AX_SNIFFER_MODE), frames
   injected with a spoofed source MAC were transmitted fine, but the
   AP's unicast ProbeResp/CTS/ACK replies to that address were dropped
   on RX (0xCE20 = 0x03174438), making TX appear silent.

So RTW89_SELF_ROLE_AP is unnecessary and I will drop patch 05/10 in v6.

Thanks,
Enver

  reply	other threads:[~2026-11-17  9:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 23:52 [PATCH rtw-next v5 00/10] wifi: rtw89: monitor mode RX filter and raw frame injection fixes Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 01/10] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-15  3:23   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 02/10] wifi: rtw89: handle negative rate index for injected frames Enver Ikromov
2026-11-15  3:38   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 03/10] wifi: rtw89: fix RX filter configuration for monitor mode Enver Ikromov
2026-11-15  3:48   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-17  7:17       ` Ping-Ke Shih
2026-11-17  9:40         ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 04/10] wifi: rtw89: protect pure_monitor_mode_vif with RCU Enver Ikromov
2026-11-15  4:00   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 05/10] wifi: rtw89: use AP self role for monitor interfaces Enver Ikromov
2026-11-15  4:08   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-17  0:41       ` Ping-Ke Shih
2026-11-17  9:40         ` Enver Ikromov [this message]
2026-11-13 23:52 ` [PATCH rtw-next v5 06/10] wifi: rtw89: transmit frames from " Enver Ikromov
2026-11-16  1:35   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 07/10] wifi: rtw89: send injected control frames through the management path Enver Ikromov
2026-11-16  2:14   ` Ping-Ke Shih
2026-11-16 15:27     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 08/10] wifi: rtw89: skip host-side TX hooks for injected frames Enver Ikromov
2026-11-16  2:20   ` Ping-Ke Shih
2026-11-16 15:28     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 09/10] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK " Enver Ikromov
2026-11-16  3:00   ` Ping-Ke Shih
2026-11-16 15:28     ` Enver Ikromov
2026-11-13 23:52 ` [PATCH rtw-next v5 10/10] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-16  3:45   ` Ping-Ke Shih
2026-11-16 15:28     ` Enver Ikromov
2026-11-17  4:14       ` Zong-Zhe Yang
2026-11-17  9:40         ` Enver Ikromov
2026-11-16  7:56   ` Zong-Zhe Yang
2026-11-16 15:28     ` Enver Ikromov
2026-11-15  3:12 ` [PATCH rtw-next v5 00/10] wifi: rtw89: monitor mode RX filter and raw frame injection fixes Ping-Ke Shih
2026-11-16 15:27   ` Enver Ikromov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117094059.1744-3-owner@ph4ntom-rev.uz \
    --to=owner@ph4ntom-rev.uz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®