From: Enver Ikromov <owner@ph4ntom-rev.uz>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Zong-Zhe Yang <kevin_yang@realtek.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Enver Ikromov <owner@ph4ntom-rev.uz>
Subject: [PATCH rtw-next v6 2/5] wifi: rtw89: handle negative rate index for injected frames
Date: Tue, 17 Nov 2026 14:41:32 +0500 [thread overview]
Message-ID: <20261117094135.1772-3-owner@ph4ntom-rev.uz> (raw)
In-Reply-To: <20261117094135.1772-1-owner@ph4ntom-rev.uz>
When user space injects a frame with a radiotap rate that is not
supported on the current band (for example 1 Mbps CCK on 5 GHz),
mac80211 sets the rate index to -1. Storing that index in an unsigned
byte turns it into 0xff and programs an invalid hardware rate into the
TX descriptor.
Clamp negative rate indices to 0 so the lowest valid band rate (1 Mbps
on 2.4 GHz, 6 Mbps on 5/6 GHz) is selected.
Fixes: e96abe4fd7cd ("wifi: rtw89: consider data rate/bandwidth/GI for injected packets")
Cc: stable@vger.kernel.org
Signed-off-by: Enver Ikromov <owner@ph4ntom-rev.uz>
---
drivers/net/wireless/realtek/rtw89/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index 1e8b60e..37ff745 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -1259,7 +1259,7 @@ static void rtw89_core_tx_update_injection(struct rtw89_dev *rtwdev,
enum mac80211_rate_control_flags flags = info->control.rates[0].flags;
struct rtw89_tx_desc_info *desc_info = &tx_req->desc_info;
const struct rtw89_chan *chan;
- u8 idx = info->control.rates[0].idx;
+ u8 idx = max_t(s8, info->control.rates[0].idx, 0);
u8 nss, mcs;
desc_info->use_rate = true;
--
2.56.0.windows.4
next prev parent reply other threads:[~2026-11-17 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 9:41 [PATCH rtw-next v6 0/5] wifi: rtw89: monitor mode and raw frame injection fixes Enver Ikromov
2026-11-17 9:41 ` [PATCH rtw-next v6 1/5] wifi: rtw89: avoid NULL vif dereference in rtw89_ops_tx() Enver Ikromov
2026-11-17 9:41 ` Enver Ikromov [this message]
2026-11-17 9:41 ` [PATCH rtw-next v6 3/5] wifi: rtw89: restore channel when leaving idle on non-chanctx devices Enver Ikromov
2026-11-18 6:30 ` Zong-Zhe Yang
2026-11-17 9:41 ` [PATCH rtw-next v6 4/5] wifi: rtw89: avoid reading seq_ctrl on control frames Enver Ikromov
2026-11-17 9:41 ` [PATCH rtw-next v6 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames Enver Ikromov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117094135.1772-3-owner@ph4ntom-rev.uz \
--to=owner@ph4ntom-rev.uz \
--cc=kevin_yang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®