* [PATCH] ASoC: Intel: Remove unused intel-sst.h trace header
@ 2026-11-17 13:45 Temitope obabi
2026-11-17 14:00 ` Cezary Rojewski
0 siblings, 1 reply; 3+ messages in thread
From: Temitope obabi @ 2026-11-17 13:45 UTC (permalink / raw)
To: broonie
Cc: cezary.rojewski, liam.r.girdwood, peter.ujfalusi,
yung-chuan.liao, kai.vehmanen, rostedt, mhiramat,
mathieu.desnoyers, linux-sound, linux-trace-kernel, linux-kernel,
Temitope obabi
Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed
sound/soc/intel/common/sst-dsp.c, the only file that defined
CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
Nothing includes this header anymore, so none of its tracepoints are
built. Remove the unused header.
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
include/trace/events/intel-sst.h | 148 -------------------------------
1 file changed, 148 deletions(-)
delete mode 100644 include/trace/events/intel-sst.h
diff --git a/include/trace/events/intel-sst.h b/include/trace/events/intel-sst.h
deleted file mode 100644
index ae7c269b0824..000000000000
--- a/include/trace/events/intel-sst.h
+++ /dev/null
@@ -1,148 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#undef TRACE_SYSTEM
-#define TRACE_SYSTEM intel-sst
-
-/*
- * The TRACE_SYSTEM_VAR defaults to TRACE_SYSTEM, but must be a
- * legitimate C variable. It is not exported to user space.
- */
-#undef TRACE_SYSTEM_VAR
-#define TRACE_SYSTEM_VAR intel_sst
-
-#if !defined(_TRACE_INTEL_SST_H) || defined(TRACE_HEADER_MULTI_READ)
-#define _TRACE_INTEL_SST_H
-
-#include <linux/types.h>
-#include <linux/ktime.h>
-#include <linux/tracepoint.h>
-
-DECLARE_EVENT_CLASS(sst_ipc_msg,
-
- TP_PROTO(unsigned int val),
-
- TP_ARGS(val),
-
- TP_STRUCT__entry(
- __field( unsigned int, val )
- ),
-
- TP_fast_assign(
- __entry->val = val;
- ),
-
- TP_printk("0x%8.8x", (unsigned int)__entry->val)
-);
-
-DEFINE_EVENT(sst_ipc_msg, sst_ipc_msg_tx,
-
- TP_PROTO(unsigned int val),
-
- TP_ARGS(val)
-
-);
-
-DEFINE_EVENT(sst_ipc_msg, sst_ipc_msg_rx,
-
- TP_PROTO(unsigned int val),
-
- TP_ARGS(val)
-
-);
-
-DECLARE_EVENT_CLASS(sst_ipc_mailbox,
-
- TP_PROTO(unsigned int offset, unsigned int val),
-
- TP_ARGS(offset, val),
-
- TP_STRUCT__entry(
- __field( unsigned int, offset )
- __field( unsigned int, val )
- ),
-
- TP_fast_assign(
- __entry->offset = offset;
- __entry->val = val;
- ),
-
- TP_printk(" 0x%4.4x = 0x%8.8x",
- (unsigned int)__entry->offset, (unsigned int)__entry->val)
-);
-
-DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_wdata,
-
- TP_PROTO(unsigned int offset, unsigned int val),
-
- TP_ARGS(offset, val)
-
-);
-
-DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_outbox_rdata,
-
- TP_PROTO(unsigned int offset, unsigned int val),
-
- TP_ARGS(offset, val)
-
-);
-
-DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_outbox_wdata,
-
- TP_PROTO(unsigned int offset, unsigned int val),
-
- TP_ARGS(offset, val)
-
-);
-
-DECLARE_EVENT_CLASS(sst_ipc_mailbox_info,
-
- TP_PROTO(unsigned int size),
-
- TP_ARGS(size),
-
- TP_STRUCT__entry(
- __field( unsigned int, size )
- ),
-
- TP_fast_assign(
- __entry->size = size;
- ),
-
- TP_printk("Mailbox bytes 0x%8.8x", (unsigned int)__entry->size)
-);
-
-DEFINE_EVENT(sst_ipc_mailbox_info, sst_ipc_inbox_read,
-
- TP_PROTO(unsigned int size),
-
- TP_ARGS(size)
-
-);
-
-DEFINE_EVENT(sst_ipc_mailbox_info, sst_ipc_inbox_write,
-
- TP_PROTO(unsigned int size),
-
- TP_ARGS(size)
-
-);
-
-DEFINE_EVENT(sst_ipc_mailbox_info, sst_ipc_outbox_read,
-
- TP_PROTO(unsigned int size),
-
- TP_ARGS(size)
-
-);
-
-DEFINE_EVENT(sst_ipc_mailbox_info, sst_ipc_outbox_write,
-
- TP_PROTO(unsigned int size),
-
- TP_ARGS(size)
-
-);
-
-#endif /* _TRACE_SST_H */
-
-/* This part must be outside protection */
-#include <trace/define_trace.h>
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Intel: Remove unused intel-sst.h trace header
2026-11-17 13:45 [PATCH] ASoC: Intel: Remove unused intel-sst.h trace header Temitope obabi
@ 2026-11-17 14:00 ` Cezary Rojewski
2026-11-17 14:02 ` Cezary Rojewski
0 siblings, 1 reply; 3+ messages in thread
From: Cezary Rojewski @ 2026-11-17 14:00 UTC (permalink / raw)
To: Temitope obabi, broonie
Cc: liam.r.girdwood, peter.ujfalusi, yung-chuan.liao, kai.vehmanen,
rostedt, mhiramat, mathieu.desnoyers, linux-sound,
linux-trace-kernel, linux-kernel
On 11/17/2026 2:45 PM, Temitope obabi wrote:
> Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed
> sound/soc/intel/common/sst-dsp.c, the only file that defined
> CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
>
> Nothing includes this header anymore, so none of its tracepoints are
> built. Remove the unused header.
>
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
What's going on here. There is already v2 of yours [1] which has been
commented by me and Steven. Why are we having a separate thread for the
exact same subject?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Intel: Remove unused intel-sst.h trace header
2026-11-17 14:00 ` Cezary Rojewski
@ 2026-11-17 14:02 ` Cezary Rojewski
0 siblings, 0 replies; 3+ messages in thread
From: Cezary Rojewski @ 2026-11-17 14:02 UTC (permalink / raw)
To: Temitope obabi, broonie
Cc: liam.r.girdwood, peter.ujfalusi, yung-chuan.liao, kai.vehmanen,
rostedt, mhiramat, mathieu.desnoyers, linux-sound,
linux-trace-kernel, linux-kernel
On 11/17/2026 3:00 PM, Cezary Rojewski wrote:
> On 11/17/2026 2:45 PM, Temitope obabi wrote:
>> Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed
>> sound/soc/intel/common/sst-dsp.c, the only file that defined
>> CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
>>
>> Nothing includes this header anymore, so none of its tracepoints are
>> built. Remove the unused header.
>>
>> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
> What's going on here. There is already v2 of yours [1] which has been
> commented by me and Steven. Why are we having a separate thread for the
> exact same subject?
Meh, forgotten to add the link.
[1]:
https://lore.kernel.org/all/20261111223102.1310-1-obabitemitope765@gmail.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-17 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 13:45 [PATCH] ASoC: Intel: Remove unused intel-sst.h trace header Temitope obabi
2026-11-17 14:00 ` Cezary Rojewski
2026-11-17 14:02 ` Cezary Rojewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®