* [PATCH] selftests/damon/damos_quota: skip the last sample when counting exceeds
@ 2026-11-17 6:25 Aveline Noir
2026-11-17 14:40 ` SJ Park
0 siblings, 1 reply; 2+ messages in thread
From: Aveline Noir @ 2026-11-17 6:25 UTC (permalink / raw)
To: SJ Park
Cc: Shuah Khan, Shuah Khan, damon, linux-mm, linux-kselftest, linux-kernel
damos_quota.py expects qt_exceeds to be increased for every sample whose
tried_bytes equals the quota. The kernel increases it only when the next
quota window starts, so the last full window may still be pending when
the workload exits. The test then fails with an expected count one
higher than the actual one, e.g., 15 < 16.
Do not count the last sample. Also drop the sorting of the samples, so
that the last one is the latest.
Signed-off-by: Aveline Noir <jm5905938@gmail.com>
---
Tested in x86-64 KVM guests. damos_quota.py failed in every run before
this patch and passed in every run after it.
---
tools/testing/selftests/damon/damos_quota.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/damon/damos_quota.py b/tools/testing/selftests/damon/damos_quota.py
index 879115a499bf..bdfd22f00079 100755
--- a/tools/testing/selftests/damon/damos_quota.py
+++ b/tools/testing/selftests/damon/damos_quota.py
@@ -53,15 +53,16 @@ def main():
wss_collected.append(scheme.tried_bytes)
nr_quota_exceeds = scheme.stats.qt_exceeds
- wss_collected.sort()
nr_expected_quota_exceeds = 0
- for wss in wss_collected:
+ for idx, wss in enumerate(wss_collected):
if wss > sz_quota:
print('quota is not kept: %s > %s' % (wss, sz_quota))
print('collected samples are as below')
print('\n'.join(['%d' % wss for wss in wss_collected]))
exit(1)
- if wss == sz_quota:
+ # qt_exceeds is updated when the next quota window starts, so skip
+ # the last sample, whose window may still be pending.
+ if wss == sz_quota and idx < len(wss_collected) - 1:
nr_expected_quota_exceeds += 1
if nr_quota_exceeds < nr_expected_quota_exceeds:
---
base-commit: 67f3b04b277373438f17300e056306adbd9edf7b
change-id: 20261117-fix-damon-quota-selftest-20261117-7c617b04fc92
Best regards,
--
Aveline Noir <jm5905938@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/damon/damos_quota: skip the last sample when counting exceeds
2026-11-17 6:25 [PATCH] selftests/damon/damos_quota: skip the last sample when counting exceeds Aveline Noir
@ 2026-11-17 14:40 ` SJ Park
0 siblings, 0 replies; 2+ messages in thread
From: SJ Park @ 2026-11-17 14:40 UTC (permalink / raw)
To: Aveline Noir
Cc: SJ Park, Shuah Khan, Shuah Khan, damon, linux-mm,
linux-kselftest, linux-kernel
Hello Aveline,
On Tue, 17 Nov 2026 17:25:36 +1100 Aveline Noir <jm5905938@gmail.com> wrote:
> damos_quota.py expects qt_exceeds to be increased for every sample whose
> tried_bytes equals the quota. The kernel increases it only when the next
> quota window starts, so the last full window may still be pending when
> the workload exits. The test then fails with an expected count one
> higher than the actual one, e.g., 15 < 16.
>
> Do not count the last sample. Also drop the sorting of the samples, so
> that the last one is the latest.
Looks good to me, thank you for this patch.
>
> Signed-off-by: Aveline Noir <jm5905938@gmail.com>
Reviewed-by: SJ Park <sj@kernel.org>
This patch is applied to damon/next [1] tree. I will repost it soon (~1 week)
as an mm.git merge request. So, no action from your side is needed for now.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 6:25 [PATCH] selftests/damon/damos_quota: skip the last sample when counting exceeds Aveline Noir
2026-11-17 14:40 ` SJ Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®