mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnav Kapoor <kapoorarnav43@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes
Date: Wed, 18 Nov 2026 00:40:29 +0530	[thread overview]
Message-ID: <20261117191029.83901-1-kapoorarnav43@gmail.com> (raw)
In-Reply-To: <avyj-lOGvj04A_Ak@ashevche-desk.local>

On Tue, Nov 17, 2026 at 08:59:06PM +0200, Andy Shevchenko wrote:
> > For odd r the read value is (r * r - 1) / 2,
>
> No, it's r²/2 but in integer arithmetics. That's why for odd number squares
> it gives 1/2 that becomes 0.

Same value, but your wording is clearer. I'll say in v2 that r * r / 2
rounds down for odd r.

> Yep, what we see is off-by-one for full squares. This is because division
> by 2 in integer arithmetics makes it floor number. So, what you want
> to have is a correction for all odd numbers.

> And here I would rather use (val % 2) instead of 1. See above why.

I don't think val % 2 works, because the correction depends on whether
the register code r is odd, not whether val is. Odd codes read back as
even values too, as in your table:

	reg	read value	int_sqrt(2 * val + val % 2)	int_sqrt(2 * val + 1)
	3	4		int_sqrt(8)  = 2		int_sqrt(9)  = 3
	5	12		int_sqrt(24) = 4		int_sqrt(25) = 5
	7	24		int_sqrt(48) = 6		int_sqrt(49) = 7

With + 1: an odd r reads back as (r * r - 1) / 2, so 2 * val + 1 is
exactly r * r. An even r reads back as r * r / 2, so 2 * val + 1 is
r * r + 1, and int_sqrt() still gives r. Checking all 256 codes, + 1
round-trips every one of them, while val % 2 still fails on the same
127 codes as the current int_sqrt(2 * val). For values in between,
+ 1 also picks the largest code whose threshold does not exceed the
requested value.

> For the write part (the negative is problematic only on 32-bit case IIUC)

I think it is on 64-bit too: val is an unsigned int, so 2 * val wraps
at 32 bits before int_sqrt() sees it, whatever the size of long.

> > 	reg = SX9324_REG_PROX_CTRL6 + chan->channel / 2;
>
> This one is not used in the conditionals, so the new check may well be done
> before it.

> > +	if (_val < 0)
>
> Checking _val after assigning val to it is confusing.

> > 	if (val >= 1)
>
> First of all, I would drop the '=' here.

Agreed on all three. In v2 the check on _val will come first, before
val and reg are assigned, and the condition will be val > 1. I'll make
the same changes in 5/6, which has the same code for sx9360.

Thanks,
Arnav

  reply	other threads:[~2026-11-17 19:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:53 [PATCH 0/6] iio: proximity: sx93xx: fix raw reads, thresholds, hysteresis and gain Arnav Kapoor
2026-11-16 20:53 ` [PATCH 1/6] iio: proximity: sx_common: fix raw reads while the trigger is in use Arnav Kapoor
2026-11-16 20:53 ` [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes Arnav Kapoor
2026-11-17 18:59   ` Andy Shevchenko
2026-11-17 19:10     ` Arnav Kapoor [this message]
2026-11-16 20:53 ` [PATCH 3/6] iio: proximity: sx9324: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:09   ` Andy Shevchenko
2026-11-17 19:15     ` Arnav Kapoor
2026-11-16 20:53 ` [PATCH 4/6] iio: proximity: sx9360: fix hardware gain encoding Arnav Kapoor
2026-11-16 20:53 ` [PATCH 5/6] iio: proximity: sx9360: fix proximity threshold writes Arnav Kapoor
2026-11-17 19:11   ` Andy Shevchenko
2026-11-16 20:53 ` [PATCH 6/6] iio: proximity: sx9360: reject negative hysteresis values Arnav Kapoor
2026-11-17 19:12   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117191029.83901-1-kapoorarnav43@gmail.com \
    --to=kapoorarnav43@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®