From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Hans Verkuil <hverkuil+cisco@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andy Walls <awalls@md.metrocast.net>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>,
Nicolas Dufresne <nicolas.dufres@collabora.com>,
Hans de Goede <hansg@kernel.org>,
Michael Riesch <michael.riesch@collabora.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Maxime Ripard <mripard@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: [PATCH RFC v2 14/16] media: mc: Add detect polling helpers for drivers
Date: Wed, 18 Nov 2026 13:43:58 +0100 [thread overview]
Message-ID: <20261118-v4l2-sensor-detect-v2-14-1bb1a445b556@kernel.org> (raw)
In-Reply-To: <20261118-v4l2-sensor-detect-v2-0-1bb1a445b556@kernel.org>
If a stream is ongoing and an entity gets disconnected from the media
graph, userspace will hang on DQBUF without any additional information.
When fault tolerance is enabled, the media controller can notify
userspace of such happening by periodically polling all entities that
support the .detect() operation.
If an entity's status change, userspace gets notified via the
MEDIA_EVENT_ENTITY_STATUS_CHANGE event.
Add media_detect_poll_enable/disable so that drivers can opt-in into
polling for .detect().
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
---
drivers/media/mc/mc-device.c | 80 ++++++++++++++++++++++++++++++++++++++++++++
include/media/media-device.h | 4 +++
include/media/media-entity.h | 32 ++++++++++++++++++
3 files changed, 116 insertions(+)
diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
index 6f5b2daa1177..76b099aa23cd 100644
--- a/drivers/media/mc/mc-device.c
+++ b/drivers/media/mc/mc-device.c
@@ -20,6 +20,7 @@
#include <linux/pci.h>
#include <linux/usb.h>
#include <linux/version.h>
+#include <linux/workqueue.h>
#include <media/media-device.h>
#include <media/media-devnode.h>
@@ -700,6 +701,9 @@ static void __media_device_unregister_entity(struct media_entity *entity)
ida_free(&mdev->entity_internal_idx, entity->internal_idx);
+ if (!list_empty(&entity->detect_list))
+ list_del_init(&entity->detect_list);
+
/* Remove all interface links pointing to this entity */
list_for_each_entry(intf, &mdev->interfaces, graph_obj.list) {
list_for_each_entry_safe(link, tmp, &intf->links, list) {
@@ -738,6 +742,7 @@ int __must_check media_device_register_entity(struct media_device *mdev,
WARN_ON(entity->graph_obj.mdev != NULL);
entity->graph_obj.mdev = mdev;
INIT_LIST_HEAD(&entity->links);
+ INIT_LIST_HEAD(&entity->detect_list);
entity->num_links = 0;
entity->num_backlinks = 0;
@@ -820,6 +825,76 @@ static int media_device_requests(struct seq_file *file, void *priv)
}
#endif
+#define MEDIA_DETECT_POLL_INTERVAL_MS 10000
+
+static void media_detect_work_fn(struct work_struct *work)
+{
+ struct media_device *mdev = container_of(to_delayed_work(work),
+ struct media_device,
+ detect_work);
+ struct media_entity *entity;
+ int ret;
+
+ if (!mutex_trylock(&mdev->graph_mutex)) {
+ schedule_delayed_work(&mdev->detect_work,
+ msecs_to_jiffies(MEDIA_DETECT_POLL_INTERVAL_MS));
+ return;
+ }
+
+ list_for_each_entry(entity, &mdev->detect_entities, detect_list) {
+ ret = media_entity_call(entity, detect);
+ if (ret >= 0)
+ __media_entity_set_status(entity, ret);
+ }
+
+ if (!list_empty(&mdev->detect_entities))
+ schedule_delayed_work(&mdev->detect_work,
+ msecs_to_jiffies(MEDIA_DETECT_POLL_INTERVAL_MS));
+
+ mutex_unlock(&mdev->graph_mutex);
+}
+
+void media_detect_poll_enable(struct media_entity *entity)
+{
+ struct media_device *mdev = entity->graph_obj.mdev;
+
+ if (!media_fault_tolerance_enabled())
+ return;
+
+ mutex_lock(&mdev->graph_mutex);
+
+ if (!list_empty(&entity->detect_list))
+ goto out;
+
+ list_add_tail(&entity->detect_list, &mdev->detect_entities);
+ schedule_delayed_work(&mdev->detect_work,
+ msecs_to_jiffies(MEDIA_DETECT_POLL_INTERVAL_MS));
+out:
+ mutex_unlock(&mdev->graph_mutex);
+}
+EXPORT_SYMBOL_GPL(media_detect_poll_enable);
+
+void media_detect_poll_disable(struct media_entity *entity)
+{
+ struct media_device *mdev = entity->graph_obj.mdev;
+
+ if (!media_fault_tolerance_enabled())
+ return;
+
+ mutex_lock(&mdev->graph_mutex);
+
+ if (list_empty(&entity->detect_list))
+ goto out;
+
+ list_del_init(&entity->detect_list);
+
+ if (list_empty(&mdev->detect_entities))
+ cancel_delayed_work(&mdev->detect_work);
+out:
+ mutex_unlock(&mdev->graph_mutex);
+}
+EXPORT_SYMBOL_GPL(media_detect_poll_disable);
+
void media_device_init(struct media_device *mdev)
{
INIT_LIST_HEAD(&mdev->entities);
@@ -828,6 +903,8 @@ void media_device_init(struct media_device *mdev)
INIT_LIST_HEAD(&mdev->links);
INIT_LIST_HEAD(&mdev->entity_notify);
INIT_LIST_HEAD(&mdev->fh_list);
+ INIT_LIST_HEAD(&mdev->detect_entities);
+ INIT_DELAYED_WORK(&mdev->detect_work, media_detect_work_fn);
mutex_init(&mdev->req_queue_mutex);
mutex_init(&mdev->graph_mutex);
@@ -849,6 +926,7 @@ EXPORT_SYMBOL_GPL(media_device_init);
void media_device_cleanup(struct media_device *mdev)
{
+ cancel_delayed_work_sync(&mdev->detect_work);
ida_destroy(&mdev->entity_internal_idx);
mdev->entity_internal_idx_max = 0;
media_graph_walk_cleanup(&mdev->pm_count_walk);
@@ -945,6 +1023,8 @@ void media_device_unregister(struct media_device *mdev)
if (mdev == NULL)
return;
+ cancel_delayed_work_sync(&mdev->detect_work);
+
mutex_lock(&mdev->graph_mutex);
/* Check if mdev was ever registered at all */
diff --git a/include/media/media-device.h b/include/media/media-device.h
index 9a0f38914354..d1db783db4ac 100644
--- a/include/media/media-device.h
+++ b/include/media/media-device.h
@@ -16,6 +16,7 @@
#include <linux/mutex.h>
#include <linux/pci.h>
#include <linux/platform_device.h>
+#include <linux/workqueue.h>
#include <media/media-devnode.h>
#include <media/media-entity.h>
@@ -199,6 +200,9 @@ struct media_device {
struct list_head fh_list;
spinlock_t fh_list_lock;
+
+ struct list_head detect_entities;
+ struct delayed_work detect_work;
};
/* We don't need to include usb.h here */
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index b0e1fc627d17..dea3a742a21a 100644
--- a/include/media/media-entity.h
+++ b/include/media/media-entity.h
@@ -343,6 +343,9 @@ enum media_entity_type {
* re-used if entities are unregistered or registered again.
* @pads: Pads array with the size defined by @num_pads.
* @links: List of data links.
+ * @detect_list: Entry in &media_device.detect_entities for poll-based
+ * detection. Managed by media_detect_poll_enable() /
+ * media_detect_poll_disable().
* @ops: Entity operations.
* @use_count: Use count for the entity.
* @info: Union with devnode information. Kept just for backward
@@ -372,6 +375,7 @@ struct media_entity {
struct media_pad *pads;
struct list_head links;
+ struct list_head detect_list;
const struct media_entity_operations *ops;
@@ -1067,6 +1071,34 @@ void media_entity_set_status(struct media_entity *entity, u32 status);
*/
int media_entity_detect_or_fail(struct media_entity *entity);
+/**
+ * media_detect_poll_enable - Enable periodic .detect() polling for an entity
+ * @entity: The entity to poll
+ *
+ * Add @entity to the media device's detect poll list and schedule the
+ * detect worker if not already running. The worker periodically calls
+ * the entity's &media_entity_operations.detect() operation and updates
+ * the entity status on change.
+ *
+ * Intended to be called from the driver's enable_streams() callback,
+ * so that detection polling only runs while the entity is powered and
+ * streaming.
+ *
+ * The entity must implement the .detect() operation.
+ */
+void media_detect_poll_enable(struct media_entity *entity);
+
+/**
+ * media_detect_poll_disable - Disable periodic .detect() polling for an entity
+ * @entity: The entity to stop polling
+ *
+ * Remove @entity from the media device's detect poll list. If no more
+ * entities are being polled, the detect worker is cancelled.
+ *
+ * Intended to be called from the driver's disable_streams() callback.
+ */
+void media_detect_poll_disable(struct media_entity *entity);
+
/**
* media_entity_pipeline - Get the media pipeline an entity is part of
* @entity: The entity
--
2.56.0
next prev parent reply other threads:[~2026-11-18 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 12:43 [PATCH RFC v2 00/16] media: Fault-Tolerant V4L2 Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 01/16] media: mc: Add struct media_device_fh pointer to media device IOCTL op Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 02/16] media: mc: Add per-file-handle data support Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 03/16] v4l: event: Separate event related information from struct v4l2_fh Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 04/16] v4l: event: Rework data structures for separating events and V4L2 Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 05/16] v4l: event: Split the event framework into generic and V4L2 bits Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 06/16] media: mc: Maintain a list of open file handles in a media device Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 07/16] media: mc: Add MEDIA_IOC_DQEVENT Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 08/16] media: mc: Add MEDIA_EVENT_ENTITY_REGISTRATION Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 09/16] Documentation: media: Add Media controller event documentation Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 10/16] media: media.h: Add entity connection status Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 11/16] media: mc: Add .detect() to media_entity_operations Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 12/16] media: mc: Add MEDIA_IOC_G_ENTITY_STATUS ioctl Mattijs Korpershoek
2026-11-18 12:43 ` [PATCH RFC v2 13/16] media: mc: Add MEDIA_EVENT_ENTITY_STATUS_CHANGE event Mattijs Korpershoek
2026-11-18 12:43 ` Mattijs Korpershoek [this message]
2026-11-18 12:43 ` [PATCH RFC v2 15/16] media: imx219: Allow driver probe with missing sensor Mattijs Korpershoek
2026-11-18 12:44 ` [PATCH RFC v2 16/16] media: imx219: Implement .detect() sensor operation Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-v4l2-sensor-detect-v2-14-1bb1a445b556@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=awalls@md.metrocast.net \
--cc=dave.stevenson@raspberrypi.com \
--cc=gustavoars@kernel.org \
--cc=hansg@kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=kees@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=mripard@kernel.org \
--cc=nicolas.dufres@collabora.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®