mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fred Gao <fred.gao@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, jani.nikula@linux.intel.com,
	rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
	tursulin@ursulin.net, ville.syrjala@linux.intel.com,
	Fred Gao <fred.gao@intel.com>,
	Chenchen Wang <chenchen.wang@intel.com>
Subject: [PATCH v2] drm/i915/panel: Restrict highest mode to DRRS-compatible modes
Date: Wed, 18 Nov 2026 09:49:49 +0800	[thread overview]
Message-ID: <20261118014949.399026-1-fred.gao@intel.com> (raw)

intel_dp_mode_clock() uses intel_panel_highest_mode() when seamless M/N
updates are supported so the link configuration can accommodate every
seamless DRRS refresh rate.

The panel fixed mode list can also contain modes with the same active
size but different blanking timings. Such modes require a full modeset
and cannot participate in a seamless M/N switch. Letting them affect the
highest clock can unnecessarily reduce the selected bpp.

On a 5120x2160 panel, the preferred DisplayID mode uses 717260 kHz, while a
CTA mode with different blanking uses 742500 kHz. HBR2 x4 can carry the
preferred mode at 24 bpp, but not the CTA clock. The latter therefore makes
the link configuration fall back to 18 bpp. The firmware state is 24 bpp,
so the mismatch forces a full modeset and an eDP backlight and panel power
cycle during driver takeover.

Use is_alt_drrs_mode() to consider only fixed modes whose timings and flags
match the adjusted mode. This preserves bandwidth reservation for genuine
seamless DRRS alternatives while excluding modes that would require a full
modeset.

Fixes: 74d6f31fa427 ("drm/i915: Add intel_panel_highest_mode()")
Signed-off-by: Fred Gao <fred.gao@intel.com>
Reviewed-by: Chenchen Wang <chenchen.wang@intel.com>
---
v2:
 - Resubmit as requested by the CI team to trigger a fresh CI run.
   No code changes. The previous IGT failures were caused by unrelated
   patches.

 drivers/gpu/drm/i915/display/intel_panel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 81e638d0c7b3..e82082adb4c0 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -192,7 +192,8 @@ intel_panel_highest_mode(struct intel_connector *connector,
 
 	/* pick the fixed_mode that has the highest clock */
 	list_for_each_entry(fixed_mode, &connector->panel.fixed_modes, head) {
-		if (fixed_mode->clock > best_mode->clock)
+		if (is_alt_drrs_mode(fixed_mode, adjusted_mode) &&
+		    fixed_mode->clock > best_mode->clock)
 			best_mode = fixed_mode;
 	}
 
-- 
2.43.0


                 reply	other threads:[~2026-11-18  1:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118014949.399026-1-fred.gao@intel.com \
    --to=fred.gao@intel.com \
    --cc=chenchen.wang@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tursulin@ursulin.net \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®