mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: rockchip: Fix HDMI RX 5V detection pin on CM3588 NAS
@ 2026-11-18  2:47 Tim Surber
  0 siblings, 0 replies; only message in thread
From: Tim Surber @ 2026-11-18  2:47 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Tim Surber, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Valentin Hăloiu, Cristian Ciocaltea, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, stable

The HDMI receiver node uses GPIO3_D4 both as the receiver's HPD output
(hdmim1_rx_hpdin) and as its 5V detection input (hpd-gpios and the
hdmirx_hpd pin group). The GPIO setting wins, so the receiver can never
drive HPD. Sources then see HPD asserted all the time, may read the EDID
while the driver is writing it, and never notice EDID updates.

FriendlyElec's vendor device tree for the CM3588 uses GPIO1_D5, active
low, for the 5V detection [1]. Use that pin and leave GPIO3_D4 to the
HPD function. Tested on a CM3588 NAS with HDMI0 looped back into HDMI RX.

Link: https://github.com/friendlyarm/kernel-rockchip/blob/30d3e1c2470a7282f37b96fdd4354314dda69aa3/arch/arm64/boot/dts/rockchip/rk3588-nanopi6-rev09.dts#L299-L309 [1]
Fixes: f9f45293f0d8 ("arm64: dts: rockchip: Enable HDMI receiver on CM3588")
Cc: stable@vger.kernel.org
Signed-off-by: Tim Surber <me@timsurber.de>
---
Changes in v2:
- Shorten the commit message, keep only the problem and the fix
- Drop the cover letter
- Capitalize "Fix" in the subject
- Add Cc: stable
- Link to v1: https://lore.kernel.org/linux-rockchip/20261111210059.3489502-1-me@timsurber.de/

 .../boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts b/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
index f4c34da61c4d..b2df36113d22 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts
@@ -376,7 +376,7 @@ &hdmi_receiver_cma {
 };
 
 &hdmi_receiver {
-	hpd-gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_HIGH>;
+	hpd-gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
 	pinctrl-0 = <&hdmim1_rx_cec &hdmim1_rx_hpdin &hdmim1_rx_scl &hdmim1_rx_sda &hdmirx_hpd>;
 	pinctrl-names = "default";
 	status = "okay";
@@ -571,7 +571,7 @@ hdmi1_tx_on_h: hdmi1-tx-on-h {
 
 	hdmirx {
 		hdmirx_hpd: hdmirx-5v-detection {
-			rockchip,pins = <3 RK_PD4 RK_FUNC_GPIO &pcfg_pull_up>;
+			rockchip,pins = <1 RK_PD5 RK_FUNC_GPIO &pcfg_pull_up>;
 		};
 	};
 

base-commit: a9d78db32fe78bdbe7c66ba77cb7dbb729b885de
-- 
2.55.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-18  2:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18  2:47 [PATCH v2] arm64: dts: rockchip: Fix HDMI RX 5V detection pin on CM3588 NAS Tim Surber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®