mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v5 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels
@ 2026-11-18  5:14 Shrikanth Hegde
  2026-11-18  5:14 ` [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state Shrikanth Hegde
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Shrikanth Hegde @ 2026-11-18  5:14 UTC (permalink / raw)
  To: maddy, linuxppc-dev, chzigotzky
  Cc: sshegde, mpe, npiggin, christophe.leroy, linux-kernel, msuchanek,
	ritesh.list, harshpb, gautam, amachhiw, venkat88, nnmlinux,
	mkchauras

Christian Zigotzky had reported that preemptible kernels don't boot on
his FSL Cyrus+ board. The board freezes on running either full/lazy
preemption and has been an issue for a while now (years!).

https://lore.kernel.org/all/b897b0fd-90f2-4215-bcd4-3714e497d773@xenosoft.de/#t
More details in cover-letter of v2[1]

v4->v5:
- Removed fixes tag for patch 1 as backports could be
  complicated and added stable instead.
- Collected tags.

v3->v4:
- Modify hard_irq_disable for PPC32 to simply call
  local_irq_disable which does tracing/lockdep in addition
  to actually disabling the EE bit. (Ritesh Harjani)
- Modify the guest entry code to use the above (Ritesh Harjani)
- Collected tags. Thanks to Ritesh Harjani, Narayana Murty N.

v2->v3:
- Comment removal (Mukesh Kumar Chaurasiya)
- Add missing booke change (Sashiko)
- Collect tags (Thanks to Mukesh Kumar Chaurasiya, Christian Zigotzky)

v1->v2:
- Re-order to avoid preempt count dance (Narayana Murty N)
- Do only hard_irq_disable on PPC64 to avoid second warning. On PPC32
  use local_irq_disable to acheive the same. (Ritesh Harjani)

v2: https://lore.kernel.org/all/20261110053238.3794500-1-sshegde@linux.ibm.com/#t [1]
v4: https://lore.kernel.org/all/20261117131612.707038-1-sshegde@linux.ibm.com/

Apologies in case any nitpicks are missed.
I'm surviving on half a night's sleep these days.

As said in v2, remaining usecases of hard_irq_disable will be taken up
later, which are in:
arch/powerpc/kexec/core_64.c
arch/powerpc/kvm/book3s_hv.c
arch/powerpc/platforms/85xx/smp.c

Shrikanth Hegde (3):
  PPC32: Fix hard_irq_disable to follow tracing and lockdep state
  KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts
  KVM: PPC: Hard disable interrupts before guest entry

 arch/powerpc/include/asm/hw_irq.h | 2 +-
 arch/powerpc/kvm/booke.c          | 4 +---
 arch/powerpc/kvm/powerpc.c        | 8 --------
 3 files changed, 2 insertions(+), 12 deletions(-)

-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state
  2026-11-18  5:14 [PATCH v5 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels Shrikanth Hegde
@ 2026-11-18  5:14 ` Shrikanth Hegde
  2026-11-18  6:50   ` Mukesh Kumar Chaurasiya
  2026-11-18  5:14 ` [PATCH v5 2/3] KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts Shrikanth Hegde
  2026-11-18  5:14 ` [PATCH v5 3/3] KVM: PPC: Hard disable interrupts before guest entry Shrikanth Hegde
  2 siblings, 1 reply; 5+ messages in thread
From: Shrikanth Hegde @ 2026-11-18  5:14 UTC (permalink / raw)
  To: maddy, linuxppc-dev, chzigotzky
  Cc: sshegde, mpe, npiggin, christophe.leroy, linux-kernel, msuchanek,
	ritesh.list, harshpb, gautam, amachhiw, venkat88, nnmlinux,
	mkchauras, stable

On PPC32, the code for hard_irq_disable has diverged and it doesn't
do lockdep/tracing anymore, leading to use of both local_irq_disable
and hard_irq_disable on PPC32 to overcome those.

That is un-necessary, instead simply calling local_irq_disable is
enough. It disables EE bit and does lockdep tracking.

Subsequent patch uses this API in KVM code to avoid the warnings.
Wider use of it is possible, but it will be taken subsequently.

Cc: <stable@vger.kernel.org> # v7.2+
Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
---
PS: New warnings would have started since commit 
12013e3d4695 ("KVM: powerpc: Use generic xfer to guest work function")
which added local_irq_disable for 32 bit. The proper fix may date back
years ago. To avoid backport complications, keeping it backported till
7.2. So removed fixes tag and cc'ed stable.

Also, 32 bit shouldn't need hard_irq_disable. But that can only be taken
up subsequently.

Also, below fix isn't needed anymore.
https://lore.kernel.org/linuxppc-dev/a14571be1897955f43d9994f0e093de3ada6ecde.1793447880.git.ritesh.list@gmail.com/

 arch/powerpc/include/asm/hw_irq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index b7eee6385ae5..ddb850e62abd 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -464,7 +464,7 @@ static inline bool arch_irqs_disabled(void)
 	return arch_irqs_disabled_flags(arch_local_save_flags());
 }
 
-#define hard_irq_disable()		arch_local_irq_disable()
+#define hard_irq_disable()		local_irq_disable()
 
 static inline bool regs_irqs_disabled(struct pt_regs *regs)
 {
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v5 2/3] KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts
  2026-11-18  5:14 [PATCH v5 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels Shrikanth Hegde
  2026-11-18  5:14 ` [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state Shrikanth Hegde
@ 2026-11-18  5:14 ` Shrikanth Hegde
  2026-11-18  5:14 ` [PATCH v5 3/3] KVM: PPC: Hard disable interrupts before guest entry Shrikanth Hegde
  2 siblings, 0 replies; 5+ messages in thread
From: Shrikanth Hegde @ 2026-11-18  5:14 UTC (permalink / raw)
  To: maddy, linuxppc-dev, chzigotzky
  Cc: sshegde, mpe, npiggin, christophe.leroy, linux-kernel, msuchanek,
	ritesh.list, harshpb, gautam, amachhiw, venkat88, nnmlinux,
	mkchauras

Christian reported that booting preemptible kernel on FSL Cyrus+ board
causes boot hang.

The logs pointed that system was busy in printing below warning.

WARNING: at .enable_kernel_fp+0x30/0x78, CPU#3: qemu-system-ppc/4884
Modules linked in:
CPU: 3 UID: 1000 PID: 4884 Comm: qemu-system-ppc Not tainted 7.3.0-rc1-powerpc64-smp-preempt #1 PREEMPT
NIP [c000000000003338] .enable_kernel_fp+0x30/0x78
LR [c00000000005de84] .kvmppc_load_guest_fp+0x30/0x80
Call Trace:
[c000000085ca7700] [c00000000005de84] .kvmppc_load_guest_fp+0x30/0x80
[c000000085ca7780] [c00000000005f2a0] .kvmppc_handle_exit+0x5bc/0x5cc
[c000000085ca7830] [c00000000006204c] .kvmppc_resume_host+0xb8/0x10c

Which is...

void enable_kernel_fp(void)
{
        unsigned long cpumsr;
        WARN_ON(preemptible());

And...

Though irq's are hard disabled after kvmppc_prepare_to_enter, but
kvmppc_fix_ee_before_entry enables the softmask's IRQ state.
That causes the irqs_disabled to return false.
Hence leading to the warnings.

Fix it by re-ordering the code to load the FP and Altivec
before enabling the softmask IRQ state.

Suggested-by: Narayana Murty N <nnmlinux@linux.ibm.com>
Fixes: 3efc7da61f6c ("KVM: PPC: Book3E: Increase FPU laziness")
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Closes: https://lore.kernel.org/all/33342fbf-eb7b-bde6-2c8c-254fe8bfb993@xenosoft.de/
Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Reviewed-by: Narayana Murty N <nnmlinux@linux.ibm.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
---
 arch/powerpc/kvm/booke.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 13ad4cf5fa71..aed7b476b7eb 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -1404,10 +1404,9 @@ int kvmppc_handle_exit(struct kvm_vcpu *vcpu, unsigned int exit_nr)
 		if (s <= 0)
 			r = (s << 2) | RESUME_HOST | (r & RESUME_FLAG_NV);
 		else {
-			/* interrupts now hard-disabled */
-			kvmppc_fix_ee_before_entry();
 			kvmppc_load_guest_fp(vcpu);
 			kvmppc_load_guest_altivec(vcpu);
+			kvmppc_fix_ee_before_entry();
 		}
 	}
 
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v5 3/3] KVM: PPC: Hard disable interrupts before guest entry
  2026-11-18  5:14 [PATCH v5 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels Shrikanth Hegde
  2026-11-18  5:14 ` [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state Shrikanth Hegde
  2026-11-18  5:14 ` [PATCH v5 2/3] KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts Shrikanth Hegde
@ 2026-11-18  5:14 ` Shrikanth Hegde
  2 siblings, 0 replies; 5+ messages in thread
From: Shrikanth Hegde @ 2026-11-18  5:14 UTC (permalink / raw)
  To: maddy, linuxppc-dev, chzigotzky
  Cc: sshegde, mpe, npiggin, christophe.leroy, linux-kernel, msuchanek,
	ritesh.list, harshpb, gautam, amachhiw, venkat88, nnmlinux,
	mkchauras

After applying preempt disable patch, i.e PATCH 2/3, Christian reported
a subsequent warning stopping his board to boot properly.

WARNING: at .kvmppc_fix_ee_before_entry+0x10/0x28, CPU#0: qemu-system-ppc/4667
CPU: 0 UID: 1000 PID: 4667 Comm: qemu-system-ppc Tainted: G        W           7.3.0-rc4-2-powerpc64-smp #1 PREEMPT
Tainted: [W]=WARN
Hardware name: varisys,CYRUS5040 e5500 0x80240012 CoreNet Generic
NIP [c00000000005dc3c] .kvmppc_fix_ee_before_entry+0x10/0x28
LR [c00000000005f298] .kvmppc_handle_exit+0x5b4/0x5e8
Call Trace:
[c000000086587780] [c00000000005ee10] .kvmppc_handle_exit+0x12c/0x5e8 (unreliable)
[c000000086587830] [c000000000062068] .kvmppc_resume_host+0xb8/0x10c

It triggers below warning...

static inline void kvmppc_fix_ee_before_entry(void)
{
        trace_hardirqs_on();

        /*
         * To avoid races, the caller must have gone directly from having
         * interrupts fully-enabled to hard-disabled.
         */
        WARN_ON(local_paca->irq_happened != PACA_IRQ_HARD_DIS);

This happens since kvmppc_prepare_to_enter does first local_irq_disable
followed by hard_irq_disable. This leaves a small window where interrupt
may occur and it could set the irq pending bit in PACA.

That local_irq_disable was necessary for PPC32 to track the lockdep
state etc. On PPC64 hard_irq_disable is good enough. There is no need to
do both. With now hard_irq_disable, doing local_irq_disable for PPC32,
just calling that is enough.

Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Fixes: 12013e3d4695 ("KVM: powerpc: Use generic xfer to guest work function")
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Closes: https://lore.kernel.org/all/b8f82519-9ae5-c247-e020-e79c627e57df@xenosoft.de/
Tested-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>
Reviewed-by: Narayana Murty N <nnmlinux@linux.ibm.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
---
 arch/powerpc/kvm/booke.c   | 1 -
 arch/powerpc/kvm/powerpc.c | 8 --------
 2 files changed, 9 deletions(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index aed7b476b7eb..2593f7ae6c09 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -722,7 +722,6 @@ int kvmppc_core_prepare_to_enter(struct kvm_vcpu *vcpu)
 	if (vcpu->arch.shared->msr & MSR_WE) {
 		local_irq_enable();
 		kvm_vcpu_halt(vcpu);
-		local_irq_disable();
 		hard_irq_disable();
 
 		kvmppc_set_exit_type(vcpu, EMULATED_MTMSRWE_EXITS);
diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c
index 9194cf492d1c..f4db7dea57b3 100644
--- a/arch/powerpc/kvm/powerpc.c
+++ b/arch/powerpc/kvm/powerpc.c
@@ -81,12 +81,6 @@ int kvmppc_prepare_to_enter(struct kvm_vcpu *vcpu)
 	int r;
 
 	WARN_ON(irqs_disabled());
-	/*
-	 * local_irq_disable() first: on 32-bit, hard_irq_disable() alone is a
-	 * raw MSR[EE] clear that bypasses the lockdep/irq-tracing state, and
-	 * the xfer_to_guest_mode helpers assert IRQs are seen as disabled.
-	 */
-	local_irq_disable();
 	hard_irq_disable();
 
 	while (true) {
@@ -101,7 +95,6 @@ int kvmppc_prepare_to_enter(struct kvm_vcpu *vcpu)
 			 */
 			local_irq_enable();
 			r = kvm_xfer_to_guest_mode_handle_work(vcpu);
-			local_irq_disable();
 			hard_irq_disable();
 			if (r) {
 				/*
@@ -134,7 +127,6 @@ int kvmppc_prepare_to_enter(struct kvm_vcpu *vcpu)
 			local_irq_enable();
 			trace_kvm_check_requests(vcpu);
 			r = kvmppc_core_check_requests(vcpu);
-			local_irq_disable();
 			hard_irq_disable();
 			if (r > 0)
 				continue;
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state
  2026-11-18  5:14 ` [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state Shrikanth Hegde
@ 2026-11-18  6:50   ` Mukesh Kumar Chaurasiya
  0 siblings, 0 replies; 5+ messages in thread
From: Mukesh Kumar Chaurasiya @ 2026-11-18  6:50 UTC (permalink / raw)
  To: Shrikanth Hegde
  Cc: maddy, linuxppc-dev, chzigotzky, mpe, npiggin, christophe.leroy,
	linux-kernel, msuchanek, ritesh.list, harshpb, gautam, amachhiw,
	venkat88, nnmlinux, stable

On Wed, Nov 18, 2026 at 10:44:17AM +0530, Shrikanth Hegde wrote:
> On PPC32, the code for hard_irq_disable has diverged and it doesn't
> do lockdep/tracing anymore, leading to use of both local_irq_disable
> and hard_irq_disable on PPC32 to overcome those.
> 
> That is un-necessary, instead simply calling local_irq_disable is
> enough. It disables EE bit and does lockdep tracking.
> 
> Subsequent patch uses this API in KVM code to avoid the warnings.
> Wider use of it is possible, but it will be taken subsequently.
> 
> Cc: <stable@vger.kernel.org> # v7.2+
> Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> ---
> PS: New warnings would have started since commit 
> 12013e3d4695 ("KVM: powerpc: Use generic xfer to guest work function")
> which added local_irq_disable for 32 bit. The proper fix may date back
> years ago. To avoid backport complications, keeping it backported till
> 7.2. So removed fixes tag and cc'ed stable.
> 
> Also, 32 bit shouldn't need hard_irq_disable. But that can only be taken
> up subsequently.
> 
> Also, below fix isn't needed anymore.
> https://lore.kernel.org/linuxppc-dev/a14571be1897955f43d9994f0e093de3ada6ecde.1793447880.git.ritesh.list@gmail.com/
> 
>  arch/powerpc/include/asm/hw_irq.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
> index b7eee6385ae5..ddb850e62abd 100644
> --- a/arch/powerpc/include/asm/hw_irq.h
> +++ b/arch/powerpc/include/asm/hw_irq.h
> @@ -464,7 +464,7 @@ static inline bool arch_irqs_disabled(void)
>  	return arch_irqs_disabled_flags(arch_local_save_flags());
>  }
>  
> -#define hard_irq_disable()		arch_local_irq_disable()
> +#define hard_irq_disable()		local_irq_disable()
>  
>  static inline bool regs_irqs_disabled(struct pt_regs *regs)
>  {
> -- 
> 2.54.0
> 
Cool, this makes things simple.


Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <mkchauras@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-18  6:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18  5:14 [PATCH v5 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels Shrikanth Hegde
2026-11-18  5:14 ` [PATCH v5 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state Shrikanth Hegde
2026-11-18  6:50   ` Mukesh Kumar Chaurasiya
2026-11-18  5:14 ` [PATCH v5 2/3] KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts Shrikanth Hegde
2026-11-18  5:14 ` [PATCH v5 3/3] KVM: PPC: Hard disable interrupts before guest entry Shrikanth Hegde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®