* [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control
@ 2026-11-17 17:48 Sailesh Nandanavanam
2026-11-18 1:46 ` SJ Park
0 siblings, 1 reply; 3+ messages in thread
From: Sailesh Nandanavanam @ 2026-11-17 17:48 UTC (permalink / raw)
To: sj; +Cc: damon, linux-mm, linux-kernel, Sailesh Nandanavanam
When call_controls_obsolete is unset and damon_call_control->repeat is
set, damon_call() should queue the request and return 0 immediately
without waiting for kdamond to handle it. Add a kunit test for that.
Signed-off-by: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
---
mm/damon/tests/core-kunit.h | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 13315291f69f..bc93677487b5 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -2499,6 +2499,30 @@ static void damon_test_call_controls_obsolete(struct kunit *test)
damon_destroy_ctx(ctx);
}
+static void damon_test_call_repeat(struct kunit *test)
+{
+ struct damon_ctx *ctx;
+ struct damon_call_control control = {};
+ int ret;
+
+ ctx = damon_new_ctx();
+
+ if (!ctx)
+ kunit_skip(test, "ctx alloc fail");
+
+ ctx->call_controls_obsolete = false;
+ control.repeat = true;
+
+ ret = damon_call(ctx, &control);
+
+ KUNIT_EXPECT_EQ(test, ret, 0);
+ KUNIT_EXPECT_FALSE(test, list_empty(&ctx->call_controls));
+ KUNIT_EXPECT_PTR_EQ(test, ctx->call_controls.next, &control.list);
+
+ list_del(&control.list);
+ damon_destroy_ctx(ctx);
+}
+
static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_target),
KUNIT_CASE(damon_test_regions),
@@ -2544,6 +2568,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damos_test_esz_goal_temporal),
KUNIT_CASE(damon_test_last_region_quota_reset),
KUNIT_CASE(damon_test_call_controls_obsolete),
+ KUNIT_CASE(damon_test_call_repeat),
{},
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control
2026-11-17 17:48 [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control Sailesh Nandanavanam
@ 2026-11-18 1:46 ` SJ Park
2026-11-18 6:02 ` Sailesh-003
0 siblings, 1 reply; 3+ messages in thread
From: SJ Park @ 2026-11-18 1:46 UTC (permalink / raw)
To: Sailesh Nandanavanam; +Cc: SJ Park, damon, linux-mm, linux-kernel
On Tue, 17 Nov 2026 23:18:34 +0530 Sailesh Nandanavanam <saileshnandanavanam@gmail.com> wrote:
> When call_controls_obsolete is unset and damon_call_control->repeat is
> set, damon_call() should queue the request and return 0 immediately
> without waiting for kdamond to handle it. Add a kunit test for that.
Apparently this patch was meant to be sent as a part of a series with another
patch [1] but individually sent by a setup failure. As a result, this patch is
not reviewed by Sashiko. Could you please repost as the series?
>
> Signed-off-by: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
> ---
> mm/damon/tests/core-kunit.h | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index 13315291f69f..bc93677487b5 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
> @@ -2499,6 +2499,30 @@ static void damon_test_call_controls_obsolete(struct kunit *test)
> damon_destroy_ctx(ctx);
> }
>
> +static void damon_test_call_repeat(struct kunit *test)
> +{
> + struct damon_ctx *ctx;
> + struct damon_call_control control = {};
> + int ret;
> +
> + ctx = damon_new_ctx();
> +
> + if (!ctx)
> + kunit_skip(test, "ctx alloc fail");
> +
> + ctx->call_controls_obsolete = false;
> + control.repeat = true;
> +
> + ret = damon_call(ctx, &control);
> +
> + KUNIT_EXPECT_EQ(test, ret, 0);
> + KUNIT_EXPECT_FALSE(test, list_empty(&ctx->call_controls));
> + KUNIT_EXPECT_PTR_EQ(test, ctx->call_controls.next, &control.list);
I think the above last two expects are somewhat too much implementation detail.
I don't think we are promising those list status. I'd prefer dropping those.
> +
> + list_del(&control.list);
Can anything leak or corrupted if we don't call list_del() here?
> + damon_destroy_ctx(ctx);
> +}
> +
> static struct kunit_case damon_test_cases[] = {
> KUNIT_CASE(damon_test_target),
> KUNIT_CASE(damon_test_regions),
> @@ -2544,6 +2568,7 @@ static struct kunit_case damon_test_cases[] = {
> KUNIT_CASE(damos_test_esz_goal_temporal),
> KUNIT_CASE(damon_test_last_region_quota_reset),
> KUNIT_CASE(damon_test_call_controls_obsolete),
> + KUNIT_CASE(damon_test_call_repeat),
Could we merge the above two tests into one, say, damon_test_call()?
[1] https://lore.kernel.org/20261117172219.26725-1-saileshnandanavanam@gmail.com
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control
2026-11-18 1:46 ` SJ Park
@ 2026-11-18 6:02 ` Sailesh-003
0 siblings, 0 replies; 3+ messages in thread
From: Sailesh-003 @ 2026-11-18 6:02 UTC (permalink / raw)
To: sj; +Cc: damon, linux-mm, linux-kernel, Sailesh Nandanavanam
From: Sailesh Nandanavanam <saileshnandanavanam@gmail.com>
On Wed, 18 Nov 2026 SJ Park <sj@kernel.org> wrote:
> I think the above last two expects are somewhat too much implementation detail.
> I don't think we are promising those list status. I'd prefer dropping those.
Agreed, dropping both list assertions.
> Can anything leak or corrupted if we don't call list_del() here?
No. The control is stack-allocated and damon_destroy_ctx() does not
touch call_controls, so nothing is leaked or accessed afterwards. Will
drop the list_del().
> Could we merge the above two tests into one, say, damon_test_call()?
Will merge them into damon_test_call() and send v2 as a single patch.
> Apparently this patch was meant to be sent as a part of a series with another
> patch [1] but individually sent by a setup failure. As a result, this patch is
> not reviewed by Sashiko. Could you please repost as the series?
Sorry for the mess. Since the two tests will be merged, v2 will be a
single patch, so Sashiko will review it.
Thanks,
Sailesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-18 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 17:48 [PATCH 2/2] mm/damon/tests/core-kunit: add test for damon_call() with repeat control Sailesh Nandanavanam
2026-11-18 1:46 ` SJ Park
2026-11-18 6:02 ` Sailesh-003
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®