* [PATCH] selftests/pidfd: print time_t as long long
@ 2026-11-03 15:54 Sasha Levin
2026-11-18 12:12 ` Christian Brauner
2026-11-18 13:22 ` David Laight
0 siblings, 2 replies; 3+ messages in thread
From: Sasha Levin @ 2026-11-03 15:54 UTC (permalink / raw)
To: Christian Brauner; +Cc: Shuah Khan, linux-kernel, linux-kselftest
On 32-bit architectures with a 64-bit time_t, such as armhf in Debian
13, printing the time_t values with %lu warns:
pidfd_test.c:523:50: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'time_t' {aka 'long long int'} [-Wformat=]
Cast them to long long and print them with %lld.
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
Found with a 32-bit build of the selftests with a 64-bit time_t (gcc 16
and clang 21 with -m32 -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64);
KernelCI's 32-bit arm builds show the same warnings. The changed files
build without format warnings there now, and the x86_64 builds don't
change. The other selftests get the same kind of fix in separate
patches.
tools/testing/selftests/pidfd/pidfd_test.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
index 932cbd8caa770..a53e72cb256ce 100644
--- a/tools/testing/selftests/pidfd/pidfd_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_test.c
@@ -520,7 +520,7 @@ static void test_pidfd_poll_exec(int use_waitpid)
time_t prog_time = time(NULL) - prog_start;
- ksft_print_msg("Time waited for child: %lu\n", prog_time);
+ ksft_print_msg("Time waited for child: %lld\n", (long long)prog_time);
close(pidfd);
@@ -599,7 +599,8 @@ static void test_pidfd_poll_leader_exit(int use_waitpid)
time_t since_child_exit = time(NULL) - *child_exit_secs;
- ksft_print_msg("Time since child exit: %lu\n", since_child_exit);
+ ksft_print_msg("Time since child exit: %lld\n",
+ (long long)since_child_exit);
close(pidfd);
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/pidfd: print time_t as long long
2026-11-03 15:54 [PATCH] selftests/pidfd: print time_t as long long Sasha Levin
@ 2026-11-18 12:12 ` Christian Brauner
2026-11-18 13:22 ` David Laight
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2026-11-18 12:12 UTC (permalink / raw)
To: Sasha Levin; +Cc: Shuah Khan, linux-kernel, linux-kselftest
On Tue, 03 Nov 2026 10:54:47 -0500, Sasha Levin wrote:
> On 32-bit architectures with a 64-bit time_t, such as armhf in Debian
> 13, printing the time_t values with %lu warns:
>
> pidfd_test.c:523:50: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'time_t' {aka 'long long int'} [-Wformat=]
>
> Cast them to long long and print them with %lld.
>
> [...]
Applied to the vfs-7.5.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.5.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.5.misc
[1/1] selftests/pidfd: print time_t as long long
https://git.kernel.org/vfs/vfs/c/448c990ad379
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/pidfd: print time_t as long long
2026-11-03 15:54 [PATCH] selftests/pidfd: print time_t as long long Sasha Levin
2026-11-18 12:12 ` Christian Brauner
@ 2026-11-18 13:22 ` David Laight
1 sibling, 0 replies; 3+ messages in thread
From: David Laight @ 2026-11-18 13:22 UTC (permalink / raw)
To: Sasha Levin; +Cc: Christian Brauner, Shuah Khan, linux-kernel, linux-kselftest
On Tue, 3 Nov 2026 10:54:47 -0500
Sasha Levin <sashal@kernel.org> wrote:
> On 32-bit architectures with a 64-bit time_t, such as armhf in Debian
> 13, printing the time_t values with %lu warns:
>
> pidfd_test.c:523:50: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'time_t' {aka 'long long int'} [-Wformat=]
>
> Cast them to long long and print them with %lld.
>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> Found with a 32-bit build of the selftests with a 64-bit time_t (gcc 16
> and clang 21 with -m32 -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64);
> KernelCI's 32-bit arm builds show the same warnings. The changed files
> build without format warnings there now, and the x86_64 builds don't
> change. The other selftests get the same kind of fix in separate
> patches.
>
> tools/testing/selftests/pidfd/pidfd_test.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
> index 932cbd8caa770..a53e72cb256ce 100644
> --- a/tools/testing/selftests/pidfd/pidfd_test.c
> +++ b/tools/testing/selftests/pidfd/pidfd_test.c
> @@ -520,7 +520,7 @@ static void test_pidfd_poll_exec(int use_waitpid)
>
> time_t prog_time = time(NULL) - prog_start;
Why not just change the type to 'unsigned int' and use "%u" ?
It isn't as though the difference is going to be longer than 75 years.
David
>
> - ksft_print_msg("Time waited for child: %lu\n", prog_time);
> + ksft_print_msg("Time waited for child: %lld\n", (long long)prog_time);
>
> close(pidfd);
>
> @@ -599,7 +599,8 @@ static void test_pidfd_poll_leader_exit(int use_waitpid)
>
> time_t since_child_exit = time(NULL) - *child_exit_secs;
>
> - ksft_print_msg("Time since child exit: %lu\n", since_child_exit);
> + ksft_print_msg("Time since child exit: %lld\n",
> + (long long)since_child_exit);
>
> close(pidfd);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-18 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-03 15:54 [PATCH] selftests/pidfd: print time_t as long long Sasha Levin
2026-11-18 12:12 ` Christian Brauner
2026-11-18 13:22 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®