From: Peter Zijlstra <peterz@infradead.org>
To: Fernand Sieber <sieberf@amazon.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Shuah Khan <shuah@kernel.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
Josh Don <joshdon@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
nh-open-source@amazon.com, Fahad Mubeen <fmubeen@amazon.de>,
David Woodhouse <dwmw@amazon.co.uk>,
Misha Karataiev <karataev@amazon.com>,
Hendrik Borghorst <hborghor@amazon.de>,
Ibrahim Elshahed <lshahed@amazon.de>
Subject: Re: [PATCH 3/5] sched/core: Rank DL server picks as deadline in the core-wide pick
Date: Wed, 18 Nov 2026 14:52:49 +0100 [thread overview]
Message-ID: <20261118135249.GY1779021@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20261112161548.78189-4-sieberf@amazon.com>
On Thu, Nov 12, 2026 at 06:15:46PM +0200, Fernand Sieber wrote:
> Commit 4b26cfdd3956 ("sched/core: Fix priority checking for DL server
> picks") made the core-wide selection rank a task picked through a DL
> server as deadline, so that a fair task competing with RT tasks under
> core scheduling still gets its server's bandwidth. It keys on
> p->dl_server, which pick_task() used to set.
>
> Since commit bd9bbc96e835 ("sched: Rework dl_server"), pick_task()
> records the server in rq->dl_server and p->dl_server is only set once
> the task is switched in. The core-wide selection still ranks each
> sibling's pick with prio_less(), so a task the sibling's server has
> just picked ranks as a plain fair or ext task and loses to an RT task
> on another sibling. The server's CPU then runs a task with the RT
> task's cookie or is forced idle, and the fair task gets none of the
> server's bandwidth for as long as the RT task runs.
>
> Rank each sibling's pick by the server it came through, rq_i->dl_server.
> prio_less() keeps using p->dl_server for the core tree, whose tasks are
> not being picked.
>
I don't love this, but I don't see another way either, so yes.
next prev parent reply other threads:[~2026-11-18 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 16:15 [PATCH 0/5] sched: Fix DL server starvation under core scheduling Fernand Sieber
2026-11-12 16:15 ` [PATCH 1/5] sched/core: Clear stale rq->dl_server when core-sched replaces a pick Fernand Sieber
2026-11-12 16:15 ` [PATCH 2/5] sched/core: Keep a sibling's DL server link in the core-wide pick Fernand Sieber
2026-11-18 13:50 ` Peter Zijlstra
2026-11-18 13:58 ` Peter Zijlstra
2026-11-12 16:15 ` [PATCH 3/5] sched/core: Rank DL server picks as deadline " Fernand Sieber
2026-11-18 13:52 ` Peter Zijlstra [this message]
2026-11-12 16:15 ` [PATCH 4/5] sched/deadline: Don't charge core-sched forced idle to the DL servers Fernand Sieber
2026-11-12 16:15 ` [PATCH 5/5] selftests/sched: Add a core-sched forced-idle DL server test Fernand Sieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118135249.GY1779021@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=dwmw@amazon.co.uk \
--cc=fmubeen@amazon.de \
--cc=hborghor@amazon.de \
--cc=joelagnelf@nvidia.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=karataev@amazon.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lshahed@amazon.de \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nh-open-source@amazon.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=sieberf@amazon.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®