From: Joshua Crofts <crofts@kernel.org>
To: NanamiKite <nanami@yosoro.hk>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: cm32181: Add support for CM32183
Date: Wed, 18 Nov 2026 16:18:55 +0100 [thread overview]
Message-ID: <20261118161855.000017dd@kernel.org> (raw)
In-Reply-To: <tencent_E90EB0AF3888FA057AA5F6008C16C610650A@qq.com>
On Wed, 18 Nov 2026 23:11:00 +0800
NanamiKite <nanami@yosoro.hk> wrote:
> On the H3C MegaBook 14, the ACPI CPLM3218:00 node declares a Capella
> CM32183 ambient light sensor (CPM0 device ID 0x7db7 / 32183) at I2C
> address 0x29. Reading CM32181_REG_ADDR_ID (0x07) returns 0xc383, with
> chip ID 0x83 in the lower byte, causing cm32181_reg_init() to fail with
> -ENODEV.
>
> The CM32183 uses the same register layout and ACPI CPM0/CPM1 tables as
> the CM32181 and CM32182. Add chip ID 0x83 to cm32181_reg_init().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: NanamiKite <nanami@yosoro.hk>
> ---
LGTM.
Reviewed-by: Joshua Crofts <crofts@kernel.org>
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-11-18 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:11 NanamiKite
2026-11-18 15:18 ` Joshua Crofts [this message]
2026-11-18 15:42 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118161855.000017dd@kernel.org \
--to=crofts@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=hansg@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nanami@yosoro.hk \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®