* [PATCH] iio: light: cm32181: Add support for CM32183
@ 2026-11-18 15:11 NanamiKite
2026-11-18 15:18 ` Joshua Crofts
0 siblings, 1 reply; 2+ messages in thread
From: NanamiKite @ 2026-11-18 15:11 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: Hans de Goede, linux-iio, linux-kernel
On the H3C MegaBook 14, the ACPI CPLM3218:00 node declares a Capella
CM32183 ambient light sensor (CPM0 device ID 0x7db7 / 32183) at I2C
address 0x29. Reading CM32181_REG_ADDR_ID (0x07) returns 0xc383, with
chip ID 0x83 in the lower byte, causing cm32181_reg_init() to fail with
-ENODEV.
The CM32183 uses the same register layout and ACPI CPM0/CPM1 tables as
the CM32181 and CM32182. Add chip ID 0x83 to cm32181_reg_init().
Cc: stable@vger.kernel.org
Signed-off-by: NanamiKite <nanami@yosoro.hk>
---
drivers/iio/light/cm32181.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index b32a940..aaf1af3 100644
--- a/drivers/iio/light/cm32181.c
+++ b/drivers/iio/light/cm32181.c
@@ -200,6 +200,7 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
break;
case 0x81: /* CM32181 */
case 0x82: /* CM32182, fully compat. with CM32181 */
+ case 0x83: /* CM32183, fully compat. with CM32181 */
cm32181->num_als_it = ARRAY_SIZE(cm32181_als_it_bits);
cm32181->als_it_bits = cm32181_als_it_bits;
cm32181->als_it_values = cm32181_als_it_values;
--
2.56.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: light: cm32181: Add support for CM32183
2026-11-18 15:11 [PATCH] iio: light: cm32181: Add support for CM32183 NanamiKite
@ 2026-11-18 15:18 ` Joshua Crofts
0 siblings, 0 replies; 2+ messages in thread
From: Joshua Crofts @ 2026-11-18 15:18 UTC (permalink / raw)
To: NanamiKite
Cc: Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Hans de Goede, linux-iio, linux-kernel
On Wed, 18 Nov 2026 23:11:00 +0800
NanamiKite <nanami@yosoro.hk> wrote:
> On the H3C MegaBook 14, the ACPI CPLM3218:00 node declares a Capella
> CM32183 ambient light sensor (CPM0 device ID 0x7db7 / 32183) at I2C
> address 0x29. Reading CM32181_REG_ADDR_ID (0x07) returns 0xc383, with
> chip ID 0x83 in the lower byte, causing cm32181_reg_init() to fail with
> -ENODEV.
>
> The CM32183 uses the same register layout and ACPI CPM0/CPM1 tables as
> the CM32181 and CM32182. Add chip ID 0x83 to cm32181_reg_init().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: NanamiKite <nanami@yosoro.hk>
> ---
LGTM.
Reviewed-by: Joshua Crofts <crofts@kernel.org>
--
Kind regards,
Joshua Crofts
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 15:11 [PATCH] iio: light: cm32181: Add support for CM32183 NanamiKite
2026-11-18 15:18 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®