From: Lee Jones <lee@kernel.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sandipan Patra <spatra@nvidia.com>,
linux-pwm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/8] pwm: tegra: Prevent 32-bit period truncation and division by zero
Date: Wed, 18 Nov 2026 17:16:36 +0000 [thread overview]
Message-ID: <20261118171636.GD98456@joneslee-macbookpro.roam.internal> (raw)
In-Reply-To: <auykeNit2S4e7axg@monoceros>
On Thu, 05 Nov 2026, Uwe Kleine-König wrote:
> Hello Lee,
>
> On Thu, Nov 05, 2026 at 02:38:03PM +0000, Lee Jones wrote:
> > tegra_pwm_apply() passes the 64-bit state->duty_cycle and state->period
> > values into tegra_pwm_config(), which accepts signed 32-bit int
> > parameters and performs DIV_ROUND_CLOSEST_ULL(c, period_ns) before
> > validating period_ns against pc->min_period_ns. If a consumer requests
> > a period that is a non-zero multiple of 2^32 nanoseconds, period_ns
> > truncates to zero and triggers a divide-by-zero panic.
> >
> > Widen duty_ns and period_ns to u64 and validate that period_ns lies
> > within [pc->min_period_ns, U32_MAX] prior to dividing by period_ns.
> >
> > Fixes: 1d7796bdb63a ("pwm: tegra: Support dynamic clock frequency configuration")
> > Fixes: fd3ddd4355c0 ("pwm: tegra: Implement .apply() callback")
> > Closes: https://sashiko.dev/#/bug/linux-5c5b97d6-4da6-4d06-9dc7-957419dcd832
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Lee Jones <lee@kernel.org>
>
> This is already addressed in
> 9ad5602d4943 ("pwm: tegra: Fix value discarding for duty and period")
> which is next-20261102 and later.
Would you like me to resubmit the set without this or can you omit it?
--
Lee Jones
next prev parent reply other threads:[~2026-11-18 17:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 14:38 [PATCH 0/8] pwm: Fix various bugs reported by Sashiko Lee Jones
2026-11-05 14:38 ` [PATCH 1/8] pwm: tegra: Prevent 32-bit period truncation and division by zero Lee Jones
2026-11-05 15:46 ` Uwe Kleine-König
2026-11-18 17:16 ` Lee Jones [this message]
2026-11-05 14:38 ` [PATCH 2/8] pwm: mxs: Return early when disabling and fix error-path clock leak Lee Jones
2026-11-05 16:50 ` Frank Li
2026-11-05 14:38 ` [PATCH 3/8] pwm: loongson: Fix 32-bit control register truncation in pwm_loongson_set_polarity() Lee Jones
2026-11-05 14:38 ` [PATCH 4/8] pwm: axi-pwmgen: Enable clocks before accessing hardware registers in probe() Lee Jones
2026-11-05 15:48 ` Uwe Kleine-König
2026-11-05 18:26 ` Lee Jones
2026-11-05 18:26 ` Lee Jones
2026-11-06 13:01 ` Nuno Sá
2026-11-05 14:38 ` [PATCH 5/8] pwm: fsl-ftm: Enable ipg_clk around regcache_sync() during resume Lee Jones
2026-11-05 14:38 ` [PATCH 6/8] pwm: omap-dmtimer: Handle negative error codes from get_pwm_status() Lee Jones
2026-11-05 14:38 ` [PATCH 7/8] pwm: tiehrpwm: Enable runtime PM before registering PWM chip Lee Jones
2026-11-05 14:38 ` [PATCH 8/8] pwm: img: Unregister PWM chip before disabling runtime PM and clocks Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118171636.GD98456@joneslee-macbookpro.roam.internal \
--to=lee@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=s.hauer@pengutronix.de \
--cc=spatra@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®