mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 00/17] platform/x86/intel/ifs: Support group-based In-Field Scan and Diamond Rapids
@ 2026-11-18 19:32 Ehab Ababneh
  2026-11-18 19:32 ` [PATCH v2 01/17] platform/x86/intel/ifs: Revert SBAF feature Ehab Ababneh
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: Ehab Ababneh @ 2026-11-18 19:32 UTC (permalink / raw)
  To: ilpo.jarvinen, hansg, tony.luck
  Cc: ashok.raj.linux, platform-driver-x86, linux-kernel, tglx, mingo,
	bp, dave.hansen, x86, hpa, rostedt, mhiramat, mathieu.desnoyers,
	linux-trace-kernel, peterz, sathyanarayanan.kuppuswamy,
	pengfei.xu, ravi.v.shankar

Some Intel Xeon processors, starting with Diamond Rapids (DMR), share
one SCAN test engine between multiple CPU cores in a module (Dual-Core
Module, DCM), instead of only between the threads of a single core. All
logical processors that share an engine must start the In-Field Scan
(IFS) test at the same time. The current driver assumes the sharing
domain is cpu_smt_mask(), which does not hold on these systems. Also,
although the cores in a module are tested together, each core gets its
own result: on a DCM, one core can pass while the other fails.

This series:

 - Patch 1 removes the SBAF test, which is not planned for any CPU and
   whose test images were never published.

 - Patches 2-6 are cleanups and preparatory refactoring (comment fixes,
   clearer MSR bit names, u64 MSR bitfields, early return on image
   errors, a generic Array BIST parameter struct). Patches 2-4 have no
   functional change.

 - Patch 7 adds stop_cluster_cpuslocked(), the cluster-level counterpart
   of stop_core_cpuslocked(), so that all threads of a cluster can
   rendezvous and issue WRMSR at the same time.

 - Patches 8-10 enumerate ALL_LP_JOIN_NEEDED, select the CPUs to test
   together from topology_cluster_cpumask(), and warn when a group test
   does not pass while some of the logical processors sharing the scan
   engine (per TID_BIT_SHIFT) were not in the group.

 - Patches 11-13 record per-CPU results for group tests and expose them
   through new sysfs files (status_list, details_list, cpus_ran_list,
   addnl_details_list). The existing status and details files remain,
   but now report the result of the CPU written to run_test rather than
   the first CPU in the group.

 - Patch 14 adds Diamond Rapids to the CPU match table.

 - Patch 15 removes the 256 limit on the batch file number.

 - Patches 16-17 update the IFS documentation and ABI document.

Most of this series was developed by Jithu Joseph and Qiuxu Zhuo, who
have both since left Intel. I have taken over upstreaming it, so please
send questions and review comments to me. The patches keep their
original authorship and Signed-off-by tags, except patch 10, which I
rewrote for v2 (Qiuxu is credited as co-developer). Where Qiuxu
changed a patch written by someone else, the change is noted in
brackets in the commit message, and I have added my Signed-off-by to
every patch.

Changes in v2:
- Rebased onto v7.4-rc1.
- Tested on Emerald Rapids, Granite Rapids, Clearwater Forest and
  Diamond Rapids (Tested-by: Yi Lai on all patches).
- Patch 9: build the CPU group mask only after the CPU online and image
  loaded checks pass, so a rejected run_test write no longer changes
  the group reported by the *_list files (Sashiko).
- Patch 10: reworked, with a new title (was "Validate TID_BIT_SHIFT
  matches topology_cluster_cpumask()"). The check at driver init is
  gone: it failed driver load on Sapphire Rapids and Emerald Rapids,
  which don't enumerate TID_BIT_SHIFT, when a CPU in the group was
  offline, and on parts that expose only one core per module. Now
  TID_BIT_SHIFT is read at init and, if a test does not pass, the
  driver warns when not all logical processors in the TID_BIT_SHIFT
  range were in the group. The test always runs (Sashiko, suggested by
  Tony Luck). Author changed to me, with Qiuxu as Co-developed-by.
- Patch 11:
  - clear the per-CPU results of the group at the start of each test,
    and clear them in ifs_init() before the devices are registered
    (Sashiko);
  - restart an interrupted test from the lowest chunk reached by any
    CPU in the group (Sashiko);
  - don't overwrite error codes reported by the hardware with the
    driver's timeout or partial-completion code; report a CPU that
    stopped early without an error code as partially completed
    (Sashiko);
  - the patch 10 warning checks the results of all CPUs in the group;
  - commit message: explain that cores in a group can report
    different results.
- Patches 12, 13: read the CPU group mask only once in the *_list show
  functions (Sashiko).
- Patch 16: fix typos; say "group" instead of "core"; use the real
  attribute name addnl_details in the commit message; describe what
  happens with offline CPUs instead of requiring all CPUs in a group
  to be online (Sashiko).

v1: https://lore.kernel.org/all/20261026183820.129459-1-ehab.ababneh@intel.com/

Ehab Ababneh (1):
  platform/x86/intel/ifs: Warn if a group test fails with CPUs missing

Jithu Joseph (7):
  platform/x86/intel/ifs: Refactor Array BIST function interface
  platform/x86/intel/ifs: Enumerate the bit to determine if CPUs need to
    join for IFS tests
  platform/x86/intel/ifs: Select CPUs from topology_cluster_cpumask()
    for simultaneous IFS tests
  platform/x86/intel/ifs: Track and report scan results on a per-CPU
    basis
  platform/x86/intel/ifs: Add new sysfs interfaces {status, details,
    cpus_ran}_list
  platform/x86/intel/ifs: Add additional details sysfs interface
  platform/x86/intel/ifs: Add Intel Diamond Rapids server support

Qiuxu Zhuo (8):
  platform/x86/intel/ifs: Revert SBAF feature
  platform/x86/intel/ifs: Fix IFS sysfs interfaces in the comments
  platform/x86/intel/ifs: Clarify In-Field Scan MSR bit macro
    definitions
  platform/x86/intel/ifs: Use u64 to define the bits of IFS MSR
    registers
  platform/x86/intel/ifs: Early return on the IFS image hash/chunk error
  stop_machine: Add stop_cluster_cpuslocked() for per-cluster operations
  platform/x86/intel/ifs: Update IFS documentation
  Documentation/ABI: Update IFS ABI doc

Tony Luck (1):
  platform/x86/intel/ifs: Remove limit on number of batch files

 .../ABI/testing/sysfs-platform-intel-ifs      |  33 +-
 arch/x86/include/asm/msr-index.h              |  17 +-
 drivers/platform/x86/intel/ifs/core.c         |  59 ++-
 drivers/platform/x86/intel/ifs/ifs.h          | 229 ++++-----
 drivers/platform/x86/intel/ifs/load.c         |  52 +-
 drivers/platform/x86/intel/ifs/runtest.c      | 450 ++++++++----------
 drivers/platform/x86/intel/ifs/sysfs.c        | 109 ++++-
 include/linux/stop_machine.h                  |  15 +
 include/trace/events/intel_ifs.h              |  27 --
 kernel/stop_machine.c                         |  35 +-
 tools/arch/x86/include/asm/msr-index.h        |  14 +-
 11 files changed, 531 insertions(+), 509 deletions(-)


base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
-- 
2.43.0


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2026-11-18 19:30 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 19:32 [PATCH v2 00/17] platform/x86/intel/ifs: Support group-based In-Field Scan and Diamond Rapids Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 01/17] platform/x86/intel/ifs: Revert SBAF feature Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 02/17] platform/x86/intel/ifs: Fix IFS sysfs interfaces in the comments Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 03/17] platform/x86/intel/ifs: Clarify In-Field Scan MSR bit macro definitions Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 04/17] platform/x86/intel/ifs: Use u64 to define the bits of IFS MSR registers Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 05/17] platform/x86/intel/ifs: Early return on the IFS image hash/chunk error Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 06/17] platform/x86/intel/ifs: Refactor Array BIST function interface Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 07/17] stop_machine: Add stop_cluster_cpuslocked() for per-cluster operations Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 08/17] platform/x86/intel/ifs: Enumerate the bit to determine if CPUs need to join for IFS tests Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 09/17] platform/x86/intel/ifs: Select CPUs from topology_cluster_cpumask() for simultaneous " Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 10/17] platform/x86/intel/ifs: Warn if a group test fails with CPUs missing Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 11/17] platform/x86/intel/ifs: Track and report scan results on a per-CPU basis Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 12/17] platform/x86/intel/ifs: Add new sysfs interfaces {status, details, cpus_ran}_list Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 13/17] platform/x86/intel/ifs: Add additional details sysfs interface Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 14/17] platform/x86/intel/ifs: Add Intel Diamond Rapids server support Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 15/17] platform/x86/intel/ifs: Remove limit on number of batch files Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 16/17] platform/x86/intel/ifs: Update IFS documentation Ehab Ababneh
2026-11-18 19:32 ` [PATCH v2 17/17] Documentation/ABI: Update IFS ABI doc Ehab Ababneh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®