From: Simon Horman <horms@kernel.org>
To: lirongqing <lirongqing@baidu.com>
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: rxgk: Fix uninitialised stack byte leaked via RXRPC_CHALLENGED
Date: Wed, 18 Nov 2026 20:30:42 +0000 [thread overview]
Message-ID: <20261118203042.GR860048@horms.kernel.org> (raw)
In-Reply-To: <20261112114305.2340-1-lirongqing@baidu.com>
On Thu, Nov 12, 2026 at 07:43:05PM +0800, lirongqing wrote:
> From: Li RongQing <lirongqing@baidu.com>
>
> rxgk_challenge_to_recvmsg() builds struct rxgk_challenge on the stack
> and passes all 8 bytes to put_cmsg() via RXRPC_CHALLENGED, but never
> initialises base.pad at offset 3. The struct has no implicit padding,
> so this byte contain leftover kernel stack data and be exposed to
> userspace. This issue was identified by code inspection.
>
> Zero-initialise the structure to prevent the potential information leak.
>
> Fixes: 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-11-18 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 11:43 lirongqing
2026-11-18 20:30 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118203042.GR860048@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®