mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: linux-kernel@vger.kernel.org,
	Ashok Raj <ashok.raj@oss.qualcomm.com>,
	James Morse <james.morse@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Pawel Chmielewski <pawel.chmielewski@intel.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Radu Rendec <radu@rendec.net>,
	Avadhut Naik <avadhut.naik@amd.com>,
	Kai-Heng Feng <kaihengf@nvidia.com>,
	Dave Jiang <dave.jiang@intel.com>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
	Breno Leitao <leitao@debian.org>, Dan Williams <djbw@kernel.org>,
	Terry Bowman <terry.bowman@amd.com>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
	acpica-devel@lists.linux.dev
Subject: Re: [PATCH v1 18/19] ACPI: APEI: Route GHES section reporting through extlog
Date: Wed, 18 Nov 2026 20:30:46 +0000	[thread overview]
Message-ID: <20261118203046.7987bebf@jic23-hlaptop> (raw)
In-Reply-To: <20261117111444.4185512-19-pierre.gondois@arm.com>

On Tue, 17 Nov 2026 12:10:28 +0100
Pierre Gondois <pierre.gondois@arm.com> wrote:

> Use acpi_extlog_report() for GHES section reporting and remove the
> duplicate dispatch code.
> 
> GHES memory sections now emit extlog trace events independently of EDAC
> registration, using the CPER section severity and one sequence number
> per status block. CXL events that cannot be queued fall back to the
> nonstandard trace event.
> 
> Report all sections before running the remaining GHES handlers. Keep
> memory recovery, SIGBUS handling and notifier calls in GHES.
This mix and match of where things are handled leaves me wondering
a bit if the unification is a good idea.

Sure there is a bit of duplication reduction, but we still end
up with slightly diverging flows.  The ordering of reporting could
also change due to a mixture of sections being handled by each
loop. Not necessarily a problem, but that needs some thought.

I'll wait to see if others are more in favour. 

Jonathan

> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>  drivers/acpi/apei/apei-internal.h |  1 -
>  drivers/acpi/apei/extlog.c        |  2 +-
>  drivers/acpi/apei/ghes.c          | 57 +++++++------------------------
>  3 files changed, 13 insertions(+), 47 deletions(-)
> 
> diff --git a/drivers/acpi/apei/apei-internal.h b/drivers/acpi/apei/apei-internal.h
> index 22a33a21017a3..5063c743b4cf0 100644
> --- a/drivers/acpi/apei/apei-internal.h
> +++ b/drivers/acpi/apei/apei-internal.h
> @@ -14,7 +14,6 @@ int ghes_severity(int severity);
>  int cxl_cper_post_event(enum cxl_event_type event_type,
>  			struct cxl_cper_event_rec *rec, u32 len);
>  u32 acpi_extlog_mem_err_min_len(u64 validation_bits);
> -void extlog_print_pcie(struct acpi_hest_generic_data *gdata);
>  void acpi_extlog_report(const struct acpi_hest_generic_status *estatus);
>  
>  struct apei_exec_context;
> diff --git a/drivers/acpi/apei/extlog.c b/drivers/acpi/apei/extlog.c
> index 42ba8ba13804f..d1677d299e389 100644
> --- a/drivers/acpi/apei/extlog.c
> +++ b/drivers/acpi/apei/extlog.c
> @@ -31,7 +31,7 @@
>   * CPER_SEV_FATAL or CPER_SEC_RESET -> AER_FATAL
>   *     These both need to be reported and recovered from by the AER driver.
>   */
> -void extlog_print_pcie(struct acpi_hest_generic_data *gdata)
> +static void extlog_print_pcie(struct acpi_hest_generic_data *gdata)
>  {
>  #ifdef CONFIG_ACPI_APEI_PCIEAER
>  	struct cper_sec_pcie *pcie_err = acpi_hest_get_payload(gdata);
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 7d2864fa14503..221f0a81c94f6 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -566,9 +566,7 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata,
>  	char *p;
>  
>  	sec_sev = ghes_severity(gdata->error_severity);
> -	if (length >= sizeof(*err)) {
> -		log_arm_hw_error(err, sec_sev);
> -	} else {
> +	if (length < sizeof(*err)) {
>  		pr_warn(FW_BUG "arm error length: %d\n", length);
>  		pr_warn(FW_BUG "length is too small\n");
>  		pr_warn(FW_BUG "firmware-generated error record is incorrect\n");
> @@ -884,34 +882,23 @@ static void ghes_log_hwerr(int sev, guid_t *sec_type)
>  static void ghes_do_proc(struct ghes *ghes,
>  			 const struct acpi_hest_generic_status *estatus)
>  {
> -	int sev, sec_sev;
> +	int sev;
>  	struct acpi_hest_generic_data *gdata;
>  	guid_t *sec_type;
> -	const guid_t *fru_id;
> -	const char *fru_text;
>  	bool queued = false;
>  	bool sync = is_hest_sync_notify(ghes);
>  
> +	acpi_extlog_report(estatus);
> +
>  	sev = ghes_severity(estatus->error_severity);
>  	apei_estatus_for_each_section(estatus, gdata) {
>  		sec_type = (guid_t *)gdata->section_type;
> -		sec_sev = ghes_severity(gdata->error_severity);
> -		if (gdata->validation_bits & CPER_SEC_VALID_FRU_ID)
> -			fru_id = (guid_t *)gdata->fru_id;
> -		else
> -			fru_id = &guid_null;
> -
> -		if (gdata->validation_bits & CPER_SEC_VALID_FRU_TEXT)
> -			fru_text = gdata->fru_text;
> -		else
> -			fru_text = "";
> -
>  		ghes_log_hwerr(sev, sec_type);
>  		if (guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) {
>  			struct cper_sec_mem_err *mem_err = acpi_hest_get_payload(gdata);
>  
>  			/*
> -			 * Check once for all three consumers below. The 73-byte
> +			 * Check once for all consumers below. The 73-byte
>  			 * UEFI 2.1/2.2 layout is the floor, matching
>  			 * cper_estatus_print_section() and making
>  			 * validation_bits safe to read.
> @@ -944,37 +931,17 @@ static void ghes_do_proc(struct ghes *ghes,
>  			atomic_notifier_call_chain(&ghes_report_mem2_chain, sev, mem_err);
>  			arch_apei_report_mem_error2(sev, mem_err);
>  			queued |= ghes_handle_memory_failure2(gdata, sev, sync);
> -		} else if (guid_equal(sec_type, &CPER_SEC_PCIE)) {
> -			extlog_print_pcie(gdata);
>  		} else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
>  			queued |= ghes_handle_arm_hw_error(gdata, sev, sync);
> -		} else if (guid_equal(sec_type, &CPER_SEC_CXL_PROT_ERR)) {
> -			struct cxl_cper_sec_prot_err *prot_err = acpi_hest_get_payload(gdata);
> -
> -			cxl_cper_post_prot_err(prot_err, gdata->error_severity,
> -					       gdata->error_data_length);
> -		} else if (guid_equal(sec_type, &CPER_SEC_CXL_GEN_MEDIA_GUID)) {
> -			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> -
> -			cxl_cper_post_event(CXL_CPER_EVENT_GEN_MEDIA, rec,
> -					    gdata->error_data_length);
> -		} else if (guid_equal(sec_type, &CPER_SEC_CXL_DRAM_GUID)) {
> -			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> -
> -			cxl_cper_post_event(CXL_CPER_EVENT_DRAM, rec,
> -					    gdata->error_data_length);
> -		} else if (guid_equal(sec_type, &CPER_SEC_CXL_MEM_MODULE_GUID)) {
> -			struct cxl_cper_event_rec *rec = acpi_hest_get_payload(gdata);
> -
> -			cxl_cper_post_event(CXL_CPER_EVENT_MEM_MODULE, rec,
> -					    gdata->error_data_length);
> +		} else if (guid_equal(sec_type, &CPER_SEC_PCIE) ||
> +			   guid_equal(sec_type, &CPER_SEC_CXL_PROT_ERR) ||
> +			   guid_equal(sec_type, &CPER_SEC_CXL_GEN_MEDIA_GUID) ||
> +			   guid_equal(sec_type, &CPER_SEC_CXL_DRAM_GUID) ||
> +			   guid_equal(sec_type, &CPER_SEC_CXL_MEM_MODULE_GUID)) {
> +			/* Reporting and subsystem delivery are handled by extlog. */
> +			continue;
>  		} else {
> -			void *err = acpi_hest_get_payload(gdata);
> -
>  			ghes_defer_non_standard_event(gdata, sev);
> -			log_non_standard_event(sec_type, fru_id, fru_text,
> -					       sec_sev, err,
> -					       gdata->error_data_length);
>  		}
>  	}
>  


  reply	other threads:[~2026-11-18 20:30 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:10 [PATCH v1 00/19] ACPI: APEI: Share CPER reporting between GHES and extlog Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 01/19] x86/APEI: Extract common CPER memory error reporting helper Pierre Gondois
2026-11-18 18:54   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 02/19] x86/APEI: Report Memory Error Section 2 through MCE Pierre Gondois
2026-11-18 18:57   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 03/19] ras: Bound CPER FRU strings in trace events Pierre Gondois
2026-11-18 19:06   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 04/19] ACPI: APEI: Use empty FRU values if valid bit is absent Pierre Gondois
2026-11-18 19:10   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 05/19] PCI/AER: Embed aer_capability_regs copy in struct aer_recover_entry Pierre Gondois
2026-11-17 11:44   ` Lukas Wunner
2026-11-18 15:10     ` Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 06/19] ACPI: APEI: Remove aer allocation in ghes_handle_aer() Pierre Gondois
2026-11-18 19:14   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 07/19] ACPI: extlog: Provide HEST generic data to extlog_print_pcie() Pierre Gondois
2026-11-18 19:17   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 08/19] ACPI: extlog: Align extlog_print_pcie() and ghes_handle_aer() Pierre Gondois
2026-11-18 19:29   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 09/19] ACPI: extlog: Report errors independently of RAS consumers Pierre Gondois
2026-11-18 19:45   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 10/19] ACPI: extlog: Simplify fatal record printing Pierre Gondois
2026-11-18 19:46   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 11/19] RAS: Remove unused ras_userspace_consumers() Pierre Gondois
2026-11-18 19:49   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 12/19] ACPI: extlog: Extract CPER reporting from acpi_extlog Pierre Gondois
2026-11-18 20:04   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 13/19] ACPI: APEI: Share helpers with the common CPER reporter Pierre Gondois
2026-11-17 11:10 ` [PATCH v1 14/19] ACPI: APEI: Return status from cxl_cper_post_event() Pierre Gondois
2026-11-18 20:06   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 15/19] ACPI: APEI: Extend common CPER reporting for GHES section types Pierre Gondois
2026-11-18 20:14   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 16/19] ACPI: extlog: Report error severity using GHES bindings in MCE Pierre Gondois
2026-11-18 20:17   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 17/19] ACPI: APEI: Share the extlog PCIe handler with GHES Pierre Gondois
2026-11-18 20:22   ` Jonathan Cameron
2026-11-17 11:10 ` [PATCH v1 18/19] ACPI: APEI: Route GHES section reporting through extlog Pierre Gondois
2026-11-18 20:30   ` Jonathan Cameron [this message]
2026-11-17 11:10 ` [PATCH v1 19/19] PCI/ERR: Avoid NULL bridge pointer Pierre Gondois
2026-11-17 11:50   ` Lukas Wunner
2026-11-17 18:57     ` Kuppuswamy Sathyanarayanan
2026-11-18 15:11       ` Pierre Gondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118203046.7987bebf@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=acpica-devel@lists.linux.dev \
    --cc=ashok.raj@oss.qualcomm.com \
    --cc=avadhut.naik@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=djbw@kernel.org \
    --cc=fabio.m.de.francesco@linux.intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=kaihengf@nvidia.com \
    --cc=leitao@debian.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=mahesh@linux.ibm.com \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=oohall@gmail.com \
    --cc=pawel.chmielewski@intel.com \
    --cc=pierre.gondois@arm.com \
    --cc=radu@rendec.net \
    --cc=rafael@kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=terry.bowman@amd.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®