From: Peder Bergan via B4 Relay <devnull+peder.bergan.gmail.com@kernel.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Carlos Llamas" <cmllamas@google.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH] rust: bindgen: Preserve sched_statistics alignment
Date: Thu, 19 Nov 2026 20:33:07 +0100 [thread overview]
Message-ID: <20261119-fix-schedstats-bindgen-layout-v1-1-0599dd230ffd@gmail.com> (raw)
From: Peder Bergan <peder.bergan@gmail.com>
With CONFIG_SCHEDSTATS disabled, struct sched_statistics is empty but
still cache-line aligned. Bindgen emits the empty definition without
that alignment. On affected builds this misplaces fields following
stats in the generated task_struct. In the reported arm64 build, Rust
Binder reads the wrong pointer via CurrentTask::mm() and rejects mmap()
with -EINVAL.
Make sched_statistics opaque so bindgen uses the C size and alignment.
Rust has no callers that access the fields of this type.
Fixes: 313c4281bc9d ("rust: add basic `Task`")
Closes: https://github.com/Rust-for-Linux/linux/issues/1269
Cc: stable@vger.kernel.org
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
Jules Mercier reported the layout mismatch on arm64.
On arm64 with bindgen 0.73.2 and CONFIG_SCHEDSTATS=n, the generated Rust
binding placed task_struct.mm at offset 1168 while the C layout placed
it at 1208. After the change both report 1208. The layouts also agree
with CONFIG_SCHEDSTATS=y, and the Rust kernel crate and Binder driver
build with Clippy in both configurations.
OpenAI Codex assisted with the bindgen change, validation and drafting.
---
rust/bindgen_parameters | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/rust/bindgen_parameters b/rust/bindgen_parameters
index 5bab3cf063360..2686687555af3 100644
--- a/rust/bindgen_parameters
+++ b/rust/bindgen_parameters
@@ -26,6 +26,10 @@
# warning. We don't need to peek into it anyway.
--opaque-type spinlock
+# Bindgen drops the alignment of empty structs. Keep the cache-line alignment
+# of sched_statistics when CONFIG_SCHEDSTATS is disabled.
+--opaque-type sched_statistics
+
# enums that appear in indirect function calls should specify a cfi type
--newtype-enum fwctl_rpc_scope
--with-attribute-custom-enum=fwctl_rpc_scope='#[cfi_encoding="15fwctl_rpc_scope"]'
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261119-fix-schedstats-bindgen-layout-0935b6434707
Best regards,
--
Peder Bergan <peder.bergan@gmail.com>
reply other threads:[~2026-11-19 19:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119-fix-schedstats-bindgen-layout-v1-1-0599dd230ffd@gmail.com \
--to=devnull+peder.bergan.gmail.com@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cmllamas@google.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=peder.bergan@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®