mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] rust: bindgen: Preserve sched_statistics alignment
@ 2026-11-19 19:33 Peder Bergan via B4 Relay
  0 siblings, 0 replies; only message in thread
From: Peder Bergan via B4 Relay @ 2026-11-19 19:33 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
	Daniel Almeida, Tamir Duberstein, Alexandre Courbot,
	Onur Özkan, Carlos Llamas, rust-for-linux, linux-kernel,
	stable

From: Peder Bergan <peder.bergan@gmail.com>

With CONFIG_SCHEDSTATS disabled, struct sched_statistics is empty but
still cache-line aligned. Bindgen emits the empty definition without
that alignment. On affected builds this misplaces fields following
stats in the generated task_struct. In the reported arm64 build, Rust
Binder reads the wrong pointer via CurrentTask::mm() and rejects mmap()
with -EINVAL.

Make sched_statistics opaque so bindgen uses the C size and alignment.
Rust has no callers that access the fields of this type.

Fixes: 313c4281bc9d ("rust: add basic `Task`")
Closes: https://github.com/Rust-for-Linux/linux/issues/1269
Cc: stable@vger.kernel.org
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
Jules Mercier reported the layout mismatch on arm64.

On arm64 with bindgen 0.73.2 and CONFIG_SCHEDSTATS=n, the generated Rust
binding placed task_struct.mm at offset 1168 while the C layout placed
it at 1208. After the change both report 1208. The layouts also agree
with CONFIG_SCHEDSTATS=y, and the Rust kernel crate and Binder driver
build with Clippy in both configurations.

OpenAI Codex assisted with the bindgen change, validation and drafting.
---
 rust/bindgen_parameters | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/rust/bindgen_parameters b/rust/bindgen_parameters
index 5bab3cf063360..2686687555af3 100644
--- a/rust/bindgen_parameters
+++ b/rust/bindgen_parameters
@@ -26,6 +26,10 @@
 # warning. We don't need to peek into it anyway.
 --opaque-type spinlock
 
+# Bindgen drops the alignment of empty structs. Keep the cache-line alignment
+# of sched_statistics when CONFIG_SCHEDSTATS is disabled.
+--opaque-type sched_statistics
+
 # enums that appear in indirect function calls should specify a cfi type
 --newtype-enum fwctl_rpc_scope
 --with-attribute-custom-enum=fwctl_rpc_scope='#[cfi_encoding="15fwctl_rpc_scope"]'

---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261119-fix-schedstats-bindgen-layout-0935b6434707

Best regards,
--  
Peder Bergan <peder.bergan@gmail.com>



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 19:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 19:33 [PATCH] rust: bindgen: Preserve sched_statistics alignment Peder Bergan via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®