mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] fscrypt: Don't set a policy on immutable or append-only directories
@ 2026-11-19 12:57 Suyuan Wang via B4 Relay
  0 siblings, 0 replies; only message in thread
From: Suyuan Wang via B4 Relay @ 2026-11-19 12:57 UTC (permalink / raw)
  To: ebiggers; +Cc: jaegeuk, tytso, linux-kernel, linux-fscrypt

From: Suyuan Wang <stevewong@hust.edu.cn>

FS_IOC_SET_ENCRYPTION_POLICY stores an encryption context in the
directory (an xattr on ext4 and f2fs) and marks the inode as encrypted.
fscrypt_ioctl_set_policy() checks inode_owner_or_capable(), but not the
immutable or append-only inode flags, so the ioctl also succeeds on a
directory with one of those flags set. Setting any other xattr on the
same directory fails with -EPERM in may_write_xattr(), and
FS_IOC_ENABLE_VERITY refuses such files as well.

For example, on ext4 with the encrypt feature:

	mkdir d && chattr +i d
	setfattr -n user.x -v 1 d           -> Operation not permitted
	FS_IOC_SET_ENCRYPTION_POLICY on d   -> succeeds, d now has a policy

Return -EPERM for an immutable or append-only directory before setting
the policy, as may_write_xattr() does. Calls that find the same policy
already set still return 0, since they don't change the inode.

Found with a static analysis tool and checked by hand.

Fixes: 0b81d0779072 ("fs crypto: move per-file encryption from f2fs tree to fs/crypto")
Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
---
Tested in QEMU (x86_64, ext4 with -O encrypt, v1 policy). Before the
patch the ioctl succeeds on both immutable and append-only empty
directories; with it both get -EPERM, and an ordinary empty directory
still gets its policy.

The Fixes: tag points to the commit that created fs/crypto/policy.c; the
ext4 and f2fs encryption policy code before it lacked these checks too.
I left out Cc: stable, as I'm not sure you'd want this backported.
---
 fs/crypto/policy.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c
index 6dd510f93e6d..86a8254bc3a8 100644
--- a/fs/crypto/policy.c
+++ b/fs/crypto/policy.c
@@ -553,6 +553,8 @@ int fscrypt_ioctl_set_policy(struct file *filp, const void __user *arg)
 			ret = -ENOTDIR;
 		else if (IS_DEADDIR(inode))
 			ret = -ENOENT;
+		else if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
+			ret = -EPERM;
 		else if (!inode->i_sb->s_cop->empty_dir(inode))
 			ret = -ENOTEMPTY;
 		else





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 12:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 12:57 [PATCH] fscrypt: Don't set a policy on immutable or append-only directories Suyuan Wang via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®