mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	"Arnaud Pouliquen" <arnaud.pouliquen@foss.st.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 00/11] iio: adc: stm32: add mdf support for stm32mp2
Date: Thu, 19 Nov 2026 18:37:46 +0000	[thread overview]
Message-ID: <20261119-stick-armored-64cd8e1cea62@spud> (raw)
In-Reply-To: <20261118-upstream_mdf_v2-v2-0-7939d3c3720a@foss.st.com>

[-- Attachment #1: Type: text/plain, Size: 10381 bytes --]

On Wed, Nov 18, 2026 at 04:17:45PM +0100, Olivier Moysan wrote:
> This series adds support for the STM32 Multi-function Digital Filter
> (MDF) found on STM32MP2 SoCs. MDF converts bitstreams from external
> sigma-delta modulators and PDM microphones into samples for IIO and
> ASoC consumers.
> 
> The drivers support direct IIO conversions, cyclic DMA acquisition,
> CIC configuration and scaling, synchronized and interleaved filters,
> and external timer triggers. An ASoC DAI provides PDM microphone capture.
> 
> This revision addresses the v1 review comments listed below and splits
> the driver patch into smaller functional patches for readability.
> It retains the existing IIO backend interface for external sigma-delta
> modulators, pending agreement on the preferred abstraction.
> 
> These changes do not resolve all v1 review comments. In particular, the
> frontend/backend architecture, DT child-node model and complete clock
> topology remain open discussion points.
> 
> * Open questions: MDF topology (backend/frontend)
> 
> In Analog Devices use of the IIO backend framework, the AXI ADC is a
> hardware backend, while the AD9467 is a hardware frontend. The external
> sigma-delta modulator is actually a hardware frontend in the MDF signal
> chain. The difference from the AD9467 use case is which driver owns the
> aggregate IIO device.

My red line here, that I probably made pretty clear on v1, is that what
is done needs to make sense when the ADC is feeding the MDF, it cannot
only work for the data coming in from sd modulators or w/e you connect
to the SITFx inputs.

> Option 1:
> One option would be to generalize the existing backend abstraction to
> represent components contributing to an aggregate IIO device,
> independently of their position in the signal chain.
> 
> The existing framework appears to provide the required mechanisms. None
> of these mechanisms inherently requires the provider to be a hardware backend.
> A generic component/provider model would support both topologies without
> duplicating interfaces or requiring reciprocal dependencies. The key
> point here is to preserve the compatibility of APIs and DT bindings.
> 
> Option 2:
> Alternatively, if the backend abstraction should retain its hardware
> meaning, we could introduce an explicit frontend-provider abstraction
> sharing the existing infrastructure. Frontend operations would cover
> analog-side control and conversion parameters.
> 
> Would generalizing the existing abstraction be acceptable, or would a
> separate frontend interface built on shared infrastructure be preferred?

For either of these options, do you envisage the data being retrieved
from the mdf sysfs files rather than from the modulator?

> 
> Option 3:
> An aggregate IIO device based on the component framework, as discussed
> in previous threads, could also be considered. I currently regard this
> as a fallback solution:
> https://lore.kernel.org/all/ec411432-4b77-4410-b0aa-b29f73b82c84@foss.st.com/

You option 2 in the earlier thread had:
| 2 - DFSDM managed as a "hardware accelerator"
| 
| 
|    +-------------+
|    | Sysfs       |
|    | - Scale     | +---------------+
|    | - Raw data  | | IIO char dev  |
|    +-------------+ +---------------+
|             ^             /\
|             |             ||
|             |             ||                         Userland
|   -----------------------------------------------------------
|             |             ||                         IIO fw
|             |             ||
|             |             ||
|   -----------------------------------------------------------
|             |             ||
|          +--|-------------||--+     +----------------+
|          |  |             ||  |     |                | Drivers
|          |  |             =======================    |
|          |  |                 |     |           ||   |
|          |  +-----------------+-----+--+        ||   |
|          |          +---------+-----+--+        ||   |
|          +----------|---------+     +-----------||---+
|                     |                           ||
|   -----------------------------------------------------------
|                     |                           ||
|          +----------|---------+     +-----------||---+
|          |                    |     |           ||   | Hardware
|          |    sd modulator    |     |  DFSDM    ||   |
|      =============================================   |
|          |                    |     |                |
|          +----------+---------+     +----------------+
|                     |
|                     |
|                    Vref
| 
| The DFSDM is a consumer of the SD modulator.
| 
| In addition to its complexity, the main drawback of this approach is 
| that it is unsuitable for interleaved mode.

Two mails prior I had theorised a way to deal with the interleaved mode
https://lore.kernel.org/all/20261015-attentive-conflict-1a1f538de77d@spud/
but I never saw a response from you as to why something like that cannot
work. That's twice in that thread you said it was unsuitable without
providing the actual explanation for why?

Cheers,
Conor.

> 
> * Driver implementation
> 
> Serial interfaces (SITF) are shared resources managed directly by the
> MDF core and no longer have separate platform devices. This revision
> retains their DT nodes to describe configuration and clock connections,
> and to allow filters to reference their input bitstreams without
> duplicating shared settings.
> 
> This revision also retains a platform device for each MDF filter, as
> each filter manages its own registers, interrupt, DMA channel and IIO
> acquisition state, with a separate suspend/resume lifecycle.
> 
> * Clock management
> 
> Several clock-management review comments are addressed in this revision:
> - The provider-side clock-frequency property has been removed. Consumers
>   request CCK rates through assigned-clocks and assigned-clock-rates.
> - The clock-names property has been removed. The core acquires its single
>   input clock by index, and CCK gating uses regmap-based clock operations.
> - Remove the unused clock-ranges property, as the core now explicitly
>   shares the kernel clock with the serial interfaces and filters instead
>   of relying on parent clock lookup.
> 
> Clock topology point remains open, awaiting clarification of the MDF topology.
> 
> Changes since v1:
> - Split the large IIO driver patch into smaller functional patches.
> - Replace provider-side clock-frequency with consumer-assigned CCK rates
>   through the common clock framework.
> - Remove the platform devices for serial interfaces.
> - Replace the interleave phandle list with a filter count, covering
>   consecutive filters starting at filter 0.
> - Simplify clock-output-names, remove clock-names, reset-names and
>   filter-level clock properties, and move mdf-dai into an explicit
>   property outside the conditional schema.
> - Rename the binding to match the STM32MP25 compatible, sort compatible
>   entries, and simplify the binding patch subject.
> - Use unsigned long for match data, improve probe error reporting and
>   wrapping, remove a probe-success debug message, and add kernel-doc for
>   exported core functions.
> - Use scoped spinlock guards.
> - Remove empty serial-interface runtime-PM callbacks.
> - Remove the redundant ASoC platform module alias.
> 
> Additional fixes since v1 (following Sashiko review):
> - Compute the settling-time discard count with 64-bit arithmetic.
> - Size cyclic DMA periods in complete scans and validate buffer and
>   period alignment before starting DMA.
> - Fix backend-enable rollback so backend zero is disabled as well.
> - Use managed allocation for the conversion buffer and managed IIO
>   triggered-buffer setup.
> - Release temporary synchronization and serial-interface firmware-node
>   references. Replacing interleave phandles also removes the associated
>   stored node references.
> - Avoid unregistering secondary interleaved filters that were never
>   registered as IIO devices.
> - Use managed acquisition of the optional serial clock.
> - Replace the GCD-based CCK divider selection with a search for the
>   largest valid divisor, allowing non-power-of-two divider values.
> - Remove the selection of the undefined COMMON_CLK_REGMAP symbol.
> 
> Previous discussion:
> https://lore.kernel.org/all/20261001145702.2628429-1-olivier.moysan@foss.st.com/
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
> Olivier Moysan (11):
>       dt-bindings: iio: adc: add stm32mp2 mdf filter
>       iio: adc: stm32-mdf: add core registration
>       iio: adc: stm32-mdf: add cck clocks provider
>       iio: adc: stm32-mdf: add serial interfaces support
>       iio: adc: stm32-mdf: add digital filter device support
>       iio: adc: stm32-mdf: configure cic filters and sample rates
>       iio: adc: stm32-mdf: add direct iio conversion support
>       iio: adc: stm32-mdf: add dma buffered acquisition support
>       iio: adc: stm32-mdf: add external timer trigger support
>       iio: adc: stm32-mdf: add dmic audio filter support
>       ASoC: stm32: add mdf dai support
> 
>  .../bindings/iio/adc/st,stm32mp25-mdf.yaml         |  341 ++++
>  drivers/iio/adc/Kconfig                            |   29 +
>  drivers/iio/adc/Makefile                           |    3 +
>  drivers/iio/adc/stm32-mdf-adc.c                    | 2080 ++++++++++++++++++++
>  drivers/iio/adc/stm32-mdf-core.c                   |  899 +++++++++
>  drivers/iio/adc/stm32-mdf-serial.c                 |  223 +++
>  drivers/iio/adc/stm32-mdf.h                        |  275 +++
>  include/linux/iio/adc/stm32-mdf-adc.h              |   19 +
>  sound/soc/stm/Kconfig                              |   15 +
>  sound/soc/stm/Makefile                             |    3 +
>  sound/soc/stm/stm32_amdf.c                         |  375 ++++
>  11 files changed, 4262 insertions(+)
> ---
> base-commit: d922ed738439e1d5b4701df7f4cdd49a09925624
> change-id: 20261112-upstream_mdf_v2-76040d99138e
> 
> Best regards,
> --  
> Olivier Moysan <olivier.moysan@foss.st.com>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2026-11-19 18:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:17 Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 01/11] dt-bindings: iio: adc: add stm32mp2 mdf filter Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 02/11] iio: adc: stm32-mdf: add core registration Olivier Moysan
2026-11-19  9:44   ` Andy Shevchenko
2026-11-18 15:17 ` [PATCH v2 03/11] iio: adc: stm32-mdf: add cck clocks provider Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 04/11] iio: adc: stm32-mdf: add serial interfaces support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 05/11] iio: adc: stm32-mdf: add digital filter device support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 06/11] iio: adc: stm32-mdf: configure cic filters and sample rates Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 07/11] iio: adc: stm32-mdf: add direct iio conversion support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 08/11] iio: adc: stm32-mdf: add dma buffered acquisition support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 09/11] iio: adc: stm32-mdf: add external timer trigger support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 10/11] iio: adc: stm32-mdf: add dmic audio filter support Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 11/11] ASoC: stm32: add mdf dai support Olivier Moysan
2026-11-19 18:37 ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119-stick-armored-64cd8e1cea62@spud \
    --to=conor@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andy@kernel.org \
    --cc=arnaud.pouliquen@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=p.zabel@pengutronix.de \
    --cc=perex@perex.cz \
    --cc=phasta@kernel.org \
    --cc=robh@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®