mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Rajneesh Bhardwaj" <irenic.rajneesh@gmail.com>,
	"Xi Pardee" <xi.pardee@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, tzungbi@kernel.org,
	linux-kernel@vger.kernel.org, tfiga@chromium.org
Subject: [PATCH v4 0/3] platform/x86/intel/pmc: Disable ACPI PM timer during suspend on PTL
Date: Thu, 19 Nov 2026 03:01:14 +0000	[thread overview]
Message-ID: <20261119030117.3943303-1-tzungbi@kernel.org> (raw)

When the ACPI PM timer is enabled by firmware on Panther Lake to drive
the wdat_wdt hardware watchdog, leaving it running during s2idle blocks
S0i2.2 entry (keeping the SoC in S0i2.1).

This series adds lockless support in intel_pmc_core to disable the ACPI
PM timer during suspend and restore it on resume if it was previously
enabled:

- Patch 1 adds static inline stubs for the acpi_pm suspend/resume
  callback helpers when CONFIG_X86_PM_TIMER is disabled.

- Patch 2 adds generic opt-in support in intel_pmc_core via
  struct pmc_reg_map.

- Patch 3 opts Panther Lake in.

Note on testing: Runtime s2idle testing was performed with
CONFIG_X86_PM_TIMER=n (TSC clocksource).  The CONFIG_X86_PM_TIMER=y path
has only been compile-tested.

Regarding Wildcat Lake (WCL): I'm not sure whether WCL needs the same
fix and don't have WCL hardware to verify it, so this series keeps the
opt-in scoped to Panther Lake.  With Patch 2 in place, WCL can easily
opt in via wcl_pcdn_reg_map if needed.

---
v4:
- Split into a 3-patch series.
- Hook acpi_pmtmr_register_suspend_resume_callback() when
  CONFIG_X86_PM_TIMER=y to preserve ordering vs. the acpi_pm clocksource.
- Include S0i2.1/S0i2.2 residency evidence in Patch 3.

v3: https://lore.kernel.org/all/20261112032040.930597-1-tzungbi@kernel.org
- Rebase to next-20261111.

v2: https://lore.kernel.org/all/20261016075416.3139759-1-tzungbi@kernel.org
- Include <linux/bits.h> for BIT().
- Rename ptl_set_acpi_pm_timer_on_suspend() -> ptl_set_acpi_pm_timer().
- Update register values on separate lines.

v1: https://lore.kernel.org/all/20261015035712.3604634-1-tzungbi@kernel.org

Tzung-Bi Shih (3):
  clocksource: acpi_pm: Add stubs for suspend/resume callback helpers
  platform/x86/intel/pmc: Support disabling ACPI PM timer during suspend
  platform/x86/intel/pmc: Disable ACPI PM timer during suspend on
    Panther Lake

 drivers/platform/x86/intel/pmc/core.c | 49 +++++++++++++++++++++++++++
 drivers/platform/x86/intel/pmc/core.h | 11 ++++++
 drivers/platform/x86/intel/pmc/ptl.c  |  2 ++
 include/linux/acpi_pmtmr.h            |  5 +++
 4 files changed, 67 insertions(+)

-- 
2.56.1.708.g77570a6a1d-goog


             reply	other threads:[~2026-11-19  3:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:01 Tzung-Bi Shih [this message]
2026-11-19  3:01 ` [PATCH v4 1/3] clocksource: acpi_pm: Add stubs for suspend/resume callback helpers Tzung-Bi Shih
2026-11-19  3:01 ` [PATCH v4 2/3] platform/x86/intel/pmc: Support disabling ACPI PM timer during suspend Tzung-Bi Shih
2026-11-19  3:01 ` [PATCH v4 3/3] platform/x86/intel/pmc: Disable ACPI PM timer during suspend on Panther Lake Tzung-Bi Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119030117.3943303-1-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=xi.pardee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®