mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Rajneesh Bhardwaj" <irenic.rajneesh@gmail.com>,
	"Xi Pardee" <xi.pardee@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, tzungbi@kernel.org,
	linux-kernel@vger.kernel.org, tfiga@chromium.org
Subject: [PATCH v4 3/3] platform/x86/intel/pmc: Disable ACPI PM timer during suspend on Panther Lake
Date: Thu, 19 Nov 2026 03:01:17 +0000	[thread overview]
Message-ID: <20261119030117.3943303-4-tzungbi@kernel.org> (raw)
In-Reply-To: <20261119030117.3943303-1-tzungbi@kernel.org>

When the ACPI PM timer is enabled by firmware on Panther Lake to drive
wdat_wdt, leaving it running during s2idle prevents S0i2.2 entry
(staying in S0i2.1).

Populate acpi_pm_tmr_ctl_offset (PWRMBASE + 0x18fc) and
acpi_pm_tmr_disable_bit (BIT(1)) in ptl_pcdp_reg_map to disable the
timer during suspend.

Tested on a Panther Lake Android desktop device (coreboot with
CONFIG_USE_PM_ACPI_TIMER=y, kernel 6.18 with CONFIG_X86_PM_TIMER=n,
wdat_wdt not active):

- Without patch:
    S0i2.1: 100.00% (345,382 ms), S0i2.2: 0.00% (0 ms)
- With patch:
    S0i2.1: 0.00% (11 ms), S0i2.2: 99.99% (343,699 ms)

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
v4:
- Reduce to ptl_pcdp_reg_map opt-in using the common helper from patch 2.
- Add S0i2.1/S0i2.2 residency results to the commit message.
---
 drivers/platform/x86/intel/pmc/ptl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/intel/pmc/ptl.c b/drivers/platform/x86/intel/pmc/ptl.c
index a7d5d4f77934..a38b099679b3 100644
--- a/drivers/platform/x86/intel/pmc/ptl.c
+++ b/drivers/platform/x86/intel/pmc/ptl.c
@@ -529,6 +529,8 @@ static const struct pmc_reg_map ptl_pcdp_reg_map = {
 	.num_s0ix_blocker = PTL_NUM_S0IX_BLOCKER,
 	.blocker_req_offset = PTL_BLK_REQ_OFFSET,
 	.lpm_req_guid = PCDP_LPM_REQ_GUID,
+	.acpi_pm_tmr_ctl_offset = ACPI_TMR_CTL_OFFSET,
+	.acpi_pm_tmr_disable_bit = ACPI_TIM_DIS,
 };
 
 static struct pmc_info ptl_pmc_info_list[] = {
-- 
2.56.1.708.g77570a6a1d-goog


      parent reply	other threads:[~2026-11-19  3:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:01 [PATCH v4 0/3] platform/x86/intel/pmc: Disable ACPI PM timer during suspend on PTL Tzung-Bi Shih
2026-11-19  3:01 ` [PATCH v4 1/3] clocksource: acpi_pm: Add stubs for suspend/resume callback helpers Tzung-Bi Shih
2026-11-19  3:01 ` [PATCH v4 2/3] platform/x86/intel/pmc: Support disabling ACPI PM timer during suspend Tzung-Bi Shih
2026-11-19  3:01 ` Tzung-Bi Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119030117.3943303-4-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=xi.pardee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®