mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lin Liu <lin.liu01@citrix.com>
To: ross.lagerwall@citrix.com, jgross@suse.com
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
	andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/swiotlb: Check the segment boundary in range_straddles_page_boundary()
Date: Thu, 19 Nov 2026 04:35:04 +0000	[thread overview]
Message-ID: <20261119043504.2013850-1-lin.liu01@citrix.com> (raw)
In-Reply-To: <8a57f3f6-c649-4be0-8e14-2cc16dd41f8f@suse.com>

On 18/11/2026 12:24, Jürgen Groß wrote:
> On 18.11.26 12:25, Ross Lagerwall wrote:
>> Is the change actually needed for alloc_coherent / free_coherent?
>> The allocation from __get_free_pages() is naturally aligned and
>> range_requires_alignment() requires it has the same alignment so it is
>> naturally aligned in bus space. I don't think that it can cross a
>> segment boundary then.
>
> Hmm, agreed.

Thanks both.  Agreed, the check is unnecessary for the coherent paths.
I had noted this in the commit message ("coherent allocations are already
naturally aligned via range_requires_alignment()"), but the code still
changed them.

For v2 I plan to leave range_straddles_page_boundary() and the coherent
paths untouched, and check only streaming mappings, with a small helper
next to range_straddles_page_boundary():

/* Bus-contiguous, but may still cross the device's segment boundary */
static inline bool range_crosses_seg_boundary(struct device *dev,
					      dma_addr_t dma, size_t size)
{
	unsigned long mask = dma_get_seg_boundary(dev);

	return size && ((dma ^ (dma + size - 1)) & ~mask);
}

used in xen_swiotlb_map_phys():

	if (dma_capable(dev, dev_addr, size, true, attrs) &&
	    !dma_kmalloc_needs_bounce(dev, size, dir) &&
	    !range_straddles_page_boundary(phys, size) &&
	    !range_crosses_seg_boundary(dev, dev_addr, size) &&
		!xen_arch_need_swiotlb(dev, phys, dev_addr) &&
		!is_swiotlb_force_bounce(dev))
		goto done;

A mapping larger than the boundary window also takes the bounce path:
swiotlb cannot find slots that do not span the boundary, so the mapping
fails instead of the device being handed a crossing range.

This is the shape of the version Jürgen first looked at, before the check
was moved into the helper.

I'll send v2 if you are both happy with that.

Lin

      reply	other threads:[~2026-11-19  4:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 12:47 Lin Liu
2026-11-18 11:25 ` Ross Lagerwall
2026-11-18 12:24   ` Jürgen Groß
2026-11-19  4:35     ` Lin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119043504.2013850-1-lin.liu01@citrix.com \
    --to=lin.liu01@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®