mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manuel Ebner <manuelebnerli@mailbox.org>
To: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>
Cc: Manuel Ebner <manuelebnerli@mailbox.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] docs: doc-guide: add hint to review patch
Date: Thu, 19 Nov 2026 06:54:03 +0100	[thread overview]
Message-ID: <20261119055403.1294471-2-manuelebnerli@mailbox.org> (raw)

For the case of a duplicate patch, review the other patch instead of
sending own patch.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
I was considering
>If the other patch hasn't been applied to _mainline_ yet it's good
>to review it and state that by replying with the 'Reviewed-by:' tag.
which is better?

[v2]
 'send review' -> 'review and send reviewed tag' (Jonathan Corbet)
 'applied ' +'to next'

[v1]
 https://lore.kernel.org/all/20261116082209.1100175-2-manuelebnerli@mailbox.org/
---
 Documentation/doc-guide/contributing.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/doc-guide/contributing.rst b/Documentation/doc-guide/contributing.rst
index ee2f896a21..3657408a5e 100644
--- a/Documentation/doc-guide/contributing.rst
+++ b/Documentation/doc-guide/contributing.rst
@@ -129,9 +129,9 @@ looked like this::
 The entire process only took a few minutes.  Of course, I then found that
 somebody else had fixed it in a separate tree, highlighting another lesson:
 always check linux-next to see if a problem has been fixed before you dig
-into it.  If the other patch isn't applied yet it's good to give it a
-'Reviewed-by:' tag to help it get applied.  This way your effort is not in
-vain.
+into it.  If the other patch hasn't been applied to linux-next yet it's good
+to review it and state that by replying with the 'Reviewed-by:' tag.  This
+helps getting the patch applied, so your effort is not in vain after all.
 
 Other fixes will take longer, especially those relating to structure
 members or function parameters that lack documentation.  In such cases, it
-- 
2.56.0


                 reply	other threads:[~2026-11-19  6:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119055403.1294471-2-manuelebnerli@mailbox.org \
    --to=manuelebnerli@mailbox.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®