* [PATCH v2] docs: doc-guide: add hint to review patch
@ 2026-11-19 5:54 Manuel Ebner
0 siblings, 0 replies; only message in thread
From: Manuel Ebner @ 2026-11-19 5:54 UTC (permalink / raw)
To: Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: Manuel Ebner, linux-doc, linux-kernel
For the case of a duplicate patch, review the other patch instead of
sending own patch.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
I was considering
>If the other patch hasn't been applied to _mainline_ yet it's good
>to review it and state that by replying with the 'Reviewed-by:' tag.
which is better?
[v2]
'send review' -> 'review and send reviewed tag' (Jonathan Corbet)
'applied ' +'to next'
[v1]
https://lore.kernel.org/all/20261116082209.1100175-2-manuelebnerli@mailbox.org/
---
Documentation/doc-guide/contributing.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/doc-guide/contributing.rst b/Documentation/doc-guide/contributing.rst
index ee2f896a21..3657408a5e 100644
--- a/Documentation/doc-guide/contributing.rst
+++ b/Documentation/doc-guide/contributing.rst
@@ -129,9 +129,9 @@ looked like this::
The entire process only took a few minutes. Of course, I then found that
somebody else had fixed it in a separate tree, highlighting another lesson:
always check linux-next to see if a problem has been fixed before you dig
-into it. If the other patch isn't applied yet it's good to give it a
-'Reviewed-by:' tag to help it get applied. This way your effort is not in
-vain.
+into it. If the other patch hasn't been applied to linux-next yet it's good
+to review it and state that by replying with the 'Reviewed-by:' tag. This
+helps getting the patch applied, so your effort is not in vain after all.
Other fixes will take longer, especially those relating to structure
members or function parameters that lack documentation. In such cases, it
--
2.56.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-19 6:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 5:54 [PATCH v2] docs: doc-guide: add hint to review patch Manuel Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®