* [PATCH v3 0/2] TDX: P-SEAMLDR: Support large TDX modules and sigstructs
@ 2026-11-19 7:49 Chao Gao
2026-11-19 7:49 ` [PATCH v3 1/2] x86/virt/seamldr: Support large TDX module binaries Chao Gao
2026-11-19 7:49 ` [PATCH v3 2/2] x86/virt/seamldr: Support multiple sigstruct pages Chao Gao
0 siblings, 2 replies; 3+ messages in thread
From: Chao Gao @ 2026-11-19 7:49 UTC (permalink / raw)
To: x86, linux-coco, kvm, linux-kernel
Cc: yilun.xu, arjan.van.de.ven, binbin.wu, Chao Gao, Kiryl Shutsemau,
Rick Edgecombe, Dave Hansen, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin
This series lets TDX module updates handle large TDX modules and
sigstructs. I dropped the RFC tag because there are no open design
questions.
Dave, feel free to ignore this series for now. TDX developers, please
take a look. I would like to collect Reviewed-by tags on this version.
== Changes ==
Changes since RFC v2:
There is no functional change. Apart from comments, the code differs
from v2 only in how the maximum module page count is derived.
- Compute the size of module_pages_pa_list[] from the size of 'struct
seamldr_params' and explain the math. [Rick/Yilun]
- Call out that a 496-page module now requires chaining support. [Binbin]
- Drop the exact entry counts (496/495) from the ABI description. [Yilun]
- Note in a comment that sigstruct_pages_pa_list[] is never chained. [Yilun]
- Comment the PAGE_ALIGNED() check in populate_pa_list(). [Rick]
- Explain why the sigstruct list is already filled in a loop. [Rick]
- Drop the AI usage note from changelogs. [Dave]
- Rework changelogs to be easier to follow.
v2: https://lore.kernel.org/all/20261106132159.1551365-1-chao.gao@intel.com/
v1: https://lore.kernel.org/kvm/20261030085304.3886520-1-chao.gao@intel.com/
===
This series is a follow-up to the TDX module update series. As thanks
for merging that series, we agreed to take on the TDX metadata cleanup [1].
With the cleanup converging, we are starting on this work and expect it
to be merged after the cleanup.
Today a TDX module binary can be at most 496 pages and its sigstruct at
most one page. Both limits come from the P-SEAMLDR ABI.
TDX modules are outgrowing them. A post-quantum signature algorithm
pushes the sigstruct past 4KB, and new module features push the binary
past 496 pages. The P-SEAMLDR ABI was extended for both.
The kernel rejects any image over these limits. TDX modules for Diamond
Rapids exceed them, so without this series, TDX module updates fail on
Diamond Rapids. This series is all that is needed to make them work.
The image format that userspace uploads ('struct tdx_image') is generic
enough and needs no change.
== AI Usage ==
AI was used under supervision to review code and refine commit messages.
== Testing ==
Tested on a Diamond Rapids system. Updates with a module larger than 2MB
and an 8KB sigstruct work, which exercises both the chained page list
and version 1 of 'struct seamldr_params'. TDs keep running across
updates.
== P-SEAMLDR ABI changes ==
The public P-SEAMLDR specification will be updated to document these
ABI extensions. Until then, here are the changes to
'struct seamldr_params' that this series relies on:
- VERSION (offset 0) may now be 1. Version 1 support is enumerated by
bit 8 of SEAMLDR_FEATURES0.
- SIGSTRUCT_PA_1..3 (offsets 16, 24 and 32) are new. In version 1, they
hold the addresses of the second to fourth sigstruct pages, or 0 if
the sigstruct does not reach that page. In version 0, they must be 0.
- RESERVED shrinks from 104 to 80 bytes and now starts at offset 40.
- MOD_PAGES_PA_LIST (offset 128) can be chained. For a module over 495
pages, its last entry points to a 4KB page holding up to 511 more
addresses. Each such page uses its last entry to point to the next
page, until all module pages are listed. Chaining support is enumerated
by bit 11 of SEAMLDR_FEATURES0.
Chao Gao (2):
x86/virt/seamldr: Support large TDX module binaries
x86/virt/seamldr: Support multiple sigstruct pages
arch/x86/virt/vmx/tdx/seamldr.c | 48 +++++++++++++++++++++++++++------
1 file changed, 40 insertions(+), 8 deletions(-)
base-commit: 5b8212d45d99b77c84e3ad305a295e9e65d5ef20
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/2] x86/virt/seamldr: Support large TDX module binaries
2026-11-19 7:49 [PATCH v3 0/2] TDX: P-SEAMLDR: Support large TDX modules and sigstructs Chao Gao
@ 2026-11-19 7:49 ` Chao Gao
2026-11-19 7:49 ` [PATCH v3 2/2] x86/virt/seamldr: Support multiple sigstruct pages Chao Gao
1 sibling, 0 replies; 3+ messages in thread
From: Chao Gao @ 2026-11-19 7:49 UTC (permalink / raw)
To: linux-kernel, linux-coco, kvm
Cc: yilun.xu, arjan.van.de.ven, binbin.wu, Chao Gao, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin,
Kiryl Shutsemau, Rick Edgecombe
TDX module binaries are limited to just under 2MB. The binary is handed
to P-SEAMLDR as a list of page physical addresses in
'struct seamldr_params', and the list must fit in a single 4KB page
along with a few other fields.
TDX modules are gaining features and are about to outgrow that limit.
The P-SEAMLDR ABI was extended to let the list continue onto more 4KB
pages. The last u64 of each page holds the physical address of the next
page, chaining the pages together.
Grow module_pages_pa_list[] so that 'struct seamldr_params' spans 16
pages, and chain the pages together in populate_pa_list().
Each page uses its last entry for chaining, so the maximum module page
count is the array size minus one entry per page. The user-supplied
image is checked against this count.
The 16-page size is somewhat arbitrary. It fits modules of up to about
32MB, far above the roughly 2MB of current modules. It wastes 60KB for
today's modules, which is fine because the memory is freed right after
the update.
Do not query P-SEAMLDR for chaining support. Userspace selects the
update image and is responsible for ensuring the module is compatible
with P-SEAMLDR.
A 496-page module (the old maximum) used to fit in a single page. Now
the last entry of that page is used for chaining, so the final address
moves to a second page and the module requires chaining support. Do not
special-case this size to make it work with a P-SEAMLDR without
chaining support. No released module has exactly 496 pages, so nothing
breaks. Leave it to userspace to ensure any future 496-page module is
paired with a P-SEAMLDR that supports chaining, as with larger modules.
Signed-off-by: Chao Gao <chao.gao@intel.com>
---
Alternative (tried in v1, dropped in v2):
Sizing module_pages_pa_list[] per module needs the page count from the
image header. The allocation would have to either move after the header
is validated, as v1 did, or use an unvalidated count. Either way it is
more code churn than a fixed 16 pages.
v3:
- Explain the math of the max module page count [Rick/Yilun]
- Call out the 496-page behavior change [Binbin]
- Drop the exact numbers (496/495) from the ABI description [Yilun]
- Drop the boilerplate AI usage note [Dave]
- Note that sigstruct_pages_pa_list[] is never chained [Yilun]
- Comment the PAGE_ALIGNED() check in populate_pa_list() [Rick]
v2:
- Make 'struct seamldr_params' a fixed 16 pages instead of sizing it
to each module, capping modules at about 32MB. [Rick]
- Drop the patch that moved the allocation after image validation. [Rick]
---
arch/x86/virt/vmx/tdx/seamldr.c | 37 +++++++++++++++++++++++++++------
1 file changed, 31 insertions(+), 6 deletions(-)
diff --git a/arch/x86/virt/vmx/tdx/seamldr.c b/arch/x86/virt/vmx/tdx/seamldr.c
index b1137ca6150d..6b9657a28129 100644
--- a/arch/x86/virt/vmx/tdx/seamldr.c
+++ b/arch/x86/virt/vmx/tdx/seamldr.c
@@ -24,7 +24,20 @@
#define P_SEAMLDR_INFO 0x8000000000000000
#define P_SEAMLDR_INSTALL 0x8000000000000001
-#define SEAMLDR_MAX_NR_MODULE_PAGES 496
+/*
+ * 'struct seamldr_params' spans this many pages. The number is somewhat
+ * arbitrary and fits modules of up to about 32MB. Increase it if modules
+ * outgrow that.
+ */
+#define SEAMLDR_PARAMS_NR_PAGES 16
+
+/*
+ * module_pages_pa_list[] fills the rest of 'struct seamldr_params' after
+ * its first 128 bytes. The last entry of each page is reserved to point
+ * to the next page. The last entry of the final page is never used.
+ */
+#define SEAMLDR_NR_MODULE_PA_ENTRIES ((SEAMLDR_PARAMS_NR_PAGES * PAGE_SIZE - 128) / sizeof(u64))
+#define SEAMLDR_MAX_NR_MODULE_PAGES (SEAMLDR_NR_MODULE_PA_ENTRIES - SEAMLDR_PARAMS_NR_PAGES)
#define SEAMLDR_MAX_NR_SIG_PAGES 1
/*
@@ -48,10 +61,10 @@ struct seamldr_params {
u64 sigstruct_pages_pa_list[SEAMLDR_MAX_NR_SIG_PAGES];
u8 reserved[104];
u64 module_nr_pages;
- u64 module_pages_pa_list[SEAMLDR_MAX_NR_MODULE_PAGES];
+ u64 module_pages_pa_list[SEAMLDR_NR_MODULE_PA_ENTRIES];
} __packed;
-static_assert(sizeof(struct seamldr_params) == 4096);
+static_assert(sizeof(struct seamldr_params) == SEAMLDR_PARAMS_NR_PAGES * PAGE_SIZE);
/*
* Serialize P-SEAMLDR calls since the hardware only allows a single CPU to
@@ -130,16 +143,28 @@ struct tdx_image {
* Given a vmalloc() allocation, write all of the backing physical
* addresses to pa_list[]. Caller guarantees that the array is big
* enough.
+ *
+ * If pa_list[] spans multiple pages, chain them by pointing the last
+ * entry of each page to the next page. Note that a pa_list[] that
+ * does not cross a page boundary, such as sigstruct_pages_pa_list[],
+ * is never chained.
*/
static void populate_pa_list(u64 *pa_list, const u8 *vmalloc_addr, u32 vmalloc_len_pages)
{
- int i;
+ int i, j;
- for (i = 0; i < vmalloc_len_pages; i++) {
+ for (i = 0, j = 0; i < vmalloc_len_pages; i++) {
unsigned long offset = i * PAGE_SIZE;
unsigned long pfn = vmalloc_to_pfn(&vmalloc_addr[offset]);
- pa_list[i] = pfn << PAGE_SHIFT;
+ /* Point the last entry of a page to the next page. */
+ if (PAGE_ALIGNED(&pa_list[j + 1])) {
+ pa_list[j] = __pa(&pa_list[j + 1]);
+ j++;
+ }
+
+ pa_list[j] = pfn << PAGE_SHIFT;
+ j++;
}
}
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] x86/virt/seamldr: Support multiple sigstruct pages
2026-11-19 7:49 [PATCH v3 0/2] TDX: P-SEAMLDR: Support large TDX modules and sigstructs Chao Gao
2026-11-19 7:49 ` [PATCH v3 1/2] x86/virt/seamldr: Support large TDX module binaries Chao Gao
@ 2026-11-19 7:49 ` Chao Gao
1 sibling, 0 replies; 3+ messages in thread
From: Chao Gao @ 2026-11-19 7:49 UTC (permalink / raw)
To: linux-kernel, linux-coco, kvm
Cc: yilun.xu, arjan.van.de.ven, binbin.wu, Chao Gao, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin,
Kiryl Shutsemau, Rick Edgecombe
TDX module sigstructs are limited to 4KB. Each update image carries a
sigstruct, which is handed to P-SEAMLDR in 'struct seamldr_params'
along with the module binary. The structure has room for the physical
address of only one sigstruct page.
TDX modules are moving to a post-quantum signature algorithm. Its
signatures are far larger than the ones in use today, so the sigstruct
no longer fits in 4KB.
The P-SEAMLDR ABI was extended to take up to four sigstruct pages
(16KB). Setting 'version' to 1 tells P-SEAMLDR to use this layout.
Grow sigstruct_pages_pa_list[] to four entries to match. In anticipation
of this change, the list is already filled in a loop, so filling the
new entries needs no new code.
Use version 1 only when the sigstruct spans more than one page. Old
P-SEAMLDRs reject version 1, so this keeps today's modules working on
them.
Do not query P-SEAMLDR for version 1 support. Userspace selects the
update image and is responsible for ensuring the module is compatible
with P-SEAMLDR.
Signed-off-by: Chao Gao <chao.gao@intel.com>
---
v3:
- Explain why sigstruct filling code is a loop already [Rick]
- Drop the boilerplate AI usage note [Dave]
v2:
- drop macros for versions to keep the diff minimal
- explain why the sigstruct filling code needs no change
---
arch/x86/virt/vmx/tdx/seamldr.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/x86/virt/vmx/tdx/seamldr.c b/arch/x86/virt/vmx/tdx/seamldr.c
index 6b9657a28129..7c09c84df1aa 100644
--- a/arch/x86/virt/vmx/tdx/seamldr.c
+++ b/arch/x86/virt/vmx/tdx/seamldr.c
@@ -38,7 +38,7 @@
*/
#define SEAMLDR_NR_MODULE_PA_ENTRIES ((SEAMLDR_PARAMS_NR_PAGES * PAGE_SIZE - 128) / sizeof(u64))
#define SEAMLDR_MAX_NR_MODULE_PAGES (SEAMLDR_NR_MODULE_PA_ENTRIES - SEAMLDR_PARAMS_NR_PAGES)
-#define SEAMLDR_MAX_NR_SIG_PAGES 1
+#define SEAMLDR_MAX_NR_SIG_PAGES 4
/*
* The seamldr_params "scenario" field specifies the operation mode:
@@ -59,7 +59,7 @@ struct seamldr_params {
u32 version;
u32 scenario;
u64 sigstruct_pages_pa_list[SEAMLDR_MAX_NR_SIG_PAGES];
- u8 reserved[104];
+ u8 reserved[80];
u64 module_nr_pages;
u64 module_pages_pa_list[SEAMLDR_NR_MODULE_PA_ENTRIES];
} __packed;
@@ -173,6 +173,13 @@ static void populate_seamldr_params(struct seamldr_params *params,
const u8 *mod, u32 mod_nr_pages)
{
params->version = 0;
+ /*
+ * Use version 1 only for multi-page sigstructs, to stay
+ * compatible with old P-SEAMLDRs that lack version 1 support.
+ */
+ if (sig_nr_pages > 1)
+ params->version = 1;
+
params->scenario = SEAMLDR_SCENARIO_UPDATE;
params->module_nr_pages = mod_nr_pages;
--
2.52.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 7:49 [PATCH v3 0/2] TDX: P-SEAMLDR: Support large TDX modules and sigstructs Chao Gao
2026-11-19 7:49 ` [PATCH v3 1/2] x86/virt/seamldr: Support large TDX module binaries Chao Gao
2026-11-19 7:49 ` [PATCH v3 2/2] x86/virt/seamldr: Support multiple sigstruct pages Chao Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®