mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3] ARM: l2c: honour status = "disabled" on the L2 cache node
@ 2026-11-19 10:09 Agustin Santiago Isasmendi
  0 siblings, 0 replies; only message in thread
From: Agustin Santiago Isasmendi @ 2026-11-19 10:09 UTC (permalink / raw)
  To: Russell King
  Cc: linux-arm-kernel, linux-kernel, Arnd Bergmann, Rob Herring,
	Stefan Dösinger, Navid Ghahremani, Krzysztof Kozlowski

l2x0_of_init() looks the L2 cache node up by compatible and enables the
cache whatever its status property says, so a device tree cannot keep
the L2 cache off.

On the ZTE ZX279128S (dual Cortex-A9, L2C-310 r3p3) a PCIe read on one
CPU deadlocks against an L2C-310 line operation by physical address or a
Cache Sync on the other CPU, and the board hangs within seconds of WiFi
traffic.  Running with the L2 cache off avoids the deadlock, so a board
needs a way to say so.

Honour the status property, as the newer cache controller drivers
already do (drivers/cache/ax45mp_cache.c, starfive_starlink_cache.c):
leave a disabled node alone.  The firmware is responsible for leaving
the cache disabled in that case; the kernel does not check.  No in-tree
L2 cache node is disabled, so nothing changes for existing device trees.

Tested on the ZTE ZXHN H3600: with the node disabled the cache stays
off and the system runs normally; with it enabled the cache comes up as
before.

Assisted-by: LLM
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Navid Ghahremani <ghahramani.navid@gmail.com>
Signed-off-by: Agustin Santiago Isasmendi <isasmendi.agus@gmail.com>
---
Changes in v3:
- drop the binding note, a disabled node is not touched anyway (Rob)
- of_node_put() the node on the disabled path
- add Navid's Tested-by
v2: https://lore.kernel.org/r/20261112072953.989664-1-isasmendi.agus@gmail.com

 arch/arm/mm/cache-l2x0.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
index 470867160076..44eb61481693 100644
--- a/arch/arm/mm/cache-l2x0.c
+++ b/arch/arm/mm/cache-l2x0.c
@@ -1772,6 +1772,12 @@ int __init l2x0_of_init(u32 aux_val, u32 aux_mask)
 	if (!np)
 		return -ENODEV;
 
+	if (!of_device_is_available(np)) {
+		pr_info("L2C: disabled by the device tree\n");
+		of_node_put(np);
+		return -ENODEV;
+	}
+
 	if (of_address_to_resource(np, 0, &res))
 		return -ENODEV;
 

base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
-- 
2.30.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 10:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 10:09 [PATCH v3] ARM: l2c: honour status = "disabled" on the L2 cache node Agustin Santiago Isasmendi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®