mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: "andriy.shevchenko@intel.com" <andriy.shevchenko@intel.com>
Cc: "Habil Eren Türker" <habilerenturker@hotmail.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 1/4] PCI: Add pci_power_t helper functions
Date: Thu, 19 Nov 2026 11:07:13 -0600	[thread overview]
Message-ID: <20261119170713.GA817259@bhelgaas> (raw)
In-Reply-To: <av8o-tHHScd0gjZM@ashevche-desk.local>

On Thu, Nov 19, 2026 at 06:51:06PM +0200, andriy.shevchenko@intel.com wrote:
> On Thu, Nov 19, 2026 at 02:35:46PM +0000, Habil Eren Türker wrote:
> > Add helper functions to extract, set and compare PCI power
> > states in the Power Management Control/Status register.
> ...

> > +/* Helper functions for PCI power management */
> > +static inline pci_power_t pci_power_t_get(u32 csr)
> 
> Why u32 as it seems the value is 16-bit?

I think there's one reader of PCI_PM_CTRL that does a 32-bit read, and
I figured a u16->u32 promotion would be better than a u32->u16
truncation.  But maybe that reader should be changed to a 16-bit read.

  reply	other threads:[~2026-11-19 17:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:35 [PATCH v2 0/4] " Habil Eren Türker
2026-11-19 14:35 ` [PATCH v2 1/4] " Habil Eren Türker
2026-11-19 16:51   ` andriy.shevchenko
2026-11-19 17:07     ` Bjorn Helgaas [this message]
2026-11-19 17:18       ` andriy.shevchenko
2026-11-19 17:23   ` Bjorn Helgaas
2026-11-19 14:35 ` [PATCH v2 2/4] PCI: Convert pci.c to pci_power_t helpers Habil Eren Türker
2026-11-19 17:09   ` andriy.shevchenko
2026-11-19 14:35 ` [PATCH v2 3/4] PCI: Convert quirks.c " Habil Eren Türker
2026-11-19 17:11   ` andriy.shevchenko
2026-11-19 14:35 ` [PATCH v2 4/4] x86/quirks: Use pci_power_eq() in apple_airport_reset() Habil Eren Türker
2026-11-19 17:14   ` andriy.shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119170713.GA817259@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=habilerenturker@hotmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®