From: "andriy.shevchenko@intel.com" <andriy.shevchenko@intel.com>
To: "Habil Eren Türker" <habilerenturker@hotmail.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 2/4] PCI: Convert pci.c to pci_power_t helpers
Date: Thu, 19 Nov 2026 19:09:49 +0200 [thread overview]
Message-ID: <av8tXbagXZeM443k@ashevche-desk.local> (raw)
In-Reply-To: <68e76d8e17030a21d3ee6df2f2109057f75147fd.1795097970.git.habilerenturker@hotmail.com>
On Thu, Nov 19, 2026 at 02:35:48PM +0000, Habil Eren Türker wrote:
> Convert PCI core code to use the pci_power_t helper functions
> when accessing the Power Management Control/Status register.
>
> Keep comparisons between values already typed as pci_power_t
> as direct typed comparisons.
Please, add a couple of examples of the sparse warnings.
...
> - state = pmcsr & PCI_PM_CTRL_STATE_MASK;
> -
> - need_restore = (state == PCI_D3hot || dev->current_state >= PCI_D3hot) &&
> + need_restore = (pci_power_eq(pmcsr, PCI_D3hot) ||
> + dev->current_state >= PCI_D3hot) &&
> !(pmcsr & PCI_PM_CTRL_NO_SOFT_RESET);
Please, fix indentation.
need_restore = !(pmcsr & PCI_PM_CTRL_NO_SOFT_RESET) &&
(pci_power_eq(pmcsr, PCI_D3hot) || dev->current_state >= PCI_D3hot);
Or create an additional temporary variable.
in_d3 = pci_power_eq(pmcsr, PCI_D3hot) || dev->current_state >= PCI_D3hot;
need_restore = in_d3 && !(pmcsr & PCI_PM_CTRL_NO_SOFT_RESET);
> - if (state == PCI_D0)
> + if (pci_power_eq(pmcsr, PCI_D0))
> goto end;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-19 17:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:35 [PATCH v2 0/4] PCI: Add pci_power_t helper functions Habil Eren Türker
2026-11-19 14:35 ` [PATCH v2 1/4] " Habil Eren Türker
2026-11-19 16:51 ` andriy.shevchenko
2026-11-19 17:07 ` Bjorn Helgaas
2026-11-19 17:18 ` andriy.shevchenko
2026-11-19 17:23 ` Bjorn Helgaas
2026-11-19 14:35 ` [PATCH v2 2/4] PCI: Convert pci.c to pci_power_t helpers Habil Eren Türker
2026-11-19 17:09 ` andriy.shevchenko [this message]
2026-11-19 14:35 ` [PATCH v2 3/4] PCI: Convert quirks.c " Habil Eren Türker
2026-11-19 17:11 ` andriy.shevchenko
2026-11-19 14:35 ` [PATCH v2 4/4] x86/quirks: Use pci_power_eq() in apple_airport_reset() Habil Eren Türker
2026-11-19 17:14 ` andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8tXbagXZeM443k@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=habilerenturker@hotmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®