mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] wifi: rtlwifi: Fix octal 024 typo in P2P_PS_OFFLOAD H2C command IDs
@ 2026-11-19 17:07 Ian Rogers
  0 siblings, 0 replies; only message in thread
From: Ian Rogers @ 2026-11-19 17:07 UTC (permalink / raw)
  To: Ping-Ke Shih; +Cc: linux-wireless, linux-kernel, llvm, Elkin Cruz, Ian Rogers

In rtl8821ae, rtl8192ee, and rtl8188ee, the H2C power-save command enums
define 0x20, 0x21, 0x22, 0x23 followed by 'H2C_*_P2P_PS_OFFLOAD = 024'.
The missing 'x' makes 024 an octal constant (decimal 20, 0x14) instead of
0x24 (decimal 36, matching H2C_8723B_P2P_PS_OFFLOAD = 0x24 in rtl8723be
and rtl8xxxu), sending the wrong H2C command ID to firmware during Wi-Fi
Direct P2P power-save offload updates.

Change 024 to 0x24 in all three headers.

Found via inspection of H2C command enums during an x86_64 LLVM=1
(Clang 21.1.8) allyesconfig warning audit; fix and changelog drafted with
an AI coding assistant. Build-tested under LLVM=1 W=1 (-Werror); not
tested on Realtek Wi-Fi hardware.

Fixes: f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver")
Fixes: 21e4b0726dc6 ("rtlwifi: rtl8821ae: Move driver from staging to regular tree")
Fixes: b1a3bfc97cd9 ("rtlwifi: rtl8192ee: Move driver from staging to the regular tree")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.h | 2 +-
 drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.h | 2 +-
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.h b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.h
index 79f095e47d71..583e1c51c5c9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.h
@@ -127,7 +127,7 @@ enum rtl8188e_h2c_cmd {
 	H2C_88E_PS_TUNING_PARA = 0x21,
 	H2C_88E_PS_TUNING_PARA2 = 0x22,
 	H2C_88E_PS_LPS_PARA = 0x23,
-	H2C_88E_P2P_PS_OFFLOAD = 024,
+	H2C_88E_P2P_PS_OFFLOAD = 0x24,
 
 #if (USE_OLD_WOWLAN_DEBUG_FW == 0)
 	H2C_88E_WO_WLAN = 0x80,
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.h
index 27ac4f8b9a9b..e485d6f8b6bc 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.h
@@ -89,7 +89,7 @@ enum rtl8192e_h2c_cmd {
 	H2C_92E_PS_TUNING_PARA = 0x21,
 	H2C_92E_PS_TUNING_PARA2 = 0x22,
 	H2C_92E_PS_LPS_PARA = 0x23,
-	H2C_92E_P2P_PS_OFFLOAD = 024,
+	H2C_92E_P2P_PS_OFFLOAD = 0x24,
 
 #if (USE_OLD_WOWLAN_DEBUG_FW == 0)
 	H2C_92E_WO_WLAN = 0x80,
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.h b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.h
index af8d17b9e012..d5e65186fc85 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.h
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.h
@@ -131,7 +131,7 @@ enum rtl8821a_h2c_cmd {
 	H2C_8821AE_PS_TUNING_PARA = 0x21,
 	H2C_8821AE_PS_TUNING_PARA2 = 0x22,
 	H2C_8821AE_PS_LPS_PARA = 0x23,
-	H2C_8821AE_P2P_PS_OFFLOAD = 024,
+	H2C_8821AE_P2P_PS_OFFLOAD = 0x24,
 
 	H2C_8821AE_WO_WLAN = 0x80,
 	H2C_8821AE_REMOTE_WAKE_CTRL = 0x81,
-- 
2.56.1.708.g77570a6a1d-goog


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-19 17:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 17:07 [PATCH] wifi: rtlwifi: Fix octal 024 typo in P2P_PS_OFFLOAD H2C command IDs Ian Rogers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®