* [PATCH] drm/tidss: Return drm_mode_status values from tidss_oldi_mode_valid()
@ 2026-11-19 17:10 Ian Rogers
0 siblings, 0 replies; only message in thread
From: Ian Rogers @ 2026-11-19 17:10 UTC (permalink / raw)
To: Jyri Sarha, Tomi Valkeinen, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, linux-kernel, llvm, Elkin Cruz, Ian Rogers
tidss_oldi_mode_valid() has return type enum drm_mode_status, but
returns -EINVAL (-22) when the rounded serial clock differs by more
than 5% and 0 otherwise. When drm_mode_prune_invalid() logs rejected
modes via drm_get_mode_status_name(), status == -22 computes a
negative table index (-19) and triggers a WARN_ON().
Return MODE_CLOCK_RANGE and MODE_OK instead, matching
dispc_vp_mode_valid().
Found via Clang -Wimplicit-int-enum-cast on an x86_64 allyesconfig
build. Verified by building drivers/gpu/drm/tidss/tidss_oldi.o with
LLVM=1 W=1 (-Werror) and -Wimplicit-int-enum-cast, and with a
standalone C reproducer; not runtime-tested on TI DSS OLDI hardware.
Fixes: 86db652fc22f ("drm/tidss: Move OLDI mode validation to OLDI bridge mode_valid hook")
Signed-off-by: Ian Rogers <irogers@google.com>
---
drivers/gpu/drm/tidss/tidss_oldi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_oldi.c b/drivers/gpu/drm/tidss/tidss_oldi.c
index 62c9780f7855..3b5046628642 100644
--- a/drivers/gpu/drm/tidss/tidss_oldi.c
+++ b/drivers/gpu/drm/tidss/tidss_oldi.c
@@ -322,9 +322,9 @@ tidss_oldi_mode_valid(struct drm_bridge *bridge,
* we use the same 5% check here.
*/
if (dispc_pclk_diff(mode->clock * 7 * 1000, round_clock) > 5)
- return -EINVAL;
+ return MODE_CLOCK_RANGE;
- return 0;
+ return MODE_OK;
}
static const struct drm_bridge_funcs tidss_oldi_bridge_funcs = {
--
2.56.1.708.g77570a6a1d-goog
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-19 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 17:10 [PATCH] drm/tidss: Return drm_mode_status values from tidss_oldi_mode_valid() Ian Rogers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®